From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 789F02EDD74 for ; Tue, 2 Sep 2025 10:10:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756807857; cv=none; b=QbZtUkHFtQLITX12YY9urPoKK97B+mE/L1a0fxDqbtw8lpZu28mjVinVbPcgMwzhHlhUW22g4ChYYqPR6ie+ZVL9aWi+hjUiAMofW8DOj4iWGk6/9hJVTDvdxQWBZt9Rea8kw1OmzGQ5di4seCaid2vpFF59UBLBaBmgEv6me6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756807857; c=relaxed/simple; bh=uQRbZpMZzS7UYewybYgEDAYd6OeeZC4wMAAbwE42GwA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rO+iulO1KfHaVk9Vpo+Wgz9ebzkZYtWI9FO+sqDpsfry2fmYVJOZqsrs+Ocw6JcFfxmTEjyV5cr+mtRNbwfuaKsgh3GywzEoVD1J0Cp9mBbq/kb/7X9YoBIOXp13BP6kS8aODAWQa2A7BXbFNd2pevr8yRgckjgnLseqX41nALc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XhwSZYx1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XhwSZYx1" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5822Y3Ak000383 for ; Tue, 2 Sep 2025 10:10:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= THYxMAXcq3NlTG1/1Gxwv/IFrQP4eSDyIsfIRZHUUKg=; b=XhwSZYx1QCW5reF6 LbAAnpn1ls2qOpFm35u+EM53VOPIEx/4PSSm9TFFi3G4YRioKHDpDmA/DRpuXfjA K7y33/f9OvhcYb7/7pVednZgXTe0bZtDqTtSXFYpDLtyHXBwfdaRXzT4bicKRtPD 3ln/yIOaawRA3iQHSjUF5ckXl0ALN+4i2GZNcxQl8Q1PToazSxA4Ve7TTtfzMlSM xJDJ+eazKfkM/nbSJ7HVkGpW3iyaeCgKEqfPYbaKswOYh/ZColeG9dw16Ln/MjQV QsopGXLxJWTvedAO6Ow+rOdmqTIHoMluNHGolD0K92515oDRQXfPZDWWBePv7HD/ wjfvXA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48wqvw9582-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 02 Sep 2025 10:10:55 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4b32dfb5c6fso10687041cf.1 for ; Tue, 02 Sep 2025 03:10:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756807854; x=1757412654; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=THYxMAXcq3NlTG1/1Gxwv/IFrQP4eSDyIsfIRZHUUKg=; b=IxuNSesSX+V6A3klMkA5tkDeldyh5/vCGDZBoy6suiHpG9hUKjnUIz4GC5IEIuHdTX GxIxtj1WkNigWql2QjYq28oz1zLRULVK9+5Qyynana2Q5tgd4p2tG0tsklKRpI7RMv6I zYh7C85KIrQfo3Es1p/RMu1B17ZjHx2/Es0CvXd9Aa6ZJ9hUZTjF86qEL3VzWzdeIZQb w/tVBujYIx6xwKFhSV8dCcZarWbYi8/lmQtvlBBtX29uQ7fB+nPcHulnqHQnlSGmOVoW ORq9z7KBHCYll9EodhCJXmUDO4DSy3YxF3b+h+w0PO8e/Q8rqfxkNMxtdaooftOPmPAh kitg== X-Forwarded-Encrypted: i=1; AJvYcCXOKw2Ixqiq6FLOgZ3UuqnlyvQmtpQcCV5YaGhPbGozRhCnIe24tCjRtq7pxyfSLiIOrrNlehE9F1LAj5A=@vger.kernel.org X-Gm-Message-State: AOJu0YyGlzh6aWZ+7o6BcAsoEkua9hYC0IqhjuiIm4QwowLCA0QafIoU F+aERW6gbbqsX799TUnbOFR59M1ndeVchRsHyyv8VSqj7T99n/+1xUTmpyR6Nz7HWtbBm4j9Bzj VVrI3b1CQYNj/VXd8MZlba4Ggk7duTmRAb18vvFHjh4IgAg+p2JYH1SFtvwS1S4O3rEY= X-Gm-Gg: ASbGnctV/1cEv9AG00iv6UrUeTAo5JmHHMcWkYzKRoVZLCXjoaYhBceDJvRPJgXQ3vl VbH4MrxVJH3Q+pgrdUKSI7Qtw/0WcxqobiLgizQiZWGbc0Tbu43NDxXTgqoPF/84KPvtQNpRlNP xF6SED54mHzLpiVdMjWTdJ89k1ZZxoPzQ8pGVheadqb0oEqZsCVWCd+lYVcoGbZXXcgKc9V5NA3 V0FFzOkaR/HWGRTzQb/pbKrklsoTII7GEKRMgdA0theqLUTDr4clxmF3v8SoLSLI17jK8vEKgad o4MkPkRnM7ZuRsFL7GJXW9SrXJfzvDAM7BfOC1O3E+jOMEIQgZiSIXtTfhvNsFCWOiMXiXPnxrS 3ZKc2+sX5DFs1IO2i97isIQ== X-Received: by 2002:a05:6214:252f:b0:70d:fda9:8118 with SMTP id 6a1803df08f44-70fa1e37ac5mr90373086d6.3.1756807854207; Tue, 02 Sep 2025 03:10:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHXA1MX+R32DY7z70Jxh6Fma+swPbMAM/TxTka9ZiM1Mii2YSXZKJfvdjD4E/i8Haz2dDeEoA== X-Received: by 2002:a05:6214:252f:b0:70d:fda9:8118 with SMTP id 6a1803df08f44-70fa1e37ac5mr90372936d6.3.1756807853750; Tue, 02 Sep 2025 03:10:53 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-61cfc1c7a8fsm9210260a12.3.2025.09.02.03.10.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Sep 2025 03:10:53 -0700 (PDT) Message-ID: Date: Tue, 2 Sep 2025 12:10:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: common: Fix NULL vs IS_ERR() check in qcom_cc_icc_register() To: Dan Carpenter , Varadarajan Narayanan Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTAyMDAyNCBTYWx0ZWRfX4o8f6MWUEzjA EEM0Q+FNcxZ1DHNY8O3lK9L50qd8T9iKRur+T2cEw455lJxJFTKsKU0LV3G+7LObqTkoh5/7Rn9 lGkT0sR1CfMfzkBfgEfwU3a4+sI/c1YkO5YyXat8MqDaWTfAJQW+h5lkEFbI/eZ442f24xdXJn0 suZTplI1/B7ryYVRA988aTC5HT/eFRLWicqci7BZA0ptcw/h5ptHd+f5FBpDSlCSXKcDRtJuYAa q5lHuVzWNK5TPJmx2oZmZHMk676yBDoxgC2UEaW3Eq/2f1+Tkb6dwkfwbgijczpYaIYoJA8++E7 gNOzPTZEjNhacdQyBL8NNUccYRV/dZSXMg9qFyti/aOMITH5xbIi13WC2W3QBciAo/5mSfTlJSP h6oBVQHn X-Authority-Analysis: v=2.4 cv=WKh/XmsR c=1 sm=1 tr=0 ts=68b6c2af cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=8T--ygq334zCgzS6G-IA:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=kacYvNCVWA4VmyqE58fU:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: sbSQNIYOtovOxbmYRfT0zGrV_Na5fg9c X-Proofpoint-ORIG-GUID: sbSQNIYOtovOxbmYRfT0zGrV_Na5fg9c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-02_03,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 phishscore=0 adultscore=0 spamscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509020024 On 9/2/25 8:33 AM, Dan Carpenter wrote: > The devm_clk_hw_get_clk() function doesn't return NULL, it returns error > pointers. Update the checking to match. > > Fixes: 8737ec830ee3 ("clk: qcom: common: Add interconnect clocks support") > Signed-off-by: Dan Carpenter > --- thanks! Reviewed-by: Konrad Dybcio Konrad