From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2358A2206B3 for ; Thu, 19 Dec 2024 09:51:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734601877; cv=none; b=p3GMZXMKhLgGGDeBouOd4dzpnZ5b3Ju+0N//UtPh69R2hqT6tD//XIAWQmt2x7Jk+YFnyDU2FY/jM8QXo0kSo36eG8hDUfdyytxN7KvLQAlarv/AmCytxNsydXyr7T5pyK2cap4Dxul3hw5xb/dLE+u4HWbowaD6HmPzWgnGzXk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734601877; c=relaxed/simple; bh=MOgjv8NLvbCJVNusxjVzb0ZjyoqeQDJ7L4XoYYYJcQU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MD7KjD8VYq0EGz1MBuA91uFcCWfch3BrUmc1aa0qzHzDrjTNRXnDg5pu+34N929f0I/Kd6YZ0iYssMfIpeR+TnoJPSkdRg9f9HiQh2NuMIYWbUQUOzuEnsprUeBHlBErdLTpsNCnfaFxIQTiP9GqFP0UXPmHXAIlAdBpmmd0ses= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LHGZhG7M; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LHGZhG7M" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734601873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2wU49+e7tvLItM+Xg1PJft++Z0Ygv+fKtA0Gny+3OZY=; b=LHGZhG7MgYE3PEjKi1Onxnkrz7xZ1NgPwbvrZUc3GBNrbrLA34FpYZGl+G6RLC0nMd5RNV 64JrJQhiuuGenctoh0sZXs1NfrwrSGoXYGK1KIMgk1YXGQY/Vl/hhHZgwDeh2j8CTg/qKQ X0GjgST5nalSRr9l3PPeG8JwJNjh9dM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-6QXNL-vFOTGv9RKd-dLPjw-1; Thu, 19 Dec 2024 04:51:12 -0500 X-MC-Unique: 6QXNL-vFOTGv9RKd-dLPjw-1 X-Mimecast-MFC-AGG-ID: 6QXNL-vFOTGv9RKd-dLPjw Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-436219070b4so3220345e9.1 for ; Thu, 19 Dec 2024 01:51:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734601871; x=1735206671; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2wU49+e7tvLItM+Xg1PJft++Z0Ygv+fKtA0Gny+3OZY=; b=HT17jrpEvpYbfZXpSrbTco6G84iNhzOOaZXFk+dE2hSKzfnn07QoVtEBDXw0/vweXq nq3OsErNMmM28zoFWX2sJdf+6O6Foh+h9vtIjVkgA3LtY1Xr8Ysv5qt74Ja4Ibq7N4EI QNVsDrWvQpaFEZdUxVKydx3eqVp8J9XGDCfRFQ2CZ/TjLQHQH3HCyzEeg6qId/wiY8ai 9MWeOhA/SLW8ZZ0vh+Z3SPXWaLkAytBCkznGKw4ZocJZ1Ib0rIKSVgIei/wWTsWYEdkC dqtmIez0yg8PpUmreANqDIT9ww69oAaN6/l3GxkdPC75O+isRbPBSB9mTXyMNNIlgGki lEHQ== X-Forwarded-Encrypted: i=1; AJvYcCWYsnzTyfGdN9HdHaVi1eR0+2JCkJP2nxsmzCmmst8okknj7M5MBsx3LsV06yGgmPl10AjXbBfLtxsOtqU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+W2EMSxt6rydocliSOwctmAImEFIURTIDt0gD3JwQ2o0pUPdh FCdWmAVS7LSkA6HQXpbfsPg/EEUWMHbvLaItN019XT2NIOu3AOncPRaEZdN2N8phSyZvc2OwPhi iEtlxNgLvNmU4lv9ayI+LCTwraHe4xSm65odBp9xsn5CAJSy9zx1oJbd2GTC7bQ== X-Gm-Gg: ASbGncv2AHACuGvr7uP4Trj5ZKhQIiTeQRf2wGg3TlI+Vn2RopRp36Bl+p1NyjQzNmI FcFX6yul8b12XrpAAcUQFGgNDFtWWvrSv/WuX0JI3es3jrhnVOzSsCBzCtbwbB9lvyXxTmCYqzx VK6psolprettx9QaqsVOqujh3Fty+1bfmnRyhhOgYD2BwBUNU9Ev8viNfOjtx1q2l2OOKOoe+uE /w05IZ9LYd16hrlgebVud9FxRJOU4lyZJmSxHlDIRUXcJ57A4BGYayjcO9HDym2qb3dAOas5Qiz IEIdF9uFxQ== X-Received: by 2002:a05:600c:4508:b0:434:e2ea:fc94 with SMTP id 5b1f17b1804b1-4365535fe12mr47541185e9.11.1734601871253; Thu, 19 Dec 2024 01:51:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IEiVx3RGR9O17A1hpKQriifFDUtCiFAmeV0v2obPBdwiQMiNihtkWiVxavI2S/flue9uwOtgw== X-Received: by 2002:a05:600c:4508:b0:434:e2ea:fc94 with SMTP id 5b1f17b1804b1-4365535fe12mr47540895e9.11.1734601870840; Thu, 19 Dec 2024 01:51:10 -0800 (PST) Received: from [192.168.88.24] (146-241-54-197.dyn.eolo.it. [146.241.54.197]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656af6c66sm48559835e9.5.2024.12.19.01.51.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2024 01:51:10 -0800 (PST) Message-ID: Date: Thu, 19 Dec 2024 10:51:08 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND V2 net 6/7] net: hns3: fixed hclge_fetch_pf_reg accesses bar space out of bounds issue To: Michal Swiatkowski , Jijie Shao Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, andrew+netdev@lunn.ch, horms@kernel.org, shenjian15@huawei.com, wangpeiyang1@huawei.com, liuyonglong@huawei.com, chenhao418@huawei.com, jonathan.cameron@huawei.com, shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241217010839.1742227-1-shaojijie@huawei.com> <20241217010839.1742227-7-shaojijie@huawei.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/18/24 10:29, Michal Swiatkowski wrote: >> @@ -533,10 +533,11 @@ static int hclge_fetch_pf_reg(struct hclge_dev *hdev, void *data, >> reg_num = ARRAY_SIZE(ring_reg_addr_list); >> for (j = 0; j < kinfo->num_tqps; j++) { > You can define struct hnae3_queue *tqp here to limit the scope > (same in VF case). @Michal, please let me refer to prior feedback from Jakub: https://lore.kernel.org/netdev/20241028163554.7dddff8b@kernel.org/ I also agree subjective stylistic feedback should be avoided unless the style issue is really gross - in such a case the feedback should not be subjective, so the original guidance still applies ;) Thanks, Paolo