Re: [PATCH 1/4] configfs: Delete semicolon from macro type_print() definition

[Zijun Hu <zijun_hu@icloud.com>]

On 2025/4/17 22:38, Breno Leitao wrote:
> Hello Zijun,
> 
> On Tue, Apr 08, 2025 at 09:26:07PM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@quicinc.com>
>>
>> Macro type_print() definition ends with semicolon, so will cause
>> the subsequent macro invocations end with two semicolons.
> 
> where is the type_print() macro invoked today?
> 
> I haven't found any reference for it in fs/configfs/dir.c
> 

both its definition and invocations are within

fs/configfs/dir.c:
static void configfs_dump_one(struct configfs_dirent *sd, int level)
{
        pr_info("%*s\"%s\":\n", level, " ", configfs_get_name(sd));

#define type_print(_type) if (sd->s_type & _type) pr_info("%*s %s\n",
level, " ", #_type);
        type_print(CONFIGFS_ROOT);
        type_print(CONFIGFS_DIR);
        type_print(CONFIGFS_ITEM_ATTR);
        type_print(CONFIGFS_ITEM_LINK);
        type_print(CONFIGFS_USET_DIR);
        type_print(CONFIGFS_USET_DEFAULT);
        type_print(CONFIGFS_USET_DROPPING);
#undef type_print
}

configfs_dump_one() is invoked by

> Thanks
> --breno