From: Gerd Rausch <gerd.rausch@oracle.com>
To: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>
Subject: [PATCH 1/1] RDMA/cma: Fix rdma_resolve_route memory leak
Date: Thu, 24 Jun 2021 11:55:31 -0700 [thread overview]
Message-ID: <f6662b7b-bdb7-2706-1e12-47c61d3474b6@oracle.com> (raw)
Fix a memory leak when "rmda_resolve_route" is called
more than once on the same "rdma_cm_id".
Signed-off-by: Gerd Rausch <gerd.rausch@oracle.com>
---
drivers/infiniband/core/cma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index ab148a696c0c..4a76d5b4163e 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -2819,7 +2819,8 @@ static int cma_resolve_ib_route(struct rdma_id_private *id_priv,
cma_init_resolve_route_work(work, id_priv);
- route->path_rec = kmalloc(sizeof *route->path_rec, GFP_KERNEL);
+ if (!route->path_rec)
+ route->path_rec = kmalloc(sizeof *route->path_rec, GFP_KERNEL);
if (!route->path_rec) {
ret = -ENOMEM;
goto err1;
--
2.24.1
next reply other threads:[~2021-06-24 18:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 18:55 Gerd Rausch [this message]
2021-06-25 5:49 ` Mark Zhang
2021-06-25 8:15 ` Haakon Bugge
2021-06-25 16:27 ` Gerd Rausch
2021-06-25 15:03 ` Jason Gunthorpe
2021-06-25 16:27 ` Gerd Rausch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6662b7b-bdb7-2706-1e12-47c61d3474b6@oracle.com \
--to=gerd.rausch@oracle.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®