From: Mark Brown <broonie@kernel.org>
To: "Jan Kundrát" <jan.kundrat@cesnet.cz>
Cc: Cosmin Tanislav <cosmin.tanislav@analog.com>,
linux-serial@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: max310x: work around regmap->regcache data corruption
Date: Fri, 1 Dec 2023 16:21:42 +0000 [thread overview]
Message-ID: <f66cf0a3-4d63-4548-8648-e93a1ef995e2@sirena.org.uk> (raw)
In-Reply-To: <bd91db46c50615bc1d1d62beb659fa7f62386446.1701446070.git.jan.kundrat@cesnet.cz>
[-- Attachment #1: Type: text/plain, Size: 938 bytes --]
On Fri, Dec 01, 2023 at 03:51:51PM +0100, Jan Kundrát wrote:
> The TL;DR summary is that the regmap_noinc_write spills over the data
> that are correctly written to the HW also to the following registers in
> the regcache. As a result, regcache then contains user-controlled
> garbage which will be used later for bit updates on unrelated registers.
> I was investigating a regression that happened somewhere between 5.12.4
> (plus 14 of our patches) and v6.5.9 (plus 7 of our patches). Our
Can you reproduce this with current kernels? That's not even an up to
date v6.5 - we're up to v6.5.13 now from the looks of things including
one upstream fix that looks potentially relevant. The most direct thing
would be to write a kunit test demonstrating the issue with current
mainline.
If things are already fine with mainline then you'd need to talk to the
stable maintainers about what they've chosen to backport.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-12-01 16:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 14:51 Jan Kundrát
2023-12-01 16:14 ` Andy Shevchenko
2023-12-01 16:23 ` Mark Brown
2023-12-01 16:21 ` Mark Brown [this message]
2023-12-01 17:02 ` Andy Shevchenko
2023-12-02 10:29 ` Jan Kundrát
2023-12-01 18:27 ` Hugo Villeneuve
2023-12-01 18:34 ` Mark Brown
2023-12-01 21:38 ` Hugo Villeneuve
2023-12-01 21:41 ` Mark Brown
2023-12-01 22:16 ` Hugo Villeneuve
2023-12-04 16:29 ` Hugo Villeneuve
2023-12-04 16:35 ` Mark Brown
2023-12-04 17:01 ` Hugo Villeneuve
2023-12-04 17:19 ` Mark Brown
2023-12-04 18:59 ` Hugo Villeneuve
2023-12-04 19:16 ` Mark Brown
2023-12-04 19:41 ` Hugo Villeneuve
2023-12-04 19:48 ` Mark Brown
2023-12-04 20:02 ` Hugo Villeneuve
2023-12-04 22:09 ` Mark Brown
2023-12-05 15:52 ` Hugo Villeneuve
2023-12-05 16:00 ` Mark Brown
2023-12-01 21:40 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f66cf0a3-4d63-4548-8648-e93a1ef995e2@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=cosmin.tanislav@analog.com \
--cc=jan.kundrat@cesnet.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®