From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E74C43217 for ; Mon, 18 Apr 2022 15:56:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346057AbiDRP7d (ORCPT ); Mon, 18 Apr 2022 11:59:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346085AbiDRP70 (ORCPT ); Mon, 18 Apr 2022 11:59:26 -0400 Received: from ale.deltatee.com (ale.deltatee.com [204.191.154.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 267242E7; Mon, 18 Apr 2022 08:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:From:References:Cc:To: MIME-Version:Date:Message-ID:content-disposition; bh=vC0Ih9le+ufoyxFprP99+GQ0JyIb9kJyMO1mXKJWmYQ=; b=O7SWBeNJrTuZVjyru9nyZRnBOe 22lwd7QeTzfHJA2QCmrdsDoma3MD9W/MoeQSd+uvgy6Xr484pvDd0tl3ualGpFtux1LAjYD76p02m 3ntUCfY3URytlDVrXSIKtpKrt9YpYfsAStJh/3L3BJrhZbg7W+hlDyEoHTIfqxPqny6qACytsYxgs daN82zJzOqLoeOvrWU28bzXA3Lk0FlwvhCkbi0UZ0Gf2A6Fbn4b5ZlQ5n2hZu3uLz7TZl/3SZJIix QwKgzC8H1UtmZnhxB+0zciw2LmBLKhbqt7IHcoEWIHDzHusSTRzzVSjgGjYAyPHSc0/pPOvTQ7+ot H9y5yYEA==; Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1ngThm-00Aldv-Sx; Mon, 18 Apr 2022 09:54:25 -0600 Message-ID: Date: Mon, 18 Apr 2022 09:54:22 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-CA To: Yunbo Yu , vkoul@kernel.org Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220418142021.1241558-1-yuyunbo519@gmail.com> From: Logan Gunthorpe In-Reply-To: <20220418142021.1241558-1-yuyunbo519@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: yuyunbo519@gmail.com, vkoul@kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock() X-SA-Exim-Version: 4.2.1 (built Sat, 13 Feb 2021 17:57:42 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-04-18 08:20, Yunbo Yu wrote: > It is unnecessary to call spin_lock_bh() for you are already in a tasklet. > > Signed-off-by: Yunbo Yu Ah, thanks! Reviewed-by: Logan Gunthorpe > --- > drivers/dma/plx_dma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c > index 1ffcb5ca9788..12725fa1655f 100644 > --- a/drivers/dma/plx_dma.c > +++ b/drivers/dma/plx_dma.c > @@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev) > struct plx_dma_desc *desc; > u32 flags; > > - spin_lock_bh(&plxdev->ring_lock); > + spin_lock(&plxdev->ring_lock); > > while (plxdev->tail != plxdev->head) { > desc = plx_dma_get_desc(plxdev, plxdev->tail); > @@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev) > plxdev->tail++; > } > > - spin_unlock_bh(&plxdev->ring_lock); > + spin_unlock(&plxdev->ring_lock); > } > > static void plx_dma_abort_desc(struct plx_dma_dev *plxdev)