From: Sagi Grimberg <sagi@grimberg.me>
To: Ming Lei <tom.leiming@gmail.com>,
Johannes Thumshirn <jthumshirn@suse.de>
Cc: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@fb.com>,
linux-block <linux-block@vger.kernel.org>,
Hannes Reinecke <hare@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] block: respect virtual boundary mask in bvecs
Date: Tue, 6 Nov 2018 19:14:22 -0800 [thread overview]
Message-ID: <f670cdbd-ece6-9051-e6f8-0814a44fe82b@grimberg.me> (raw)
In-Reply-To: <CACVXFVNOAc1HEPmfu9n8vMjqY2hK8fVqe4Em-g+dvSRLavpO8w@mail.gmail.com>
> blktrace won't help on this issue because .bv_offset isn't recorded.
>
> This patch makes sense on >4KB PAGE_SIZE. If your issue happens on
> ARCH with 4K PAGE_SIZE, maybe you should root cause why it makes a
> difference on iSer. And it is highly possible there is bug somewhere.
I don't suspect that this is the case. unless all the vec elements
happen to have an offset but if that is the case I don't think that
this patch would've solved this.
It can't really be an iser issue because iser does not control bio
splitting/merging... it can only ask the block layer to obay the
virt_boundary.
next prev parent reply other threads:[~2018-11-07 3:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 10:23 Johannes Thumshirn
2018-11-05 10:55 ` Ming Lei
2018-11-05 11:50 ` Johannes Thumshirn
2018-11-05 12:01 ` Ming Lei
2018-11-06 12:34 ` Johannes Thumshirn
2018-11-06 14:56 ` Ming Lei
2018-11-06 15:14 ` Keith Busch
2018-11-07 3:14 ` Sagi Grimberg [this message]
2018-11-07 3:11 ` Sagi Grimberg
2018-11-06 14:31 ` Keith Busch
2018-11-06 14:53 ` Bart Van Assche
2018-11-06 14:56 ` Johannes Thumshirn
2018-11-07 3:30 ` Sagi Grimberg
2018-11-07 16:10 ` Bart Van Assche
2018-11-08 15:04 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f670cdbd-ece6-9051-e6f8-0814a44fe82b@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@fb.com \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®