From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E326939E191 for ; Wed, 18 Mar 2026 10:43:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773830624; cv=none; b=Qi6nOBynX4RwWbE74EUzTyeBX8q7KIHvL+o5ai/0Wv3Ceh1C7hcqqugY/rnV48chh0x1nFQT303LldDT5F99kK0XIxum5wGwtxfVl4lR16m/F6j9eZAHvrrnYBot8iEX/5OSK4Wv7ubqTfNevcMv5JfSvBQoxjBtgmX1K8uS6uo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773830624; c=relaxed/simple; bh=oc4D1PESup3IFzdbD0jEbTXo/0kAy+Rh8+zH1oNFcTc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jsN6vh2ShTTEmQ2pVATjmdyCVE2aGasYy8+MQozk8v6zSbnQ+eLsam4pBQK+YHU8EskFfYJG9n3ErKCCWV4WJSVbjORdhPvBq0Hwnw/Emca/w77nS87OYSgWU1D6AJQhcZUfufXtu2mrrHFM405BgtsM0elIzxUGG9ABV0w+Z6Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=xYssy6hV; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=DV7Keg3x; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=xYssy6hV; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=DV7Keg3x; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="xYssy6hV"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="DV7Keg3x"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="xYssy6hV"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="DV7Keg3x" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 53F885BE62; Wed, 18 Mar 2026 10:43:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773830621; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8UJnDC4G6fXouGsf83DgNZb3q00GIR95KOLG391dZDM=; b=xYssy6hVQPkZtmkI8inkgZuolgoig9HYnHVTaAWk5p0/5cKVEFSbalNn3e5HbkbVguYc/C co9stD8lMZyy2cQ079WJI1jKvlpE8B5iOpjMXyT8Jn6MM6Z34wyOMzalYRWUDd11NOL3lO ww9zzBNso7I3rh5xo9Rnev2mUmjbhOo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773830621; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8UJnDC4G6fXouGsf83DgNZb3q00GIR95KOLG391dZDM=; b=DV7Keg3x4jzanUR1z00yrZZuBXcGlBXXl15uPOz1UPkymz/m+6DYTqvD7YghZQ2lR0EX5a ADnYssAFbJk+SGDA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773830621; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8UJnDC4G6fXouGsf83DgNZb3q00GIR95KOLG391dZDM=; b=xYssy6hVQPkZtmkI8inkgZuolgoig9HYnHVTaAWk5p0/5cKVEFSbalNn3e5HbkbVguYc/C co9stD8lMZyy2cQ079WJI1jKvlpE8B5iOpjMXyT8Jn6MM6Z34wyOMzalYRWUDd11NOL3lO ww9zzBNso7I3rh5xo9Rnev2mUmjbhOo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773830621; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8UJnDC4G6fXouGsf83DgNZb3q00GIR95KOLG391dZDM=; b=DV7Keg3x4jzanUR1z00yrZZuBXcGlBXXl15uPOz1UPkymz/m+6DYTqvD7YghZQ2lR0EX5a ADnYssAFbJk+SGDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BEBCF4273B; Wed, 18 Mar 2026 10:43:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ap+aK9yBumn/dwAAD6G6ig (envelope-from ); Wed, 18 Mar 2026 10:43:40 +0000 Message-ID: Date: Wed, 18 Mar 2026 11:43:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/10 net-next v3] ipv6: prepare headers for ipv6_stub removal To: Ido Schimmel Cc: netdev@vger.kernel.org, =?UTF-8?Q?Ricardo_B=2E_Marli=C3=A8re?= , "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org References: <20260317140141.5723-1-fmancera@suse.de> <20260317140141.5723-5-fmancera@suse.de> <20260317201236.GA3581148@shredder> Content-Language: en-US From: Fernando Fernandez Mancera In-Reply-To: <20260317201236.GA3581148@shredder> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_SEVEN(0.00)[10]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-Spam-Flag: NO X-Spam-Score: -4.30 X-Spam-Level: On 3/17/26 9:12 PM, Ido Schimmel wrote: > On Tue, Mar 17, 2026 at 03:01:00PM +0100, Fernando Fernandez Mancera wrote: >> diff --git a/include/net/ndisc.h b/include/net/ndisc.h >> index d38783a2ce57..6152401f29f1 100644 >> --- a/include/net/ndisc.h >> +++ b/include/net/ndisc.h >> @@ -69,6 +69,12 @@ struct prefix_info; >> >> extern struct neigh_table nd_tbl; >> >> +#if IS_ENABLED(CONFIG_IPV6) >> +#define ipv6_get_nd_tbl() (&nd_tbl) >> +#else >> +#define ipv6_get_nd_tbl() NULL >> +#endif > > What is the reason for converting code that is dependent on CONFIG_IPV6 > to use ipv6_get_nd_tbl()? I did it mainly for consistency. If you think this isn't fine, I can move it back to &nd_tbl directly. Thanks, Fernando.