From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89DC73D9DC5 for ; Wed, 17 Jun 2026 10:12:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781691163; cv=none; b=lIvFMXaNnaZ6hpTyJAlOhKNwMceQDsea63C+nQeTNHzzDYSnfQaOuDmmT4IUfGEGOV4JUQX3UufUP2RIzOz/jGfFhXyKsSIfISePU1jCHBh7gHNSQGi7+XipKwLndfxOJgkx6OEI+uWF579Claj/C31nyba89YRsPa/hKCB/NCo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781691163; c=relaxed/simple; bh=BysS5DE5SQ4JcGg29SHsYYeFCMkJUMHJLEJ7VMQuFyo=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=pH2kSM6Lik+TFTK2RnczNTIESwBWg9GL9wqf+njg7Cx+SlgwZ8vFZGQmQCASMb2xZhkT8jzv8QMk2MBvlFWyNSQ0V5sK/Zx5cVy4gn5+/koCWmLdwb+IjVQuBscZ76+3wmb/A6xsY7TfYm2JDLzx8Bu7lbQi1prSpWsUIdR9KtE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bY2BrTHA; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bY2BrTHA" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-45ef779c1c2so4172888f8f.1 for ; Wed, 17 Jun 2026 03:12:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781691159; x=1782295959; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=ct0Hy4xHFL/4fAYc8KtuCQL880liqSZIqsPpgmzHFEE=; b=bY2BrTHAT6PENzKO77Uc8DB7ycJFYBkGLP71QXWK3rYFpC54ZORDEIksB1SWJlr3n3 LJiKauZ1d405izYMetCn/qoA7NKypsRtf94d0ANili6Ryd4TaMGMdQQYJCq0RbrHaNmo ABuedFZLA0iaUAHKVbRGmkfYuoUBcD9DerjoWr3P6cJ78qqjHXeq9kwB1bJyI91ycQrG xbEoQv2ZymO6hKWNt5BP3JpO4RGU/2fFLMDitz1PZkzM92BOno9ByBPhtikJKQjS7ThG fUi27gjLxFh3SqXeh+kOolTt5t6cMLrxXQzQbR3Qn3ouv/S/4WpMpi6NUJK9zCLt8gwO B6tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781691159; x=1782295959; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ct0Hy4xHFL/4fAYc8KtuCQL880liqSZIqsPpgmzHFEE=; b=hwMDH4/9NpWDnBRVFRAXXU15yvVFYFHFNYWHLEzJplnXlsGtZe9p6cqwLpIBLddrZK 95oOwXfTkrlVTOU6Y2BSR0dD+cqw75CEQOq/QOxfxIUnx75nyR6Hq8BZRxGVuvQgt50m Wj7siFZAMU4xfDdvWsAAxIP7d3CVgMuAugENUea7uKe14+LXFz1x0bM8c+pxRsnte0h8 uaYlNNi2sPAXuc/+oDxGzTHAFIUTlC8cFt/btB9zYdpC4It5pA2c9whdANcNsIRh63Sa EY3AAhtM4zF0JRU5MWsn6NWGz3MzxH6b4OoqmFYFbq5+vadpZqJCA/ObhEjyuBuTRpLF VgJg== X-Forwarded-Encrypted: i=1; AFNElJ+MJZukPD8F3yBMf/keTm2MLVRAvIDiaRZ5aoAXEFfXVrQgNf73cQWoGlpiPcL/BT7DE3fHvnJ2q3pkP9M=@vger.kernel.org X-Gm-Message-State: AOJu0YyCBFLAd+qqDunOIMqq27/mE16E9he2xy+a0ZjvBL8ssgs8ZEfP nEP5EH3UTsZn3uwuK1cIZ5vPEaEsH5HrWc0l9lisOgLC7QTtylPaK97X4XYri0iKJTGRrqrQw1T wYxfh X-Gm-Gg: AfdE7clic8DebWFLFYLhRpulaGEfy2X9MaFoc2vJj7rM8+p62ydH9IpQs7SUBaFzSpA 1kAhVJeU3mTc/d6/Rg5ApxSIsnlSP9WjJeue85v1ZfK3Gei/EhxUdm0ka9IfsE/NkmyCwzlM/8o 717OnIXtfpV/wV64xzqzGuQMLDaYvgljN3CcQXlZADcdm4ef97d3A9nsrPutWQ2k6iLPOXZjNGp MG7Z9upIu3wT1PoRSTMwAELh6CSvbL3viB5/R4R8JKl/gY6T9Oz779GhTzS6aJnuFS8e/J6wAWC qeknjFVtfdXBqhyPKsHbghIq6wfxPj1Z0beaH1a+hzwVvmiYQPj6h1P0L+mjHfDx2GTErWahCfo xtA3SyFs6KVz8dU9AoZbf/uGQ0dUG0Ebif/W7ZbSNeApK4O0MGhBzT96OCIfSFrMwsJoQpNi+b8 BjIMPLwAefG04s6eqYe6LZfA== X-Received: by 2002:adf:fcca:0:b0:45e:f302:95b with SMTP id ffacd0b85a97d-46238f972damr3707279f8f.37.1781691158602; Wed, 17 Jun 2026 03:12:38 -0700 (PDT) Received: from [10.12.4.106] ([212.133.41.97]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f2cf5d9sm46101981f8f.32.2026.06.17.03.12.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2026 03:12:38 -0700 (PDT) Message-ID: Date: Wed, 17 Jun 2026 12:12:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 1/3] arm64: dts: qcom: Add header file for ADC5 Gen3 channel macros To: Konrad Dybcio , Jishnu Prakash , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ayyagari Ushasreevalli , Kamal Wadhwa References: <20260430-adc5_gen3_dt-v1-0-ab2bb40fd490@oss.qualcomm.com> <20260430-adc5_gen3_dt-v1-1-ab2bb40fd490@oss.qualcomm.com> <60170148-2fef-4282-ad68-f784e4fdfe23@oss.qualcomm.com> <831ed020-4a1f-46af-95c6-38ef1f875fd1@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/15/26 18:48, Konrad Dybcio wrote: > On 6/15/26 6:39 PM, Neil Armstrong wrote: >> Hi, >> >> On 6/15/26 17:55, Konrad Dybcio wrote: >>> On 4/30/26 10:58 AM, Jishnu Prakash wrote: >>>> Add macro definitions for virtual channels (combination of ADC channel >>>> number and PMIC SID number), to be used in devicetree by clients of ADC5 >>>> GEN3 device and in the "reg" property of ADC channels. >>>> >>>> Signed-off-by: Jishnu Prakash >>>> --- >>> >>> Reviewed-by: Konrad Dybcio >> >> And what happens with my patch [1] ? >> >> I had zero feedback so far >> >> [1] https://lore.kernel.org/all/20260504-topic-sm8x50-adc5-gen3-v2-1-5cc04d6ecda0@linaro.org/ > > I think this approach (single generic header) is better. The existing > ADC7 bindings which your series draws inspiration from come with a ton > of boilerplate. > > There are some non-trivial mappings in there though, e.g.: > > +#define PM8550B_ADC5_GEN3_AMUX4_GPIO12_100K_PU(sid) ((sid) << 8 | ADC5_GEN3_AMUX4_GPIO_100K_PU) > > but these would presumably be deducible from downstream I'll try to rebase on this patch, seems all the values are defined, I just need to match the old and new defines Neil > > Konrad