From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14495C433DF for ; Thu, 25 Jun 2020 16:46:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E24A820823 for ; Thu, 25 Jun 2020 16:46:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=marvell.com header.i=@marvell.com header.b="ZO2aUhxB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390975AbgFYQqi (ORCPT ); Thu, 25 Jun 2020 12:46:38 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:48870 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2390448AbgFYQqe (ORCPT ); Thu, 25 Jun 2020 12:46:34 -0400 Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05PGexTv007953; Thu, 25 Jun 2020 09:46:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pfpt0818; bh=PMskP27+of0ifwdKo+hHxFTCm0HJN0Am7pIewJiyYx8=; b=ZO2aUhxBDtLA4Z15aYe/UZJVtWr4ZFe8kF2J/QqbpPVxxpzg1k5oXPJQLdlDdSlCQFmS hr4s8lQW4BDLGUtf3MHix3ByqZfOvLIey/y76Z6tNuBI23L1HcbXmJEm+qsXvAV7nTO5 ao01B4uxNE8fP5mqj8ASPY+ADgNdJiZ3AFAqWE/1V3t3RPNtm+g/EnxEzp0niY+kPKz+ yts2fknu+0k4VG0T/K6IaTouyUnz9NbL2GzIL/u9UzxlRGZYQ5MZ9StmHxH829KKZxp6 1V2ruqoDTqzw98NWSiIOLqD1690JjBz7kRthm34Cv5SKYAcu55uhonRj+187AJJLpGa0 TQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 31uuqh0mqk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 25 Jun 2020 09:46:29 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 25 Jun 2020 09:46:27 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 25 Jun 2020 09:46:27 -0700 Received: from [10.193.39.5] (unknown [10.193.39.5]) by maili.marvell.com (Postfix) with ESMTP id 969AB3F7040; Thu, 25 Jun 2020 09:46:22 -0700 (PDT) Subject: Re: [EXT] [PATCH v1] bnx2x: use generic power management To: Vaibhav Gupta , Bjorn Helgaas , Bjorn Helgaas , , Vaibhav Gupta , "David S. Miller" , Jakub Kicinski , Ariel Elior , Sudarsana Reddy Kalluru , GR-everest-linux-l2 CC: , , , References: <20200624175116.67911-1-vaibhavgupta40@gmail.com> From: Igor Russkikh Message-ID: Date: Thu, 25 Jun 2020 19:46:21 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.0 MIME-Version: 1.0 In-Reply-To: <20200624175116.67911-1-vaibhavgupta40@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-25_11:2020-06-25,2020-06-25 signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/06/2020 8:51 pm, Vaibhav Gupta wrote: > External Email > > ---------------------------------------------------------------------- > With legacy PM, drivers themselves were responsible for managing the > device's power states and takes care of register states. > > After upgrading to the generic structure, PCI core will take care of > required tasks and drivers should do only device-specific operations. > > The driver was also calling bnx2x_set_power_state() to set the power state > of the device by changing the device's registers' value. It is no more > needed. > > Compile-tested only. > > Signed-off-by: Vaibhav Gupta > --- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 15 ++++++--------- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 4 +--- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 3 +-- > 3 files changed, 8 insertions(+), 14 deletions(-) Acked-by: Igor Russkikh Sudarsana, could you please give it a short sanity test and report back? Thanks, Igor