From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932313AbdJWN5w (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Oct 2017 09:57:52 -0400
Received: from mout.web.de ([212.227.15.14]:65392 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932191AbdJWN5u (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Oct 2017 09:57:50 -0400
Subject: Re: [PATCH 1/2] xen-tpmfront: Use common error handling code in
 vtpm_send()
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        linux-integrity@vger.kernel.org
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        =?UTF-8?Q?Peter_H=c3=bcwe?= <PeterHuewe@gmx.de>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <cf592c7d-8fbc-833b-fa1a-ff9e91c3734c@users.sourceforge.net>
 <9cfcbfd0-75c3-4de5-f735-0ace23d2abcb@users.sourceforge.net>
 <20171023134257.txnpbg5c5z7uaquf@linux.intel.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <f68ee5b6-2da1-e3c8-4d0d-f13a0563385e@users.sourceforge.net>
Date: Mon, 23 Oct 2017 15:57:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171023134257.txnpbg5c5z7uaquf@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:t5lmWPxVBJjB+Vs8TT8OWFs1YPeS2jZZk8OO9FhyPb+KCwWbp+y
 bWXjhfWm2ZIhlFv4aoWLj5zzIgJNsai4OgIkU7IKL2Z15SryKigV1ef5GfjSSAIqfubngyT
 z1Tn6etzV4o3DigmT6wOk1mMEe7IySrpqDtJF6YFZjw12A0XuM8UuBfCrzUMRjWKWijqp4u
 D1o9G63qfQnKNJO3ArrGg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:UXNIzLtNkDM=:/gBp/fQK6kiX+lQyu2HK1I
 4RTudl7IkHPFzLNAqWiFesjE7BoH3QEEIC/LdopwpfCc7ZoPGEbl/GQb7nEGb/gAz9foNChEB
 i0xt2Rwn2byCQwjddekvCdQJuJqXfJzF0odTFpGYaTilIjJIiDO8NfM69kTYpcajizZdp2T8X
 4VjE6s4rcVNykxvFVZOOwPtyBgUh2Mm9l7swmTbB2MmhQt4YXd4fiSSZiSvrfny8sFppUvc+e
 McomRLC0vq09QOj0tw2yVY32C+zJu8cGMLlOxHFmrcTviD0CA4wMXVn6ZNbfTtb/1oHXZt+Ev
 9hOluVwu9ee86LLCYCPvzp8zVoW2Vn03NNIHFeTxNIHK4+YuazFub+RagSjYkzN7h0OiJZUTL
 /hxxDNpHjXIBd04X0LpUPaS+LFuSd17UddsQZpP5YJInVPX/cAs85dxyfE/PKgn5EXvj2oBHS
 i7KETrlti19YabTn5UsM9YKZagv5WcXsWcluCzyUQYa+30XCnK50WbDLf4lOUIMFYW2HGvQ+s
 uERhL0IsJjpOkeXOun/bNnK09iRhi+eN/e3BD6Ti4ao4Njbqk8h16qeuam1b4TEHl0lrGC2Bv
 RqTh0KicUAsbMx7sCs0KRjySBXY3z69p6zbUkSYOjcmMjPmQBR2Vk9Nk4gHrOJ7grf7SCdySx
 UmhCckhfg/0xzFEo+jiGUy9CFMGD1D6QxGiEUdbdsWSGVC5ANDLnrQtsls/WVigBrX10SKLkS
 v+I8JagDHidSLuHtpXQe/936TV2Wo1RAXtstsZMbhSFNuxMDWlFqFgccXDuYaKBCOoyGC9B0j
 K0nObQHPUNXFdGrCJpScu21pD0aa2Sy23jo1c33/tgCoLwrdoY=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -108,11 +106,14 @@ static int vtpm_send(struct tpm_chip *chip, u8 *buf, size_t count)
>>  	if (wait_for_tpm_stat(chip, VTPM_STATUS_IDLE, duration,
>>  			&priv->read_queue, true) < 0) {
>>  		/* got a signal or timeout, try to cancel */
>> -		vtpm_cancel(chip);
>> -		return -ETIME;
>> +		goto cancel_vtpm;
>>  	}
>>  
>>  	return count;
>> +
>> +cancel_vtpm:
>> +	vtpm_cancel(chip);
>> +	return -ETIME;
>>  }
>>  
>>  static int vtpm_recv(struct tpm_chip *chip, u8 *buf, size_t count)
>> -- 
>> 2.14.2
>>
> 
> NAK

Do you need any more facts to show the influence of the proposed small code reduction?

Regards,
Markus