From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68910302140 for ; Fri, 28 Nov 2025 10:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764326369; cv=none; b=m57jfOeWnHBTQetg3Eg0HItK8uvCuWNIa6Wlj1EKwrtmjaTAk0C+IeBvKofW23J510i0mSMnL+RgmaP44zDb2IrSofd/59d3ZbtdfGGJnjCxi7xycxu3MXsHR/nmn6QQPZ9Wsz3tV1ncKrlpiWV+9xRbyEzeC4e0ztu2iGItU8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764326369; c=relaxed/simple; bh=iWj8WWGLS0E0LMdbrAzqDikWo91/mlcN7knxFbRn0vw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=EqJMn0UOl2Dhb8q3gkvH3E4NXVLeokYfLKRYO47FdOug0p5pfxVINcubcqc4rPJlS4eHE67eY80bhRxFruHxmIfVtYHK1sDUQ61k7e1+au4NGnT9tXX2Uup8KJYpzegYvPtKOpVw6hul2yuJ7SM7G6kuh/fAwuzFFKwRYGEVgIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPv6:::1]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vOvsS-0007ne-EQ; Fri, 28 Nov 2025 11:39:00 +0100 Message-ID: Subject: Re: [PATCH v2 1/2] pmdomain: imx8m-blk-ctrl: Remove separate rst and clk mask for 8mq vpu From: Lucas Stach To: ming.qian@oss.nxp.com, linux-media@vger.kernel.org Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, nicolas@ndufresne.ca, benjamin.gaignard@collabora.com, p.zabel@pengutronix.de, sebastian.fricke@collabora.com, shawnguo@kernel.org, ulf.hansson@linaro.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, Frank.li@nxp.com, peng.fan@nxp.com, eagle.zhou@nxp.com, imx@lists.linux.dev, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Fri, 28 Nov 2025 11:38:57 +0100 In-Reply-To: <20251128025117.535-1-ming.qian@oss.nxp.com> References: <20251128025117.535-1-ming.qian@oss.nxp.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-2.fc40) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Am Freitag, dem 28.11.2025 um 10:51 +0800 schrieb ming.qian@oss.nxp.com: > From: Ming Qian >=20 > For i.MX8MQ platform, the ADB in the VPUMIX domain has no separate reset > and clock enable bits, but is ungated and reset together with the VPUs. > So we can't reset G1 or G2 separately, it may led to the system hang. > Remove rst_mask and clk_mask of imx8mq_vpu_blk_ctl_domain_data. > Let imx8mq_vpu_power_notifier() do really vpu reset. >=20 > Fixes: 608d7c325e85 ("soc: imx: imx8m-blk-ctrl: add i.MX8MQ VPU blk-ctrl"= ) > Signed-off-by: Ming Qian > Reviewed-by: Benjamin Gaignard > --- > v2 > - Update commit message >=20 > drivers/pmdomain/imx/imx8m-blk-ctrl.c | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/drivers/pmdomain/imx/imx8m-blk-ctrl.c b/drivers/pmdomain/imx= /imx8m-blk-ctrl.c > index 5c83e5599f1e..1f07ff041295 100644 > --- a/drivers/pmdomain/imx/imx8m-blk-ctrl.c > +++ b/drivers/pmdomain/imx/imx8m-blk-ctrl.c > @@ -852,16 +852,12 @@ static const struct imx8m_blk_ctrl_domain_data imx8= mq_vpu_blk_ctl_domain_data[] > .clk_names =3D (const char *[]){ "g1", }, > .num_clks =3D 1, > .gpc_name =3D "g1", > - .rst_mask =3D BIT(1), > - .clk_mask =3D BIT(1), Change itself looks okay to me. Can you please leave a small comment here and for the G2 domain to document why the clk and reset bits are removed, so one doesn't need to dig into the git history when reading the driver code? Regards, Lucas > }, > [IMX8MQ_VPUBLK_PD_G2] =3D { > .name =3D "vpublk-g2", > .clk_names =3D (const char *[]){ "g2", }, > .num_clks =3D 1, > .gpc_name =3D "g2", > - .rst_mask =3D BIT(0), > - .clk_mask =3D BIT(0), > }, > }; > =20