From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752065AbdJSKaC (ORCPT ); Thu, 19 Oct 2017 06:30:02 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:8993 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbdJSKaB (ORCPT ); Thu, 19 Oct 2017 06:30:01 -0400 Subject: Re: [PATCH] perf vendor events arm64: Add hip08 implementation defined PMU core events To: Ganapatrao Kulkarni References: <1508223699-39274-1-git-send-email-zhangshaokun@hisilicon.com> <20171017125926.GE14051@arm.com> <20171018104910.GB11669@arm.com> <49db001c-14c5-74ea-0d60-ccd5d46b0bfe@huawei.com> CC: Will Deacon , Shaokun Zhang , Ganapatrao Kulkarni , , Linuxarm , , Peter Zijlstra , Ingo Molnar , "Arnaldo Carvalho de Melo" , Alexander Shishkin From: John Garry Message-ID: Date: Thu, 19 Oct 2017 11:29:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.238] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.59E87E9E.00DB,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 66ea512de0b1972fc23cf1bcbf70d51e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> >> #Family-model,Version,Filename,EventType >> 0x00000000420f5160,v1,cavium,core >> 0x00000000420f5161,v1,cavium,core > > certainly, there is Part number(PartNum, bits [15:4] ) change from > thunderx2 to thunderx3. > thunderx3 should have its own json file describing all its supported events. > same applies to other SoCs as well. > > IIUC, the idea of ignoring Revision and Variants is that, the PMU > design/version wont change across Revisions and Variants. > Hi Ganapatrao, Right, I should have modified the part num for my illustration, but I am still concerned. Please see my example in the other mail and check what I am missing. Thanks, John