mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Kepplinger <martin.kepplinger@puri.sm>
To: Shawn Guo <shawnguo@kernel.org>
Cc: robh@kernel.org, festevam@gmail.com, kernel@pengutronix.de,
	linux-imx@nxp.com, krzk@kernel.org, kernel@puri.sm,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description
Date: Mon, 11 Jan 2021 09:24:44 +0100	[thread overview]
Message-ID: <f699bf19-c5df-c2da-af23-ef144cec4750@puri.sm> (raw)
In-Reply-To: <20210111002942.GR28365@dragon>

On 11.01.21 01:29, Shawn Guo wrote:
> On Tue, Dec 22, 2020 at 04:13:45PM +0100, Martin Kepplinger wrote:
>> In order for the touchscreen interrupt line to work, describe it properly.
>> Otherwise it can work if defaults are ok, but we cannot be sure.
>>
>> Fixes: 8f0216b006e5 ("arm64: dts: Add a device tree for the Librem 5 phone")
>> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> index 55268fc0622e..a60df09d90f7 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
>> @@ -459,6 +459,13 @@
>>   		>;
>>   	};
>>   
>> +	pinctrl_touch: touchgrp {
>> +		fsl,pins = <
>> +		/* TP_INT */
>> +		MX8MQ_IOMUXC_ENET_RD1_GPIO1_IO27	0x80
> 
> Miss indentation for these two lines.
> 
> I fixed it up and applied the series.
> 
> Shawn
> 

thanks for this!

                             martin

  reply	other threads:[~2021-01-11  8:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-22 15:13 [PATCH v2 0/4] small Librem 5 phone dts updates Martin Kepplinger
2020-12-22 15:13 ` [PATCH v2 1/4] arm64: dts: imx8mq-librem5: add vin-supply to VDD_1V8 Martin Kepplinger
2020-12-22 15:13 ` [PATCH v2 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description Martin Kepplinger
2020-12-23  9:58   ` Krzysztof Kozlowski
2021-01-11  0:29   ` Shawn Guo
2021-01-11  8:24     ` Martin Kepplinger [this message]
2020-12-22 15:13 ` [PATCH v2 3/4] arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT Martin Kepplinger
2020-12-23  9:58   ` Krzysztof Kozlowski
2020-12-22 15:13 ` [PATCH v2 4/4] arm64: dts: imx8mq-librem5-r3: workaround i2c1 issue with 1GHz cpu voltage Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f699bf19-c5df-c2da-af23-ef144cec4750@puri.sm \
    --to=martin.kepplinger@puri.sm \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®