From: Marc Zyngier <marc.zyngier@arm.com>
To: Mark Salyzyn <salyzyn@android.com>, linux-kernel@vger.kernel.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Christoffer Dall <cdall@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Stefan Traby <stefan@hello-penguin.com>,
Dave Martin <Dave.Martin@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: write_sysreg asm illegal for aarch32
Date: Thu, 2 Nov 2017 10:05:35 +0000 [thread overview]
Message-ID: <f69cfc20-60e1-6c5c-5baf-7c7ae5b58ab1@arm.com> (raw)
In-Reply-To: <20171101170014.20931-1-salyzyn@android.com>
On 01/11/17 16:58, Mark Salyzyn wrote:
> Cross compiling to aarch32 (for vdso32) using clang correctly
> identifies that (the unused) write_sysreg inline asm directive is
> illegal in that architectural context:
>
> arch/arm64/include/asm/arch_timer.h: error: invalid input constraint 'rZ' in asm
> write_sysreg(cntkctl, cntkctl_el1);
> ^
> arch/arm64/include/asm/sysreg.h: note: expanded from macro 'write_sysreg'
> : : "rZ" (__val));
> ^
>
> GCC normally checks for correctness everywhere. But uniquely for
> unused asm, will optimize out and suppress the error report.
-ENOTABUG.
Please fix the build system instead (why on Earth are you using arm64
headers for an Aarch32 binary?), and don't introduce stuff that is
making understanding the kernel more difficult to understand and maintain.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
prev parent reply other threads:[~2017-11-02 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 16:58 Mark Salyzyn
2017-11-01 17:14 ` Robin Murphy
2017-11-01 17:49 ` Mark Salyzyn
2017-11-01 17:56 ` Mark Rutland
2017-11-01 18:16 ` Mark Salyzyn
2017-11-01 20:32 ` Mark Salyzyn
2017-11-02 10:08 ` Mark Rutland
2017-11-02 10:05 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f69cfc20-60e1-6c5c-5baf-7c7ae5b58ab1@arm.com \
--to=marc.zyngier@arm.com \
--cc=Dave.Martin@arm.com \
--cc=catalin.marinas@arm.com \
--cc=cdall@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=salyzyn@android.com \
--cc=stefan@hello-penguin.com \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®