From: "Allen-KH Cheng (程冠勳)" <Allen-KH.Cheng@mediatek.com>
To: "nfraprado@collabora.com" <nfraprado@collabora.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v4 4/7] arm64: dts: mediatek: mt8516: Fix the watchdog node name
Date: Mon, 7 Nov 2022 01:39:51 +0000 [thread overview]
Message-ID: <f6aa2fe039226d3fc94d92df5e1913515e0e564e.camel@mediatek.com> (raw)
In-Reply-To: <20221104143219.aiwfezso7r72yg7q@notapiano>
Hi Nícolas,
On Fri, 2022-11-04 at 10:32 -0400, Nícolas F. R. A. Prado wrote:
> On Fri, Nov 04, 2022 at 10:06:58AM +0800, Allen-KH Cheng wrote:
> > The proper name is 'watchdog', not 'toprgu'.
> >
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@collabora.com>
> > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8516.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> > index d1b67c82d761..fff59dc1b4d7 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> > @@ -202,7 +202,7 @@
> > #clock-cells = <1>;
> > };
> >
> > - toprgu: toprgu@10007000 {
> > + toprgu: watchdog@10007000 {
>
> I think you missed my comment about renaming the label as well on the
> previous
> version.
>
Yep, I may have misunderstood.
I will remove the label.
Thanks,
Allen
> > compatible = "mediatek,mt8516-wdt",
> > "mediatek,mt6589-wdt";
> > reg = <0 0x10007000 0 0x1000>;
> > --
> > 2.18.0
> >
next prev parent reply other threads:[~2022-11-07 1:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 2:06 [PATCH v4 0/7] MediaTek watchdog: Convert mtk-wdt.txt to dt-schema Allen-KH Cheng
2022-11-04 2:06 ` [PATCH v4 1/7] arm64: dts: mediatek: mt8186: Fix watchdog compatible Allen-KH Cheng
2022-11-04 2:06 ` [PATCH v4 2/7] arm64: dts: mediatek: mt8195: " Allen-KH Cheng
2022-11-04 2:06 ` [PATCH v4 3/7] arm64: dts: mediatek: mt7986: " Allen-KH Cheng
2022-11-04 2:06 ` [PATCH v4 4/7] arm64: dts: mediatek: mt8516: Fix the watchdog node name Allen-KH Cheng
2022-11-04 14:32 ` Nícolas F. R. A. Prado
2022-11-07 1:39 ` Allen-KH Cheng (程冠勳) [this message]
2022-11-04 2:06 ` [PATCH v4 5/7] dt-bindings: watchdog: mediatek: Convert mtk-wdt to json-schema Allen-KH Cheng
2022-11-04 2:07 ` [PATCH v4 6/7] dt-bindings: watchdog: mediatek,mtk-wdt: Add compatible for MT6795 Allen-KH Cheng
2022-11-04 2:07 ` [PATCH v4 7/7] dt-bindings: watchdog: mediatek,mtk-wdt: Add compatible for MT8173 Allen-KH Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6aa2fe039226d3fc94d92df5e1913515e0e564e.camel@mediatek.com \
--to=allen-kh.cheng@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®