From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B03A7C624B4 for ; Thu, 23 Nov 2023 10:41:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344740AbjKWKky (ORCPT ); Thu, 23 Nov 2023 05:40:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229609AbjKWKkv (ORCPT ); Thu, 23 Nov 2023 05:40:51 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C662419D for ; Thu, 23 Nov 2023 02:40:57 -0800 (PST) Received: from [100.107.97.3] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id D29CA6607393; Thu, 23 Nov 2023 10:40:55 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1700736056; bh=BDmKas5cPwR4Yq39roh28T7ujEshS9pIFSvpdiu1j5A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=j8/i6cTGs40hZw1mUC6nyZCcUjNs3TZ8Z1yVp26kZkXkl2lvysTR+sLdXnJo2UBsE OFFnOuzSV3fSZR5SxMw1kvQ2k+cHOFhf4uml5dC6O8dCmgfhF4SuVk+BwheotRJeLu vgzeB9V9TjrkRzklzLEILcsP7Ci/yRf9PZjtBGhAZPUiZsiccc8F65BrQVdhr1iRez 52NwPNBAqzmye4yvprokvYgmMHog4g8sk00N7UYXnGCHdPj/V6HpOdDN2zMpmUttTt kpRDRzPjy/91qrnre3n8yG3ddckf7TJX/VWT29QhnL2zEZMbZwUUOVndafkb6Mx7HZ oC9XZ5IYMqVeA== Message-ID: Date: Thu, 23 Nov 2023 11:40:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/panfrost: Ignore core_mask for poweroff and sync interrupts Content-Language: en-US To: Krzysztof Kozlowski , steven.price@arm.com Cc: boris.brezillon@collabora.com, robh@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20231123095320.41433-1-angelogioacchino.delregno@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 23/11/23 11:39, Krzysztof Kozlowski ha scritto: > On 23/11/2023 10:53, AngeloGioacchino Del Regno wrote: >> Some SoCs may be equipped with a GPU containing two core groups >> and this is exactly the case of Samsung's Exynos 5422 featuring >> an ARM Mali-T628 MP6 GPU: the support for this GPU in Panfrost >> is partial, as this driver currently supports using only one >> core group and that's reflected on all parts of it, including >> the power on (and power off, previously to this patch) function. >> >> The issue with this is that even though executing the soft reset >> operation should power off all cores unconditionally, on at least >> one platform we're seeing a crash that seems to be happening due >> to an interrupt firing which may be because we are calling power >> transition only on the first core group, leaving the second one >> unchanged, or because ISR execution was pending before entering >> the panfrost_gpu_power_off() function and executed after powering >> off the GPU cores, or all of the above. > > Does not apply - I tried next 20231117/21/22/23. > Sorry about that, I'll send a v2 soon. Thanks, Angelo > Best regards, > Krzysztof > > _______________________________________________ > Kernel mailing list -- kernel@mailman.collabora.com > To unsubscribe send an email to kernel-leave@mailman.collabora.com