From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011036.outbound.protection.outlook.com [40.107.208.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F11853B6364 for ; Fri, 10 Jul 2026 06:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.36 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783666373; cv=fail; b=LHBeESAZaK73d4rAyh3WaTdHH9Jr4BwPvVoy2kJg9RwBT7O5filtkQfhYMPRyWsGxDx7VL8ZNn/0VyvVF3Cnlzpje3mwJ8qSTYhkZh6aBlC0wRpnY/QerDZuzgEZDwBZ3Pe+3U44beFPUjhxWsTkBV8eux19qQtw8s7YVy+onSE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783666373; c=relaxed/simple; bh=Ks/DsEwoLvSrJFqjM8hPzH0fKJiXfK8AcAABo17kW8c=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Hm3WwgflFjkODVXaD2Jm6RoiP8K4/MEOc6WAe/94+V3FbuC3f1bg5i0jVLNhx+iE9aXDe6qirtOWvMOCPegCzG9/DSHhjt10FoJkG29Bk74NhWPL7BwzliLwKMeRvTno+PrLDIeipND7jigmXzsdmv0FN1bVyqgURtArIhUZHjY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=fAgUw5UC; arc=fail smtp.client-ip=40.107.208.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="fAgUw5UC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CpnfzTdkz5byiNnFXGXAhjoEk+uQxgEvsQ1DPnks9l7+9JqVfPX6hsEwCiilHV+BJZNblz+KuG80osVH43szYGcQhzYOb6xpl4HLRLzvK4JNGeMYBS3WE+Css5hlhzXRrFRTfIrtuz4H+kHbk3U0GOMzqYl9/oM6XpysdqHDzrLCQbAdHugpS8UYdz4QKXRNjoP5zysQio6s2Pv3VpTxqIuF9AL9tqvDIUbEBFQ7cWKy8bX56FQCfQvUiESO9hhMUsiQF+x95WfGV91s2Ns8p9a7GgFNYzdrXlGbLfZTp9DUpoHiitwErb4iXAIa/7hH68+CNtYdIxS/JCZprn0dpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=73biOhPPtRJscJhf/V5qs6h3v8kCkdYLxHPVA+j7HM4=; b=kvYmFO4jiyrU/jMoCjFsgFnsAkgZ5zBImXUBh8JmjDqQtgsk99eNClqfV9GdjhWpuEq8SuhidYOAUv+WJ4fUb40YY+f+noCvXw3ALghh4uAKxyBHIw4H71PB4iZcqrUCIH5fqchVABCmIRdttQ/n7S8KHN4defstbXYR3NCETvAkvf2hSm859AhB0BG6Rht54unxvgip63IhlACdlno+beMF7VenW6syD+Fj9olDd429UdX9A2A4kGOMThhuUTX6hAFRVTWTNj0Kzq+//V7qhc0ZPIVC5y8Ld74eneNkN5yLMUN6kghZQ6kDOqQCeazKGE2/0qXajQPVrUgzvw382w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=73biOhPPtRJscJhf/V5qs6h3v8kCkdYLxHPVA+j7HM4=; b=fAgUw5UCOhjhCuGxrC/fU7cD8TDdKNogsw2tPLDPhYmY4hChYFp4o8ojmdfL/PfxCeo+on9JFcASTZtsaTtqdSqzsPgnFK/JD5kohkxNPZfBi5XBR17vYp5oo+LFwzPn4Fh9tn7vfG3hyDReVSrVYwYzIAtpujifAJQU1NRfnIAVj5h0AwSx2kW0qfXirKhGOJQSf023ginYvXsOz/+0KSwZx6UwLofXzSKKQkW6kBGsuj/X0n/uZX/EfJiCIKPt9jC9DQsKm5XcoPPPAvNIfEt41Y4LJvQc0t4BMN2A1w8n+rrhxQc4OZAHUIAM3jmzx5iLm0jWdXQFwULDHOBH2g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from SJ0PR03MB5950.namprd03.prod.outlook.com (2603:10b6:a03:2d3::20) by LV3PR03MB7636.namprd03.prod.outlook.com (2603:10b6:408:28d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.17; Fri, 10 Jul 2026 06:52:44 +0000 Received: from SJ0PR03MB5950.namprd03.prod.outlook.com ([fe80::53a0:bf93:6b6b:de01]) by SJ0PR03MB5950.namprd03.prod.outlook.com ([fe80::53a0:bf93:6b6b:de01%5]) with mapi id 15.21.0181.016; Fri, 10 Jul 2026 06:52:44 +0000 From: tze.yee.ng@altera.com To: Dinh Nguyen , linux-kernel@vger.kernel.org Subject: [PATCH v4 3/3] firmware: stratix10-rsu: remove async client before freeing channel in remove() Date: Thu, 9 Jul 2026 23:52:39 -0700 Message-ID: X-Mailer: git-send-email 2.43.7 In-Reply-To: References: Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SJ2P220CA0008.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:5da::18) To SJ0PR03MB5950.namprd03.prod.outlook.com (2603:10b6:a03:2d3::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR03MB5950:EE_|LV3PR03MB7636:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f6653bd-3c65-4f15-d7e4-08dede4fd784 X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|1800799024|18002099003|22082099003|55112099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: 2pHK1wpUgryIHGvmC5mCcOfHtrYpQ6KRoQpZERM0iJc4EKI0b539RkC95Yju2xCaTSrCBUN4F9gqwS34qWANICl3cPfAWk/WZhfWNcJ95d1ygJFS9tg7oIZbquUWIoktK0djBItBSPA7g19NJrLki4onxio7xApiKsQw4yGTEovArFt/4soMKzV8Gl1iSDYXR4IQ41+X4tZVTqOzr3NJ3yl0GVrZkb6RYPG689uzOh9OCOKS6eTECXqv2GeP4KGmzmeC2pw7Q1ZXX2cpgIPz1oPP+5RC7qfDtJgMRftt26tyPQoHGnSeLWeaPVVLhPtMjBVWdkfB9vPaOSHDX3r4dqSbNwlUL3L4446O67nVKU5QFNzpIAvilOlczCtSBth9kAgKrKSgaphSIJdassfMiQ0YO4HqdECEYW228PRocaxOXtt+Iq5bs1MMqepDOXw4wXmvHCHdlk98B4eM18X7xegqRNAwIkCxoWXcLMAPhuJJhyi7Jb7QaAo/v3gxhj5oZ6q7d9U5pxchmHINpCYe5cBLtb1QnUg7VzNmaFDk6W2tr81MGxnzV/mXqiV3inKq0whp/t3Vovcp65i/xuVr8XAYxNPFIiowQZhp1pc+s5t1kjdWgxCAUAIfe/tTUf5JbUy4ztzZ4knmrplHyuGsz/Ovs4J/dFFF+9ItdXka1X4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5950.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(18002099003)(22082099003)(55112099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fSw5T9vEtzdImZekYbQiH3gP1/nKre1kxNCxkE0ap+NpF1h0ffSDoyyrWYZU?= =?us-ascii?Q?thxHmZbwMpnPRW7Wb1vYcLr7hKhDjqS2AbzNGpooCKhOu9HsSmFhdJ7SSv3c?= =?us-ascii?Q?D7FXehUJ/JWIcrKIEJ5ElzLnL0PcTvC/IX/no5dZAFtfn22mAqr+37GNVd1n?= =?us-ascii?Q?lIW9Se9SPqwcvKnLtjV7B0f7RTkzoydgU0rWFNhhhjOBo8mBE4YeMaLn1jCR?= =?us-ascii?Q?XWsvFZSxl70hWnKIKWMjg6dbSC5L/tmrl2TxLgIesBWgPd4rr8AahSs2csWO?= =?us-ascii?Q?Az5XRu0QhxG8DByn/LhkzX9lmmYCTc+QuCgQe9h83W0f+M6AGZ4VG8zzPX7f?= =?us-ascii?Q?Et75h921M1aEbd1GdUkEnFnJlgwg2jOn8vuHEswdAW7seGQR6wo6RSgmBDDb?= =?us-ascii?Q?2FgN79BCOETTQ4Et093avVXGRvCcz9g+EJJG2nlNvp9R94vyMYsPTB3+dop5?= =?us-ascii?Q?d+3EWsrMUDdjUkxK1AuJKFyCwmvBs8VfCdz8aGvFeCjJz/+NXBl/JazAjE93?= =?us-ascii?Q?foanP07V2S4Br4nJO3npq+72u2+QZwa53URK5O5Yy4DrphCsYGcTAQ8GMSMm?= =?us-ascii?Q?mGF6/Od1W7Z7j5jLRjaGYVLflXbKNDowok53bUoiASb8zi72X2TuM0hY7D6O?= =?us-ascii?Q?trws2St+Ujku5Ebu3ngfC47h1A7SWd6Zf3MNrznnDm/zlHC4qCKKu0t52LK8?= =?us-ascii?Q?JE3CgoXwEI5OcNfHRguZ0lBXkhXP7EBf164RpmhCa41aA+lcba7KeZG+/UqU?= =?us-ascii?Q?grYhkgxsXvncTNC4Fg7c15kCfr5R4vv86eDF94fJLvnUYpE6yfw11gmRut6R?= =?us-ascii?Q?etF9ALKjvewSJ5OACftv1v2tUSfsa910f9g25IuyZOYCAhuQtBHwrV6Ji5AZ?= =?us-ascii?Q?+RGOWMfhbwgtBS6rx+Nsqb2n/DUVSD1pHKUc0KsjPDrV3jpvO+GBWrmMk3dJ?= =?us-ascii?Q?8/d9ahv2NATURTt47SG1TNc31qlbu1nTRk97IoKKuT587i0LkJi/GKWDSLrz?= =?us-ascii?Q?v5w0zHgxFm4KhzVz2QCciXeaHAI2DIGB8GnhOOXcPSmtivg7h9D+7YMyb/E6?= =?us-ascii?Q?d6/UevaSE5q5RXEUkBkJOra6eLMWwTYGDnA+0Ru+AttncjpuZE8XRpVJ2i07?= =?us-ascii?Q?Ru0QeU6Q6U/5yfhWAsSaR5KkjaU1Yd8CAxVmMW1UDgZbv5+hkWB8AVGi3O6k?= =?us-ascii?Q?Uc+UWXuJpMufeEJTHM8yWybNgMrWipkqjTulKYTnKFTbGnpmoG8WypHc1lgV?= =?us-ascii?Q?14RuTg1wHKEN7sj7Z2MG8JNDFS2vBEuuRmm5QrwgtfHBYe2gf/326a1Bu4qY?= =?us-ascii?Q?YddCYAZ+ATkVXU45ccwXjNREo5gOkqTUPHena6VdyHzpXhclL5KhKJBBPSta?= =?us-ascii?Q?OdUR9pEsG+x25L8sRHU64TR5a627mub6B3IpapDRgwag8nO4Nqt0XP0nLhhH?= =?us-ascii?Q?o67KLavPz99jsJrVn3ABIX7urr9vBzPOWQmfFkbljecpDzMdJhGKrbHwwZ/R?= =?us-ascii?Q?Nx1dVWymbk924MfJuC8eylH4EWqPQvjp4VsiNhDFSjGBiCG1O8bgw7RZXe+j?= =?us-ascii?Q?pxeg1HLmG3NJ1JqWHJ82sX8+/MpGTzhGKHGNEGO7ftSxLnIbdb+F9QmLAr2D?= =?us-ascii?Q?wVSH5DAOOsY9ZjGoh8OIicZSQskNXacTy9HoHz4gspgiLEOPWvsWaogxw4XA?= =?us-ascii?Q?2U5OgZLk4wA6e11WJLUoFcOhp7bnAne0cvmRONxnztu7N5J0lUNvZVUDVGCJ?= =?us-ascii?Q?EED5GQKbxQ=3D=3D?= X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f6653bd-3c65-4f15-d7e4-08dede4fd784 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5950.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2026 06:52:43.3787 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8kBafCs9IwzcScvwFKlkhxZW4zUWsK3sWqi90LheNp1EdAvtN+Cd/tCVPVLol2KE/zqelN71yI0A8gfRbXbJwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR03MB7636 From: Tze Yee Ng After stratix10_svc_add_async_client() succeeds in probe, remove() must call stratix10_svc_remove_async_client() before stratix10_svc_free_channel(). Otherwise async state is left allocated while the channel is released. Signed-off-by: Tze Yee Ng --- Changes in v4: - Rebased onto dinguyen/socfpga_svc_fixes_for_v7.2. - Narrowed scope to stratix10_rsu_remove() only (+1 line). Probe error paths, return 0 on success, Fixes:, and Cc: stable@ dropped; probe teardown is covered by bfd2eb9bba54 on the new base. - Title updated: "... in remove()" (was "... on probe errors" in v3). Changes in v3: - No code changes in all patches, only put Cc: stable@vger.kernel.org # 6.19+ in the sign-off block for the Fixes: tag in Patch 3. Changes in v2: - Fix patch title. - Move the fix description to the end of the patch. --- drivers/firmware/stratix10-rsu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/stratix10-rsu.c b/drivers/firmware/stratix10-rsu.c index a36c4e3d6975..cdda0c4410f8 100644 --- a/drivers/firmware/stratix10-rsu.c +++ b/drivers/firmware/stratix10-rsu.c @@ -1054,6 +1054,7 @@ static void stratix10_rsu_remove(struct platform_device *pdev) { struct stratix10_rsu_priv *priv = platform_get_drvdata(pdev); + stratix10_svc_remove_async_client(priv->chan); stratix10_svc_free_channel(priv->chan); } -- 2.43.7