mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julian Braha <julianbraha@gmail.com>
To: Frank van de Pol <fvdpol@gmail.com>, tiwai@suse.de, perex@perex.cz
Cc: ramiserifpersia@gmail.com, rmxpzlb@gmail.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] ALSA: usb: Add support for Reloop Jockey 3 DJ controllers
Date: Thu, 18 Jun 2026 11:53:33 +0100	[thread overview]
Message-ID: <f6b5a124-63c7-41ba-b268-ff6e76cfe57e@gmail.com> (raw)
In-Reply-To: <20260617203937.1273852-2-fvdpol@gmail.com>

Hi Frank,

On 6/17/26 21:39, Frank van de Pol wrote:

> +source "sound/usb/jockey3/Kconfig"
>  
>  endif	# SND_USB
>  
> diff --git a/sound/usb/Makefile b/sound/usb/Makefile
> index e62794a87e73..1f045c00dbc9 100644
> --- a/sound/usb/Makefile
> +++ b/sound/usb/Makefile
> @@ -37,3 +37,4 @@ obj-$(CONFIG_SND_USB_US122L) += snd-usbmidi-lib.o
>  
>  obj-$(CONFIG_SND) += misc/ usx2y/ caiaq/ 6fire/ hiface/ bcd2000/ qcom/
>  obj-$(CONFIG_SND_USB_LINE6)	+= line6/
> +obj-$(CONFIG_SND_USB_JOCKEY3) += jockey3/
> diff --git a/sound/usb/jockey3/Kconfig b/sound/usb/jockey3/Kconfig
> new file mode 100644
> index 000000000000..a1ac80f04450
> --- /dev/null
> +++ b/sound/usb/jockey3/Kconfig
> @@ -0,0 +1,19 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +config SND_USB_JOCKEY3
> +	tristate "Reloop Jockey 3 support"
> +	default m
> +	depends on SND_USB && USB
> +	select SND_PCM
> +	select SND_RAWMIDI

The dependency on SND_USB is unnecessary here, since the:
'source "sound/usb/jockey3/Kconfig"'
is already inside of an 'if SND_USB' so every config option in that file
depends on SND_USB.

- Julian Braha

  reply	other threads:[~2026-06-18 10:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-17 20:39 [PATCH v2 0/1] " Frank van de Pol
2026-06-17 20:39 ` [PATCH v2 1/1] " Frank van de Pol
2026-06-18 10:53   ` Julian Braha [this message]
2026-06-18 14:55     ` Frank van de Pol
2026-06-18 15:28   ` Takashi Iwai
2026-06-19  0:49     ` Frank van de Pol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6b5a124-63c7-41ba-b268-ff6e76cfe57e@gmail.com \
    --to=julianbraha@gmail.com \
    --cc=fvdpol@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=ramiserifpersia@gmail.com \
    --cc=rmxpzlb@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome