From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C5E58460 for ; Tue, 15 Apr 2025 03:50:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744689025; cv=none; b=W2TvmdGsBbb1PLhP7nZD51HSKEgF7KI322ODxE+qXeSKLCJeKus8E/IhXxhbrODozo3qUQo4gACrstgyWHL4GFWDDz+1WUMflhUGAOTBMdBIHinO1CfB1pwBDVuDqlvWvr6R5xlKso2DXXk2KjPJruQhraAkR+pBYXKqZ5yrPFg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744689025; c=relaxed/simple; bh=SdUj5+/nzv0F39Wj5DTjTZXfwhQjLyFRM2hjitzawqg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aMGde8tI8iVu0Pyp+/Uj9sD7B9Hzo5lnL8ZZGYufJoH9MoplZO1U2w+XWZD0oZ2WbL+vk8niG/YhM6hqJ6q34sg3i8i3zhRwU1z7du83FEpINtIoU9w9ccquQExYhb0Y1j2eEu6/o7gMcPcRlPIq8/HrIwN/9g7oRn8l75ElhO0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=GIOS62wk; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="GIOS62wk" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-391342fc1f6so4225956f8f.1 for ; Mon, 14 Apr 2025 20:50:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1744689021; x=1745293821; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=WIAWlJCsgWYXdrGXvRPyrX6FxfdZq+/T8PflCz4FGfk=; b=GIOS62wkpzirSMFP53+HZsYpTQZQZUruB/zzaZNGS+7hbMhLJSt6pzO3FjrN5jQ4UV oUNmXWD69tH3pzq5RbpmOPdSh8gZ1q9Mv938l/kgqwQWNj+q3THXRVLO0nfvO+kVNGzm 2K4In3y+n4dDA4TJpi9OlGuJSGBC49OijYkGFm56HZ+/W9YGCYrATmh5LZikDrHblsqf QUr472dF9IjrIH8+lkXl1AnKnBhhQ0FofpNdZhUvIQ+OYm1YDk1P4vQ2nyHrxjIaZVJ+ DmeUHBYX8rRu3aYzXFB3dvEOIApDLJq0gAxAKDuuLkW6oUh0QKTdtjg0MLjZson+SWqr r08Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744689021; x=1745293821; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WIAWlJCsgWYXdrGXvRPyrX6FxfdZq+/T8PflCz4FGfk=; b=DyNaHvywkEEvc7WRftGsFKKXIOkPKE+TUdaJEzUJ+d3x9mNy/7XI9fV1bs+JRCa3F4 x/n07WwJPdQ+vFGssj1gPvpG7QA1AOe/k9+q6mCZ7t76uvcJrc1r4MYB5hnuaEKub0dS T37dHkzX+aQTER1Il/VOWoBcZ+RblALQdKzUUBSAGAPwKKfPU1cIVLnu/GoxGiX7FlKH fuTFn3/UKYUtehUeYyTvxBShGKMa8NgClCy/UTnT4W+zj8/gIc8OhcCmsqOmYUJC8LJi UqNwpLmq6ASgIqyPGJ37WKNNZMYOtNWFEtsVOFiSiWxImV4ri34K0qEehn/aj04Btwqf kPIw== X-Forwarded-Encrypted: i=1; AJvYcCVsYEmde4ursZ7iZHcAhHaXYhL5xcidDzQyVbfqu/+2ORlg2BgL3r/6HEVr/77ytIlG+uW/5zDaqHpN2JM=@vger.kernel.org X-Gm-Message-State: AOJu0YxJA4JVSjlptbYtdOr0ollBTbmITegeM6cAGEXDHS3Q5DWGGOIX 4s4/l6LU75hMDLYKNZDvaVrta5aVdw4e85mlmx8BhKfbOQqt6HQ/4+jY64fdkF4= X-Gm-Gg: ASbGncu1hI8fyBljuKpgfFxoe/h7Iy0znhKs3S4PokWpnp69903FCO1+SC2HcybLPwE JsUJlgJHiS8PNyyuDl/tiufkFbPM6X9+KiDJHR0TRKY9feE0Mhsm/cY+Pz5Jhu1n/G6uLOW3FWh x132cOPy/SYjUb4WRQZCqjUWHrcd0AtFilZUpyvhzoe2HFMrR6Yki1l3toCvzVNnxn5EVAfCIN1 dw+KnDP8LFTnhM/HrqlTyz5P4sK5wP5CVQdacnYTuvDNU0gHwzqvzywqN+KJbSczfKpq56Fw8kU pnQHM7cZ4mfq6EAlow1UCIZIXM0r+qunWBpVpGdAUON4ViBsHkh0b7PPzM40+88an9DBagi8gfa fvBY= X-Google-Smtp-Source: AGHT+IFVa25BdX79BCFwclDmac3DYoFDzPGkDa1AUqdU62w+U2g5gFhFtlXnA29XLAKIuZE8k6ba9A== X-Received: by 2002:a05:6000:144f:b0:39c:cc7:3c62 with SMTP id ffacd0b85a97d-39eaaecaddamr12746322f8f.51.1744689021420; Mon, 14 Apr 2025 20:50:21 -0700 (PDT) Received: from ?IPV6:2403:580d:fda1::299? (2403-580d-fda1--299.ip6.aussiebb.net. [2403:580d:fda1::299]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd12b4bdsm12134263a91.27.2025.04.14.20.50.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 20:50:20 -0700 (PDT) Message-ID: Date: Tue, 15 Apr 2025 13:20:15 +0930 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] btrfs: zstd: add `zstd-fast` alias mount option for fast modes To: Daniel Vacek , dsterba@suse.cz Cc: Qu Wenruo , Chris Mason , Josef Bacik , David Sterba , Nick Terrell , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250331082347.1407151-1-neelx@suse.com> <2a759601-aebf-4d28-8649-ca4b1b3e755c@suse.com> <20250331225705.GN32661@twin.jikos.cz> Content-Language: en-US From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXVgBQkQ/lqxAAoJEMI9kfOh Jf6o+jIH/2KhFmyOw4XWAYbnnijuYqb/obGae8HhcJO2KIGcxbsinK+KQFTSZnkFxnbsQ+VY fvtWBHGt8WfHcNmfjdejmy9si2jyy8smQV2jiB60a8iqQXGmsrkuR+AM2V360oEbMF3gVvim 2VSX2IiW9KERuhifjseNV1HLk0SHw5NnXiWh1THTqtvFFY+CwnLN2GqiMaSLF6gATW05/sEd V17MdI1z4+WSk7D57FlLjp50F3ow2WJtXwG8yG8d6S40dytZpH9iFuk12Sbg7lrtQxPPOIEU rpmZLfCNJJoZj603613w/M8EiZw6MohzikTWcFc55RLYJPBWQ+9puZtx1DopW2jOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXWBBQkQ/lrSAAoJEMI9kfOhJf6o cakH+QHwDszsoYvmrNq36MFGgvAHRjdlrHRBa4A1V1kzd4kOUokongcrOOgHY9yfglcvZqlJ qfa4l+1oxs1BvCi29psteQTtw+memmcGruKi+YHD7793zNCMtAtYidDmQ2pWaLfqSaryjlzR /3tBWMyvIeWZKURnZbBzWRREB7iWxEbZ014B3gICqZPDRwwitHpH8Om3eZr7ygZck6bBa4MU o1XgbZcspyCGqu1xF/bMAY2iCDcq6ULKQceuKkbeQ8qxvt9hVxJC2W3lHq8dlK1pkHPDg9wO JoAXek8MF37R8gpLoGWl41FIUb3hFiu3zhDDvslYM4BmzI18QgQTQnotJH8= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit 在 2025/4/14 16:23, Daniel Vacek 写道: > On Wed, 2 Apr 2025 at 16:31, Daniel Vacek wrote: [...] >> I'd still opt for keeping full range and functionality including >> negative levels using the plain `zstd:N` option and having the other >> just as an additional alias (for maybe being a bit nicer to some >> humans, but not a big deal really and a matter of preference). >> Checking the official documentation, it still mentions "negative >> compression levels" being the fast option. >> >> https://facebook.github.io/zstd/ >> https://facebook.github.io/zstd/zstd_manual.html >> >> The deprecation part looks like just some gossip. It looks more about >> the cli tool api and we are defining a kernel mount api - perfectly >> unrelated. > > Any feedback, Dave? I tend to drop this ida of `zstd-fast` alias. Not Dave here, but if the future of "zstd-fast" is not that clear, we can definitely wait for a while. It's always safer to adapt when the terminology is mature enough. Thanks, Qu > >>> We can make this change before 6.15 final so it's not in any released >>> kernel and we don't have to deal with compatibility.