From: Paolo Bonzini <pbonzini@redhat.com>
To: Maxim Levitsky <mlevitsk@redhat.com>, kvm@vger.kernel.org
Cc: Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Sean Christopherson <sean.j.christopherson@intel.com>
Subject: Re: [PATCH 2/8] KVM: nSVM: rename nested 'vmcb' to vmcb_gpa in few places
Date: Thu, 20 Aug 2020 11:56:33 +0200 [thread overview]
Message-ID: <f6bf9494-f337-2e53-6e6c-e0b8a847ec8d@redhat.com> (raw)
In-Reply-To: <20200820091327.197807-3-mlevitsk@redhat.com>
On 20/08/20 11:13, Maxim Levitsky wrote:
> No functional changes.
>
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
> ---
> arch/x86/kvm/svm/nested.c | 10 +++++-----
> arch/x86/kvm/svm/svm.c | 13 +++++++------
> arch/x86/kvm/svm/svm.h | 2 +-
> 3 files changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c
> index fb68467e6049..d9755eab2199 100644
> --- a/arch/x86/kvm/svm/nested.c
> +++ b/arch/x86/kvm/svm/nested.c
> @@ -431,7 +431,7 @@ int enter_svm_guest_mode(struct vcpu_svm *svm, u64 vmcb_gpa,
> {
> int ret;
>
> - svm->nested.vmcb = vmcb_gpa;
> + svm->nested.vmcb_gpa = vmcb_gpa;
> load_nested_vmcb_control(svm, &nested_vmcb->control);
> nested_prepare_vmcb_save(svm, nested_vmcb);
> nested_prepare_vmcb_control(svm);
> @@ -568,7 +568,7 @@ int nested_svm_vmexit(struct vcpu_svm *svm)
> struct vmcb *vmcb = svm->vmcb;
> struct kvm_host_map map;
>
> - rc = kvm_vcpu_map(&svm->vcpu, gpa_to_gfn(svm->nested.vmcb), &map);
> + rc = kvm_vcpu_map(&svm->vcpu, gpa_to_gfn(svm->nested.vmcb_gpa), &map);
> if (rc) {
> if (rc == -EINVAL)
> kvm_inject_gp(&svm->vcpu, 0);
> @@ -579,7 +579,7 @@ int nested_svm_vmexit(struct vcpu_svm *svm)
>
> /* Exit Guest-Mode */
> leave_guest_mode(&svm->vcpu);
> - svm->nested.vmcb = 0;
> + svm->nested.vmcb_gpa = 0;
> WARN_ON_ONCE(svm->nested.nested_run_pending);
>
> /* in case we halted in L2 */
> @@ -1018,7 +1018,7 @@ static int svm_get_nested_state(struct kvm_vcpu *vcpu,
>
> /* First fill in the header and copy it out. */
> if (is_guest_mode(vcpu)) {
> - kvm_state.hdr.svm.vmcb_pa = svm->nested.vmcb;
> + kvm_state.hdr.svm.vmcb_pa = svm->nested.vmcb_gpa;
> kvm_state.size += KVM_STATE_NESTED_SVM_VMCB_SIZE;
> kvm_state.flags |= KVM_STATE_NESTED_GUEST_MODE;
>
> @@ -1128,7 +1128,7 @@ static int svm_set_nested_state(struct kvm_vcpu *vcpu,
> copy_vmcb_control_area(&hsave->control, &svm->vmcb->control);
> hsave->save = save;
>
> - svm->nested.vmcb = kvm_state->hdr.svm.vmcb_pa;
> + svm->nested.vmcb_gpa = kvm_state->hdr.svm.vmcb_pa;
> load_nested_vmcb_control(svm, &ctl);
> nested_prepare_vmcb_control(svm);
>
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index 562a79e3e63a..4338d2a2596e 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -1102,7 +1102,7 @@ static void init_vmcb(struct vcpu_svm *svm)
> }
> svm->asid_generation = 0;
>
> - svm->nested.vmcb = 0;
> + svm->nested.vmcb_gpa = 0;
> svm->vcpu.arch.hflags = 0;
>
> if (!kvm_pause_in_guest(svm->vcpu.kvm)) {
> @@ -3884,7 +3884,7 @@ static int svm_pre_enter_smm(struct kvm_vcpu *vcpu, char *smstate)
> /* FED8h - SVM Guest */
> put_smstate(u64, smstate, 0x7ed8, 1);
> /* FEE0h - SVM Guest VMCB Physical Address */
> - put_smstate(u64, smstate, 0x7ee0, svm->nested.vmcb);
> + put_smstate(u64, smstate, 0x7ee0, svm->nested.vmcb_gpa);
>
> svm->vmcb->save.rax = vcpu->arch.regs[VCPU_REGS_RAX];
> svm->vmcb->save.rsp = vcpu->arch.regs[VCPU_REGS_RSP];
> @@ -3903,17 +3903,18 @@ static int svm_pre_leave_smm(struct kvm_vcpu *vcpu, const char *smstate)
> struct vmcb *nested_vmcb;
> struct kvm_host_map map;
> u64 guest;
> - u64 vmcb;
> + u64 vmcb_gpa;
> int ret = 0;
>
> guest = GET_SMSTATE(u64, smstate, 0x7ed8);
> - vmcb = GET_SMSTATE(u64, smstate, 0x7ee0);
> + vmcb_gpa = GET_SMSTATE(u64, smstate, 0x7ee0);
>
> if (guest) {
> - if (kvm_vcpu_map(&svm->vcpu, gpa_to_gfn(vmcb), &map) == -EINVAL)
> + if (kvm_vcpu_map(&svm->vcpu, gpa_to_gfn(vmcb_gpa), &map) == -EINVAL)
> return 1;
> +
> nested_vmcb = map.hva;
> - ret = enter_svm_guest_mode(svm, vmcb, nested_vmcb);
> + ret = enter_svm_guest_mode(svm, vmcb_gpa, nested_vmcb);
> kvm_vcpu_unmap(&svm->vcpu, &map, true);
> }
>
> diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h
> index a798e1731709..03f2f082ef10 100644
> --- a/arch/x86/kvm/svm/svm.h
> +++ b/arch/x86/kvm/svm/svm.h
> @@ -85,7 +85,7 @@ struct svm_nested_state {
> struct vmcb *hsave;
> u64 hsave_msr;
> u64 vm_cr_msr;
> - u64 vmcb;
> + u64 vmcb_gpa;
> u32 host_intercept_exceptions;
>
> /* These are the merged vectors */
>
Please use vmcb12_gpa, and svm->nested.vmcb12 for the VMCB in patch 6.
(You probably also what to have local variables named vmcb12 in patch 6
to avoid too-long lines).
Paolo
next prev parent reply other threads:[~2020-08-20 12:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 9:13 [PATCH 0/8] KVM: nSVM: ondemand nested state allocation + nested guest state caching Maxim Levitsky
2020-08-20 9:13 ` [PATCH 1/8] KVM: SVM: rename a variable in the svm_create_vcpu Maxim Levitsky
2020-08-20 9:13 ` [PATCH 2/8] KVM: nSVM: rename nested 'vmcb' to vmcb_gpa in few places Maxim Levitsky
2020-08-20 9:56 ` Paolo Bonzini [this message]
2020-08-20 10:00 ` Maxim Levitsky
2020-08-20 10:19 ` Paolo Bonzini
2020-08-20 10:23 ` Maxim Levitsky
2020-08-20 10:56 ` Paolo Bonzini
2020-08-20 11:52 ` Maxim Levitsky
2020-08-20 9:13 ` [PATCH 3/8] KVM: SVM: refactor msr permission bitmap allocation Maxim Levitsky
2020-08-20 9:13 ` [PATCH 4/8] KVM: x86: allow kvm_x86_ops.set_efer to return a value Maxim Levitsky
2020-08-20 9:13 ` [PATCH 5/8] KVM: nSVM: implement ondemand allocation of the nested state Maxim Levitsky
2020-08-20 9:58 ` Paolo Bonzini
2020-08-20 10:02 ` Maxim Levitsky
2020-08-20 9:13 ` [PATCH 6/8] SVM: nSVM: cache whole nested vmcb instead of only its control area Maxim Levitsky
2020-08-20 9:13 ` [PATCH 7/8] KVM: nSVM: implement caching of nested vmcb save area Maxim Levitsky
2020-08-20 9:13 ` [PATCH 8/8] KVM: nSVM: read only changed fields of the nested guest data area Maxim Levitsky
2020-08-20 9:55 ` Paolo Bonzini
2020-08-20 9:57 ` Maxim Levitsky
2020-08-20 10:01 ` Paolo Bonzini
2020-08-20 10:05 ` Maxim Levitsky
2020-08-20 10:18 ` Paolo Bonzini
2020-08-20 10:26 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6bf9494-f337-2e53-6e6c-e0b8a847ec8d@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®