From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754994AbdK2Nsu (ORCPT ); Wed, 29 Nov 2017 08:48:50 -0500 Received: from smtp-out6.electric.net ([192.162.217.185]:55719 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932853AbdK2Nsq (ORCPT ); Wed, 29 Nov 2017 08:48:46 -0500 From: David Laight To: "'Xie XiuQi'" , "rostedt@goodmis.org" , "mingo@redhat.com" , "davem@davemloft.net" , "brouer@redhat.com" CC: "daniel@iogearbox.net" , "ast@kernel.org" , "kstewart@linuxfoundation.org" , "gregkh@linuxfoundation.org" , "john.fastabend@gmail.com" , "linux-kernel@vger.kernel.org" , "huangdaode@hisilicon.com" , Hanjun Guo Subject: =?utf-8?B?UkU6IFtQQVRDSF0gdHJhY2UveGRwOiBmaXggY29tcGlsZSB3YXJuaW5nOiA=?= =?utf-8?B?4oCYc3RydWN0IGJwZl9tYXDigJkgZGVjbGFyZWQgaW5zaWRlIHBhcmFtZXRl?= =?utf-8?Q?r_list?= Thread-Topic: =?utf-8?B?W1BBVENIXSB0cmFjZS94ZHA6IGZpeCBjb21waWxlIHdhcm5pbmc6IOKAmHN0?= =?utf-8?B?cnVjdCBicGZfbWFw4oCZIGRlY2xhcmVkIGluc2lkZSBwYXJhbWV0ZXIgbGlz?= =?utf-8?Q?t?= Thread-Index: AQHTaOzVth7F6PNLA0yJUm3aZah196MrX1Rg Date: Wed, 29 Nov 2017 13:49:01 +0000 Message-ID: References: <1511944501-160820-1-git-send-email-xiexiuqi@huawei.com> In-Reply-To: <1511944501-160820-1-git-send-email-xiexiuqi@huawei.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [fd9f:af1c:a25b:0:43c:695e:880f:8750] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Outbound-IP: 156.67.243.126 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuMS.aculab.com X-TLS: TLSv1.2:ECDHE-RSA-AES256-SHA384:256 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vATDmwwP017756 From: Xie XiuQi > Sent: 29 November 2017 08:35 > > We meet this compile warning, which caused by missing bpf.h in xdp.h. > > In file included from ./include/trace/events/xdp.h:10:0, > from ./include/linux/bpf_trace.h:6, > from drivers/net/ethernet/intel/i40e/i40e_txrx.c:29: > ./include/trace/events/xdp.h:93:17: warning: struct bpf_map declared inside parameter list will not be > visible outside of this definition or declaration > const struct bpf_map *map, u32 map_index), > ^ ... > diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h > index 4cd0f05..8989a92 100644 > --- a/include/trace/events/xdp.h > +++ b/include/trace/events/xdp.h > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include Isn't it just enough to add: struct bpf_map; before the first prototype instead of pulling in the entire header? David