From: Baolu Lu <baolu.lu@linux.intel.com>
To: "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: baolu.lu@linux.intel.com,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"joro@8bytes.org" <joro@8bytes.org>,
"will@kernel.org" <will@kernel.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"Peng, Chao P" <chao.p.peng@intel.com>,
Kyung Min Park <kyung.min.park@intel.com>
Subject: Re: [PATCH 2/2] iommu/vt-d: Fix checks in pgtable_walk()
Date: Wed, 23 Oct 2024 15:41:37 +0800 [thread overview]
Message-ID: <f6d109cd-9a7e-416f-87d7-429e584e3b3e@linux.intel.com> (raw)
In-Reply-To: <SJ0PR11MB6744EC9F9B202E1BBE7DC4B1924D2@SJ0PR11MB6744.namprd11.prod.outlook.com>
On 2024/10/23 13:16, Duan, Zhenzhong wrote:
>> -----Original Message-----
>> From: Baolu Lu<baolu.lu@linux.intel.com>
>> Sent: Wednesday, October 23, 2024 12:50 PM
>> Subject: Re: [PATCH 2/2] iommu/vt-d: Fix checks in pgtable_walk()
>>
>> On 2024/10/22 17:50, Zhenzhong Duan wrote:
>>> It's not accurate to dump super page as non-present page,
>>> meanwhile bit7 in first level page table entry is PAT bit,
>> Can you please explain how the 'bit7 in first level page table entry' is
>> relevant to the changes made in this patch?
> When iterate to level 1, it is leaf page table entry, bit 7 is PAT bit instead of PS bit.
> dma_pte_superpage(pte) may return true, then " PTE not present at level 1" may
> be printed out.
I see. Thank you!
If you have a new version, can you please make it a bit clearer? My
understanding is that dma_pte_superpage(pte) should not check against
the leaf page table entries, right?
Thanks,
baolu
next prev parent reply other threads:[~2024-10-23 7:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 9:50 [PATCH 0/2] vtd: Minor cleanup Zhenzhong Duan
2024-10-22 9:50 ` [PATCH 1/2] iommu/vt-d: Fix checks in dmar_fault_dump_ptes() Zhenzhong Duan
2024-10-23 3:12 ` Baolu Lu
2024-10-23 5:09 ` Duan, Zhenzhong
2024-10-23 7:37 ` Baolu Lu
2024-10-22 9:50 ` [PATCH 2/2] iommu/vt-d: Fix checks in pgtable_walk() Zhenzhong Duan
2024-10-23 4:49 ` Baolu Lu
2024-10-23 5:16 ` Duan, Zhenzhong
2024-10-23 7:41 ` Baolu Lu [this message]
2024-10-23 7:48 ` Duan, Zhenzhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6d109cd-9a7e-416f-87d7-429e584e3b3e@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=chao.p.peng@intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kyung.min.park@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®