From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A6D8C433F5 for ; Sun, 7 Nov 2021 20:46:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34FC261165 for ; Sun, 7 Nov 2021 20:46:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235122AbhKGUtT (ORCPT ); Sun, 7 Nov 2021 15:49:19 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30685 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbhKGUtS (ORCPT ); Sun, 7 Nov 2021 15:49:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636317994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y4DIqpGTdWvRNB5tsuZCnliZFF68Qji5Xly3UtINbPc=; b=gLCeqe26dzAVx2GqhQkV6iVjBArOMib42K5htC2KyPMZ5zdf6t1401bbPqMuEj+eVmcv8W h4bV5NM5hu0BFVsRaWqax/dhpMfFtWQy8tgnvko/OPhaKp6Th/VYtWU9BTcZjih8SV8q1t a1FwiL2eAsCDu6w6EuLHFMyiUVHfj5Q= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-597-u9T2q8PaN5KjBW95msWQrw-1; Sun, 07 Nov 2021 15:46:32 -0500 X-MC-Unique: u9T2q8PaN5KjBW95msWQrw-1 Received: by mail-ed1-f69.google.com with SMTP id w13-20020a05640234cd00b003e2fde5ff8aso7439608edc.14 for ; Sun, 07 Nov 2021 12:46:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Y4DIqpGTdWvRNB5tsuZCnliZFF68Qji5Xly3UtINbPc=; b=RIFpqA3pqLJw3HNSy33ZDtky6PZD8+A+v64xfis9hBmgZET26k2o3iAtklaEAXt2rV 4kJk62Im2WcHTmOcuEi94xDA6B3rmG69AZOguXMobaUN7bCS5bsQkpZbKxaZvYQAKEwR SSN6nijQPao5vaRdlClgadCouDVeFrSGh33OfOUKJoIg8lAOiBvNZ9nnOkYy/j0SHcG4 x4h4Tr/NeoqESk62JMXSIkBfSAb5V5gMA3FBuVOmspsqiezPpOj6FaBcfBwkTvFj3TXn K8a9ON8OPn9QOEgZAq/TW0l29/igMSxk26rHcZfkGYzZllBRwL59+61oeEeXT3C0tTmk QOBg== X-Gm-Message-State: AOAM5323F0Dh+ITlMVkVQDB8r3PBy+Ofq55TD9lznfLkEP3sWM6zl44x R5z2owepLWdSFcF8/qXQfgEs3WnkCTBgbHtIjhlwMqVN+Q3GVRnvfqUwV9cL5hiU5kYVswXtqLz Na1XSWO8Msgqo/Hr9By2NAmLf X-Received: by 2002:a17:906:7304:: with SMTP id di4mr89769166ejc.179.1636317991331; Sun, 07 Nov 2021 12:46:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJwKIbqOdkscXYajDNG5edvb3cb6535fkJeFN82d1pbwDw+foLziTMygoGer20ovRw2d8G58lw== X-Received: by 2002:a17:906:7304:: with SMTP id di4mr89769154ejc.179.1636317991172; Sun, 07 Nov 2021 12:46:31 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1054:9d19:e0f0:8214? (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id w25sm32447edv.57.2021.11.07.12.46.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Nov 2021 12:46:30 -0800 (PST) Message-ID: Date: Sun, 7 Nov 2021 21:46:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 3/4] power supply bq25890-charger: Handle temperature faults Content-Language: en-US To: Yauhen Kharuzhy , Sebastian Reichel Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211107202001.54579-1-jekhor@gmail.com> <20211107202001.54579-3-jekhor@gmail.com> From: Hans de Goede In-Reply-To: <20211107202001.54579-3-jekhor@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/7/21 21:20, Yauhen Kharuzhy wrote: > Add debug info about thermal failure to message in > bq25890_get_chip_state(). > > Take into account possible thermal failure when calculating a > POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX value as it described in > datasheet (in cold conditions a current limit is decreased to 20% or 50% of > ICHG field value depended on JEITA_ISET field). > > Signed-off-by: Yauhen Kharuzhy Thank you for your patch, Patch subject prefix should be: "power: supply: bq25890: " > --- > drivers/power/supply/bq25890_charger.c | 33 +++++++++++++++++++++++--- > 1 file changed, 30 insertions(+), 3 deletions(-) > > diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c > index 1c43555d5bd8..fb2f1578503c 100644 > --- a/drivers/power/supply/bq25890_charger.c > +++ b/drivers/power/supply/bq25890_charger.c > @@ -95,6 +95,7 @@ struct bq25890_state { > u8 vsys_status; > u8 boost_fault; > u8 bat_fault; > + u8 ntc_fault; > }; > > struct bq25890_device { > @@ -384,6 +385,14 @@ enum bq25890_chrg_fault { > CHRG_FAULT_TIMER_EXPIRED, > }; > > +enum bq25890_ntc_fault { > + NTC_FAULT_NORMAL = 0, > + NTC_FAULT_WARM = 2, > + NTC_FAULT_COOL = 3, > + NTC_FAULT_COLD = 5, > + NTC_FAULT_HOT = 6, > +}; > + > static bool bq25890_is_adc_property(enum power_supply_property psp) > { > switch (psp) { > @@ -474,7 +483,19 @@ static int bq25890_power_supply_get_property(struct power_supply *psy, > break; > > case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX: > + ret = bq25890_field_read(bq, F_JEITA_ISET); > + if (ret < 0) > + return ret; > + You only use the read value if bq->state.ntc_fault == NTC_FAULT_COOL and i2c reads are somewhat expensive (or at least slow), can you please move this to inside the "if (bq->state.ntc_fault == NTC_FAULT_COOL) {" block ? This is esp. relevant since this condition will normally be false, so normally this will save us an i2c_read for every read of the POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX property. > val->intval = bq25890_find_val(bq->init_data.ichg, TBL_ICHG); > + > + /* When temperature is too low, charge current is decreased */ > + if (bq->state.ntc_fault == NTC_FAULT_COOL) { > + if (ret) > + val->intval /= 5; > + else > + val->intval /= 2; > + } > break; > > case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE: > @@ -487,6 +508,10 @@ static int bq25890_power_supply_get_property(struct power_supply *psy, > if (ret < 0) > return ret; > > + ret = bq25890_field_read(bq, F_JEITA_VSET); > + if (ret < 0) > + return ret; > + > /* converted_val = 2.304V + ADC_val * 20mV (table 10.3.15) */ > val->intval = 2304000 + ret * 20000; > break; > @@ -550,7 +575,8 @@ static int bq25890_get_chip_state(struct bq25890_device *bq, > {F_VSYS_STAT, &state->vsys_status}, > {F_BOOST_FAULT, &state->boost_fault}, > {F_BAT_FAULT, &state->bat_fault}, > - {F_CHG_FAULT, &state->chrg_fault} > + {F_CHG_FAULT, &state->chrg_fault}, > + {F_CHG_FAULT, &state->ntc_fault} Copy paste error? Surely the field in the second line must be F_NTG_FAULT ? > }; > > for (i = 0; i < ARRAY_SIZE(state_fields); i++) { > @@ -561,9 +587,10 @@ static int bq25890_get_chip_state(struct bq25890_device *bq, > *state_fields[i].data = ret; > } > > - dev_dbg(bq->dev, "S:CHG/PG/VSYS=%d/%d/%d, F:CHG/BOOST/BAT=%d/%d/%d\n", > + dev_dbg(bq->dev, "S:CHG/PG/VSYS=%d/%d/%d, F:CHG/BOOST/BAT/NTC=%d/%d/%d/%d\n", > state->chrg_status, state->online, state->vsys_status, > - state->chrg_fault, state->boost_fault, state->bat_fault); > + state->chrg_fault, state->boost_fault, state->bat_fault, > + state->ntc_fault); > > return 0; > } > Regards, Hans