From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752621AbcGYHfA (ORCPT ); Mon, 25 Jul 2016 03:35:00 -0400 Received: from mga14.intel.com ([192.55.52.115]:40367 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752379AbcGYHev (ORCPT ); Mon, 25 Jul 2016 03:34:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,418,1464678000"; d="scan'208";a="1001849190" Subject: Re: [Intel-gfx] [PATCH v2 2/4] drm/i915/skl: Only flush pipes when we change the ddb allocation To: Lyude , intel-gfx@lists.freedesktop.org, Matt Roper References: <1469129020-2680-1-git-send-email-cpaul@redhat.com> <1469129020-2680-3-git-send-email-cpaul@redhat.com> Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hans de Goede , Daniel Vetter From: Maarten Lankhorst Message-ID: Date: Mon, 25 Jul 2016 09:34:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1469129020-2680-3-git-send-email-cpaul@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 21-07-16 om 21:23 schreef Lyude: > Manual pipe flushes are only necessary in order to make sure that we prevent > pipes with changed ddb allocations from overlapping from one another at > any point in time. Additionally, forcing us to wait for the next vblank > every time we have to update the watermark values because the cursor was > moving between screens will introduce a rather noticable lag for users. This screams for a testcase in kms_cursor_legacy, when does this happen exactly? I'm guessing it needs 2 screens, page flip on both and cursor update on both, one hiding the cursor other screen making it reappear.. ~Maarten