From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44B3F36403C for ; Tue, 16 Jun 2026 11:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781608704; cv=none; b=Iut5SV69DWQAuM9BizutlD85kpSyicbJtjDuO5ktpBmmQK5iPY83x5ZQNJHq8yu0mZk9h1fLyH74rjGSrVUspH4sBeVtkxYw5zWrkoYtrMEkHTcJEgOosQHlJDEasJ9rdXxia2oB7HCe9QQbjLhoMElbs9xEcY5uvrx2NbAVV2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781608704; c=relaxed/simple; bh=my90AxcsOT0BM+hQjh9MNTinNSbEdC0lQeKCWBsWE28=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aKdalVOGQlqaSK2HS4UWnukggwE1gdvsUzT2roA61ejY5WYDkPuQn9TzBN4aS79E+VpsQ+dWFVZxenKmCvIifT1oB6/3uCnkejQEM8tmdU01QLB9YpSjtp6h3C+Vmx8GeMoAKo65v5jJ0Ueeoe09qSN1LfSlmgVYCTrQ35pmDfs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fgDwNjjw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OgS9oD4D; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fgDwNjjw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OgS9oD4D" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GABnHm3384141 for ; Tue, 16 Jun 2026 11:18:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1mC4p/ZORnTCo0N4Vz/PvLV6xnFXcvPjV/Xeey750iY=; b=fgDwNjjwMqTyQK6Z JwROqnBq6ifyMPf8FYZ0BMUTM+TNiGYFFM0KbbgH8C0AbdpOc/fFQKx1YcI71tQq U0OMrwJFlaRhbRUoRxsfUvFZ0FWGnyEJJUnj2z74Z/6mqd0g+gaN3e8hbVLMSdDd aQH2iKoECXSFDjptpP3UgrAKbF8rRqEVnbobqesPV4Yy7bcA5X7RYHDdcPzU03ud DskvVN7ekHxTpMh/CV0/leBaX71aBfBnwf9g2uq/VIi864hH0k9NV5RTcY2ogegE 5Wy+C9c5QVWgUzHTTMFcBsjInP9Sdy48DnDsh3QuUxtJsmce7Q6JPMR0AX5S4kS8 J6RFhQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eu1ep949g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 11:18:22 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-37c64f7ff48so240699a91.2 for ; Tue, 16 Jun 2026 04:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781608701; x=1782213501; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1mC4p/ZORnTCo0N4Vz/PvLV6xnFXcvPjV/Xeey750iY=; b=OgS9oD4D0YzDiXyR8tbOKDjuvB0i/1mMjmx38+BZ2ssFVxAi9+k9OMzKQmJj3qbBvd es0ZPnhMK4YG5HGie4+7YLFrH0XGLrLHS9sIli8CfgrglFueIsK7K6CgdysqeZ6SvGyR /3DLytIjRYzY+/PyA9FjTBCXokLNS/cV7B5fj1Mpy2t+3hU1ZcJedjZxH8189FU1z15b w/q+FSvf5Z+UomHyhOXe+Ts41qiC6W/wfSGmyjNAAm3vR6NrlrvvWG6JKD4JqV+mx/Pz 058JVh1LcUZjuQdhRZuief8g6vKfJUmiVxaEEyB86cISTF+HzpJ6u8/cx7n6cZ8lLI8J eLFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781608701; x=1782213501; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1mC4p/ZORnTCo0N4Vz/PvLV6xnFXcvPjV/Xeey750iY=; b=hLTpVZJO/MWVGq6G13KXd9GmjUxzGgVc9Ag2FzEHQQ7ZVi0sWdC5/SeyVPDRF08HJn 2v1ZxvI965/kaD4Il5gB2lXdtqCCIVP4VGuuBvgQG4ax7vrSBUFtWDL8N+NLVkhR/u02 I8o/3vEkY7zv/sZg5TNaRHV9qnq17A3rjHoREKyh34G0uAPObhJgsJ+fqmGkqS5IW3nK Ep5A7iVpNxBq7Z+I7RlICXGVKHlx9akOz+Vaw1nUjmEsJ7wVwOHG8hU1Vh8V8jyJrW83 D4am/4NHyTmd3uQfQjviwvr4dZtIuPzglUgUj+KqA6bJ0ThKzzwR2Qj+ybJQtlY4hF9p 55kQ== X-Forwarded-Encrypted: i=1; AFNElJ8uempB56qv05tY6W4Dg5xF4oSUYwidHQih+mnsmGBo5Z7MgW84edKn/RwE7ZA/pC161U7P3uAzZKakUzs=@vger.kernel.org X-Gm-Message-State: AOJu0YwD3ygMxUhpTjrWHHOay21E+mJdVpD2hTxQWWF7ydRgXioKKC6w phFvUhMiAACJfvCY3OZGYNAXdnt/G2EEazdYNyekRd/m3ttDBAr33M3pTq6a9/8bnNMIzyQDndv qGNlihhK6YVAkAJ7udAG6TqTl3IpPu8uJff7R8u0t20d7my8LCFWxjd2bBu6ECwQs+Qo= X-Gm-Gg: Acq92OETwMLH+TS+orcqzxk4mEMGzureI+rO6bd05RsAc8YEP01aBn6l78gaLrOBQTy Kymj2m63SeL5thPHzFGBPqHx4zukeHrfQV01y2eBkvkPGSqOTCz0wnHIUCZvzMBBilrDzfaJQrh 0dvi8f1X3oWliWxK6P87AqBXkHcyfUJ4mZE5Q2+pg3dFK8n0G/atqnSnzNGNjocYf2JoQsZS+vI jDaIu3S1IdOWUu3O3lmNb6I3uS3H0YexdIvYuaG1g2KVX5Z8FTnJ5Msq65DjGa6k+MEqLJ3OMIL eiUg1Fpxbc9LNA7wSh7F2kOxFa1BlVm4eplwDqWSZ8gVjf0ndkJzagKzHN+3hM4u0JcaEbQVNV/ fwjV0okdCrts4rH2YYqnXH9pRTIkTJO2O/KezQBoZusKDK+LCNg== X-Received: by 2002:a17:90a:d40b:b0:36d:6315:1de4 with SMTP id 98e67ed59e1d1-37a036ea1b9mr19181547a91.17.1781608701107; Tue, 16 Jun 2026 04:18:21 -0700 (PDT) X-Received: by 2002:a17:90a:d40b:b0:36d:6315:1de4 with SMTP id 98e67ed59e1d1-37a036ea1b9mr19181517a91.17.1781608700654; Tue, 16 Jun 2026 04:18:20 -0700 (PDT) Received: from [10.218.15.172] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37c521ca7a7sm2624672a91.7.2026.06.16.04.18.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 04:18:20 -0700 (PDT) Message-ID: Date: Tue, 16 Jun 2026 16:48:14 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] pinctrl: qcom: Unconditionally mark gpio as wakeup enable To: Konrad Dybcio , Bjorn Andersson , Linus Walleij , Neil Armstrong , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Maulik Shah References: <20260430-enable_wakeup_capable_gpios-v2-1-8c26ac795318@oss.qualcomm.com> <2ba8b020-c8b9-4c60-9fa8-545642bde1fb@oss.qualcomm.com> Content-Language: en-US From: Sneh Mankad In-Reply-To: <2ba8b020-c8b9-4c60-9fa8-545642bde1fb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=I/ZVgtgg c=1 sm=1 tr=0 ts=6a3130fe cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=Ye5m1eMZPwjv6mJ2BMQA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDExNCBTYWx0ZWRfXzSQ3yBP2gWfO EVUbLLwTEhvptcMrBAbVjEHnCi5sd6a2sz8Cx963Ta81jd4qlAOwSZzTTxUctoia6oktXw8mnR3 a+cHgufdcgkSdpY+uLH/fRNK5RknaVc= X-Proofpoint-ORIG-GUID: PkQFEvpipNl0C5aakggDSUvOv0EbALnD X-Proofpoint-GUID: PkQFEvpipNl0C5aakggDSUvOv0EbALnD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDExNCBTYWx0ZWRfXw1l0aP+2Rkkn 1cHi9gj90PycPSZlOzrJsGvEeB9wau3LkCZTdW6UYET6PjzppWQ8K3FwwHCvzaHoAGehg71n780 9S1ywWLUhJtHu8e3pP+YbWka2kG0hYylzCYS/ZQ1XDbpYo15DAzEzXQCBDXsmQG42OWYAvVA7hh a18Z66skvfjgbldb5BN3x60OCSZZEHp7326s9Uur3wQdR/Rt+zPN1uRna0DkRfz8kJCqovqyGDP 3P8IUpEsFoWHYGvCVJ7vz9+MePczrUCOFKdfjeJfLAjF9+tbwcdlSwsVM8sKB9bK5A9C0YZ7zKE Po2k/0mKV0Fj48RA1+nn3OANyRG8zRkqjOk9zo5OLzYdi/hLAVnNdFiwgKbhfWm2V8vsO6sFXIK d5LxhZZgT8dx+xIa2UN+z98ZmPuCXiEJr/sfmyymQ5YWlQWB4F959WcUgOtHSU6hOfHseYsrIek zBoS22sie78VH1cIb2A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_03,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 adultscore=0 malwarescore=0 spamscore=0 clxscore=1015 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160114 On 15-May-26 5:02 PM, Konrad Dybcio wrote: > On 4/30/26 11:20 AM, Sneh Mankad wrote: [...] > > $ b4 diff 20260430-enable_wakeup_capable_gpios-v2-1-8c26ac795318@oss.qualcomm.com > > [...] > > > ## drivers/pinctrl/qcom/pinctrl-msm.c ## > @@ drivers/pinctrl/qcom/pinctrl-msm.c: static int msm_gpio_irq_reqres(struct irq_data *d) > + /* > + * If the wakeup_enable bit is present and marked as available for the > + * requested GPIO, it should be enabled when the GPIO is marked as > +- * wake irq in order to allow the interrupt event to be transfered to > +- * the PDC HW. > ++ * wake irq in order to allow the interrupt event to be transferred to > ++ * the PDC/MPM HW. > * While the name implies only the wakeup event, it's also required for > * the interrupt event. > */ > > This is not what I asked for. > > Instead, please focus on explaining what skip_wake_irqs is, perhaps under > what conditions it is set, and how that differs for PDC vs MPM > I raised v2 in reply to Maulik's comment. By that time I had not seen your reply, apologies for that. Will raise v3 with added description. Thanks, Sneh