From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACC2130DD33 for ; Wed, 29 Oct 2025 07:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761722450; cv=none; b=b/1OhYG60T6DCkLiDxjjyH/sYmX0ztkwYr+giWyUK5j3YQDhVrPO7TZVIxq8lf/eco44lcU32CT2vc9JT5+JOVV+SHiGeDvuGJ5KL5k36dFu8WqKqhLbKpJrgrTGxzhSdVwQfWY3t4J32F0U1trrcXm4nJThp+HkLirBvbiFFwo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761722450; c=relaxed/simple; bh=N66Eu2MTSLX+DQ9Zs5DkmDvPkU3PMuJAmFe6mAPnt5w=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=dQ5Bg2SOryIbIh62Uv+N//Ko3CEcrVJU0cAeQpWeZnDzY6R/uPmZtdulMjkshJ4qRFhc/d9xHMiuHA2ijq60+ziwqSd6YZVes7sTPH3WLXEHhaNDlnIs48jpQZPSqCqWnpOQ4sA2NAHaexUrYsnaeq9noOWsmXnTWPaGqLYAAyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZZbVftEv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fWEUybXd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZZbVftEv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fWEUybXd" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59T4v7WH3755502 for ; Wed, 29 Oct 2025 07:20:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TQ2ob1Q25E+q3i1KkwW8M/itQjEOKbmijOezq34bQak=; b=ZZbVftEviMu2mgWY +mwHbkjjS7+8iQTtnJkLyKkkVx6dmLUFmV72u2PWtIekmHNbivgyM93MnIypnNfk MPm7oEYB+/bCZuoVPDXZTjmPxtz2RolhJeqieekYreAXpNPbudjmVHCtZ8UovkP4 F9Q5RMM0qWvqMrZBAOfxXQHVKun7eUqllSRIJiLsp4GuEpwoKDOc2YwdaavrQO+Y TO02J/1n33cm0PjW0vrtYPYZjq4iFQbFHk29McGVQ/stPA0WBipRnhQVMp6FXLkL Df4T5FoLgyEJdyhvKn3sgGlN1RZa5yHHABKzdhM8C+oW920lUxxYjRPcMVgyiXC9 Oij4ug== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a34a0hjky-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Oct 2025 07:20:47 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b55735710f0so11331463a12.2 for ; Wed, 29 Oct 2025 00:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1761722446; x=1762327246; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TQ2ob1Q25E+q3i1KkwW8M/itQjEOKbmijOezq34bQak=; b=fWEUybXdX12L7rp3bU7TNK3eOJ237YA/FzkNnSKRqYBl+VSAHzQ2F6wcXznCMJxlw6 uXcPxwZAOEPAKSvTqwQMip249+yxptomFvtlJbuK8q5oQXIzdthsUztqdAkeVMoTtjXj w0sXza0fysjoOEIzhtOYNd6SCs5UE3us0oe/lNfS0MoZw0KBbc1YVI3nwjoE2ZGx3zYA 4KMBLp27hc3wNxhSathcZcgCt0WcGgyiLq8df++W7IiGL2TzA8UGdTe7FjKXOvfEbI21 2bovH0JQekv6dYTYAgtO21vZai8i5d4o9JF2sCaVS5w3xHIMDOSeEUI4KlOUTVJOE9Rb SsuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761722446; x=1762327246; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TQ2ob1Q25E+q3i1KkwW8M/itQjEOKbmijOezq34bQak=; b=EfdX4L+rB/AnLhn/Ap94d+jrXFCI8Wv6n3yeAbyL4wUbOhk/PlG8onfaQccfl8SaAS TYS7THwzuhr/FYSSwUzj4cihFeZeeX11CVgv9Z2QseTrdRnRgQlsadr90G1kdrRXUVW/ 7otWUG4sT9sLMROSxujPMFZU9OhG3f59Lbz0UtU7VY+5I6lyD9jIwv1GsD4+HuTcXUYK HB2k1pm0BsHQxt+KbkkOewwcFyqEMMPXJ3K8cOItAJNH1L5/uduUIHEUgKRH/zfxtdmI vW8tfRTsTPjUYZC7EFsiZlRbTO8TgINixoOgULeYKw7vZrjyTv9I7YkTvDl9tEHllDzC XwTg== X-Forwarded-Encrypted: i=1; AJvYcCUuMX0Mq7PoSK258UOA4HKK0b0kj41ftSO7hzzAK7Niibomaw2exINW3UwPaAzDni5m3FFNFgGv+E3or6o=@vger.kernel.org X-Gm-Message-State: AOJu0YwSWMY8VPoWV3FNsRMhoJb9d368tEZ7EtJXumCucATA6cvQR/fj wqYQNvwCG7cX5kX61I6PSsl9v0mx/jWME0JT9GychGg0sVARYvYLeEV80RZfx7qE6otVUFTriiI 6S32OKByg363YvxckiijMU/jBtC9jW4KCaPHs3BVio65Dmj/e2SNWVy7oYzVJ69sJ8EA= X-Gm-Gg: ASbGncsUQk7aqwxd/cw8H95EwvHh1XtmKLubU2wgSRyjrs2lDcwt0H+p6VglqFsDWCJ AwOAXSbDPDjlyBIpP76XsZGQKcuR0UoO7uhg1rOIV2Y5ocSCmuh7EFXm4w4/GhHma6nkgia9T5p MyW/5eLZAdgy/HlmFJqblag3HHRwxi4WpDu6T6xbFl7fhWQV1sZGPMqOCkD5lGiI4bYtgtqVAOQ b0PaNpO0WcNljIkLRfW1Hss0eqp9JGq6pHZvQhU4GbBVaKA3kHAdcWEkSEIMA4z+JIT9Vc9q691 nCmyPpJKb/fDkBFUDJ4LBzl31DjloIEp2szKPKClDbsssjXRigza/AKDKHUZAyUTVOS7vwq2xo0 mRf9jgGlc7q56TKTYuDdP0A3lwaEloNw= X-Received: by 2002:a17:902:e88b:b0:290:55d5:41dd with SMTP id d9443c01a7336-294dedd4150mr26419375ad.5.1761722446389; Wed, 29 Oct 2025 00:20:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGu4F4skDWr434hRSD7TfTtLDsEjdVA7130uO8k1G3iUvZMYEIJ7UgUB9J+ouZB2JbLsyGZEQ== X-Received: by 2002:a17:902:e88b:b0:290:55d5:41dd with SMTP id d9443c01a7336-294dedd4150mr26418955ad.5.1761722445769; Wed, 29 Oct 2025 00:20:45 -0700 (PDT) Received: from [10.0.0.3] ([106.222.229.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29498e41132sm138212415ad.92.2025.10.29.00.20.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Oct 2025 00:20:44 -0700 (PDT) Message-ID: Date: Wed, 29 Oct 2025 12:50:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v6 3/6] media: iris: stop encoding PIPE value into fw_caps Content-Language: en-US From: Dikshita Agarwal To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251028-iris-sc7280-v6-0-48b1ea9169f6@oss.qualcomm.com> <20251028-iris-sc7280-v6-3-48b1ea9169f6@oss.qualcomm.com> <87b3871d-88b3-2851-07ee-db8f2ca1d58f@oss.qualcomm.com> In-Reply-To: <87b3871d-88b3-2851-07ee-db8f2ca1d58f@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=HvZ72kTS c=1 sm=1 tr=0 ts=6901c04f cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=L4UNg9I9cQSOxNpRiiGXlA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=M8_A81qNnP5ImZZKVzgA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: daJAeWL8AaFkj18KIQt8B7sy1nJowjEG X-Proofpoint-ORIG-GUID: daJAeWL8AaFkj18KIQt8B7sy1nJowjEG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI5MDA1MiBTYWx0ZWRfXwSx+b6BH03Rx epwrsyR50nnRmuQEBdO5toVtK76CgxOWJaIjMXfkEARQTZ7VuYW0+yrAXNS+9Wdk5jBb8RZ2iKU K1BZIEeBJemtYB+yJMpa7jZ/oNHb+/GjxVwSSFbmywN8L7CS44I41EWqXfnwTl1bg9FkAX8Jxoi uLI0wNjOSTYBNuGFBL+nOHghEug2eRFu8thNTk9Um55DqaLkjf75nr80iMU5I7nJ5E2bOnL7Vn/ o50+mHtuNWhhU3zkZkVOjA41CqnJucVJixjSKEyFpZVI+1t1eksXQmICCZjmZzr9IH9w4qSARSJ 3OfV9PMPastgRkSJeLgdB9OltYER3ERicsVSr7gy6bEx2/Lz/rYupG1lW0BinZFQ7O21NseB7Ja 7NL31SPWbwPGlIuIW0GHXJjipvEj2w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-29_03,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 malwarescore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2510290052 On 10/29/2025 12:42 PM, Dikshita Agarwal wrote: > > > On 10/28/2025 5:16 PM, Dmitry Baryshkov wrote: >> The value of the PIPE property depends on the number of pipes available >> on the platform and is frequently the only difference between several >> fw_caps. In order to reduce duplciation, use num_vpp_pipe from the >> iris_platform_data rather than hardcoding the value into the fw_cap. >> >> Reviewed-by: Konrad Dybcio >> Reviewed-by: Vikash Garodia >> Reviewed-by: Dikshita Agarwal >> Signed-off-by: Dmitry Baryshkov >> --- >> drivers/media/platform/qcom/iris/iris_ctrls.c | 16 +++++++++++++--- >> drivers/media/platform/qcom/iris/iris_platform_gen2.c | 4 +--- >> drivers/media/platform/qcom/iris/iris_platform_qcs8300.h | 4 +--- >> drivers/media/platform/qcom/iris/iris_platform_sm8250.c | 4 +--- >> 4 files changed, 16 insertions(+), 12 deletions(-) >> >> diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c >> index 9da050aa1f7ce8152dfa46a706e2c27adfb5d6ce..c0b3a09ad3e3dfb0a47e3603a8089cf61390fda8 100644 >> --- a/drivers/media/platform/qcom/iris/iris_ctrls.c >> +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c >> @@ -313,13 +313,23 @@ void iris_session_init_caps(struct iris_core *core) >> continue; >> >> core->inst_fw_caps_dec[cap_id].cap_id = caps[i].cap_id; >> - core->inst_fw_caps_dec[cap_id].min = caps[i].min; >> - core->inst_fw_caps_dec[cap_id].max = caps[i].max; >> core->inst_fw_caps_dec[cap_id].step_or_mask = caps[i].step_or_mask; >> - core->inst_fw_caps_dec[cap_id].value = caps[i].value; >> core->inst_fw_caps_dec[cap_id].flags = caps[i].flags; >> core->inst_fw_caps_dec[cap_id].hfi_id = caps[i].hfi_id; >> core->inst_fw_caps_dec[cap_id].set = caps[i].set; >> + >> + if (cap_id == PIPE) { >> + core->inst_fw_caps_dec[cap_id].value = >> + core->iris_platform_data->num_vpp_pipe; >> + core->inst_fw_caps_dec[cap_id].min = >> + core->iris_platform_data->num_vpp_pipe; >> + core->inst_fw_caps_dec[cap_id].max = >> + core->iris_platform_data->num_vpp_pipe; >> + } else { >> + core->inst_fw_caps_dec[cap_id].min = caps[i].min; >> + core->inst_fw_caps_dec[cap_id].max = caps[i].max; >> + core->inst_fw_caps_dec[cap_id].value = caps[i].value; >> + } > > The same change would be needed for encoder as well. > Pls fix this. > Pls ignore, PIPE is not added as a CAP for encoder. > Thanks, > Dikshita >> } >> >> caps = core->iris_platform_data->inst_fw_caps_enc; >> diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c >> index b444e816355624bca8248cce9da7adcd7caf6c5b..fb3fa1665c523fbe01df590f14d8012da3a8dd09 100644 >> --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c >> +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c >> @@ -160,10 +160,8 @@ static const struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = { >> }, >> { >> .cap_id = PIPE, >> - .min = PIPE_1, >> - .max = PIPE_4, >> + /* .max, .min and .value are set via platform data */ >> .step_or_mask = 1, >> - .value = PIPE_4, >> .hfi_id = HFI_PROP_PIPE, >> .set = iris_set_pipe, >> }, >> diff --git a/drivers/media/platform/qcom/iris/iris_platform_qcs8300.h b/drivers/media/platform/qcom/iris/iris_platform_qcs8300.h >> index 87517361a1cf4b6fe53b8a1483188670df52c7e7..7ae50ab22f8c577675a10b767e1d5f3cfe16d439 100644 >> --- a/drivers/media/platform/qcom/iris/iris_platform_qcs8300.h >> +++ b/drivers/media/platform/qcom/iris/iris_platform_qcs8300.h >> @@ -146,10 +146,8 @@ static const struct platform_inst_fw_cap inst_fw_cap_qcs8300_dec[] = { >> }, >> { >> .cap_id = PIPE, >> - .min = PIPE_1, >> - .max = PIPE_2, >> + /* .max, .min and .value are set via platform data */ >> .step_or_mask = 1, >> - .value = PIPE_2, >> .hfi_id = HFI_PROP_PIPE, >> .set = iris_set_pipe, >> }, >> diff --git a/drivers/media/platform/qcom/iris/iris_platform_sm8250.c b/drivers/media/platform/qcom/iris/iris_platform_sm8250.c >> index 66a5bdd24d8a0e98b0554a019438bf4caa1dc43c..805179fba0c41bd7c9e3e5de365912de2b56c182 100644 >> --- a/drivers/media/platform/qcom/iris/iris_platform_sm8250.c >> +++ b/drivers/media/platform/qcom/iris/iris_platform_sm8250.c >> @@ -20,10 +20,8 @@ >> static const struct platform_inst_fw_cap inst_fw_cap_sm8250_dec[] = { >> { >> .cap_id = PIPE, >> - .min = PIPE_1, >> - .max = PIPE_4, >> + /* .max, .min and .value are set via platform data */ >> .step_or_mask = 1, >> - .value = PIPE_4, >> .hfi_id = HFI_PROPERTY_PARAM_WORK_ROUTE, >> .set = iris_set_pipe, >> }, >>