From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f42.google.com (mail-yx1-f42.google.com [74.125.224.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31B1A3644CB for ; Fri, 10 Jul 2026 15:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783696965; cv=none; b=bZQWClnIArlu2EKxEGDD7gw4v77iGfTKXJ3RNisrv/1zR61sWfrxZBMMXqQZdXgL4Me/SgB4qsmhQysEch0HHj5/59LCXA/0c2xRAoFBLWebysgjaeFHh2OOHCY1sAZ8SkMlPhkq+NqAOpiB/+QKVe+YLZ/nJ1xbQdGcC8zyv74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783696965; c=relaxed/simple; bh=zEAiE3kPlRXxoM76UgYmzsJQQa17QofmTRzN3CaoHi0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C5wWp3EaLGBcjw8byeOg+9wLjzmdigdas53xNiyLVp7Zzs44KPD18CV1h+BSzJS8+tMsp1+52OyYegwEaJC3FRy/ysKzWiw0+qPPC5UBzcWGj6B4MIRckJWhVFXujVpk9rnbu1ufIp/2vq5TtEJ0Qg/FSooNHVEZcTXwoWFg6gY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=fuDX4wiC; arc=none smtp.client-ip=74.125.224.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="fuDX4wiC" Received: by mail-yx1-f42.google.com with SMTP id 956f58d0204a3-664d7863920so986436d50.0 for ; Fri, 10 Jul 2026 08:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783696962; x=1784301762; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+fq+XFsMldhTIedidEpRwBTF62wZYqBTX0O43nDV5nY=; b=fuDX4wiCvJl0OXReHuIkSDOXH13C9wSdo5jc3rUJGhIHNjZC54G8iViCMNtkrIC66+ yJhaDgHU5p05Zspaff+9tIEwvxFVlnA1BFBPQLSB5yi/ydXo+haTXWeqgIUaZ7gXlu4J fpEdX7VvPkEciL+0wUrnIn5Q3RLnCn2WFzfmo4icoe7qPivKTzJRtQ+5Z8ZIyC7skTC1 NTmMsAi7rkcdK3MkbLEdwJ1+i93sUhDnkujKvpKWt07UI0Yu//NH1340mgOIS4yWDIbC 7tW1yZXeI/U+1FFBkyLXWvnPIqGPmS1RK2XaFOuor2jzixEef+KNpKOgf5vBtbW3dS3Y FCvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783696962; x=1784301762; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+fq+XFsMldhTIedidEpRwBTF62wZYqBTX0O43nDV5nY=; b=fC/Ako4aZt+oBfs46j2wEp9IId/VVRwmbqq1+IiJ7I2SqmZQyAmpOiTN5S3Of8T5Km 26EOTM8rA60ZbTv+3Fh7B37+0l8AYeV4LLeu6jP3/1WJbHkam5bnlkbs4Ix5y6EJPt8b o4dzqP/vsEpmFqamq6lOpP92dSdNDX1PHF8wqiZBMQxYpZqN55UiuLE4IcP/MLIyQ6kE 9qFdoaQ/Ivsv4V23exhAHsbWq7FVwoautSdC2Zt63n+mHyS2QG1WEELSaTHGYFEg2kzR kj8yOeqUOHpzETVgpEQPDoyIbuDkoNVqDjXlByH9m4/zcSNfKBznNi+oADy+4zX3tjfu /r+w== X-Forwarded-Encrypted: i=1; AHgh+RpIeoAFDoSEO9S93DD53CSi5fkAG0+6mbwGR4QkVcSrTA1KIJawCZy8kHGvPa4HOsEmd6rFsD/0BN4lsxg=@vger.kernel.org X-Gm-Message-State: AOJu0YzgSlOXV+ZbejN4Ly5Lvq18lBL5rTS3mhhQrl3aJZaF8hMxTR9f /Q2UpZRASjxti5PU5/NIZs6ftz5I85W0g2Gr+zLFwLB6ikfCddW5W1niV1gAp7gfSSs= X-Gm-Gg: AfdE7cnhO55lRzjysMGoWNIHr+qQkAaIH+JTeMK8rADI9AusLPJGJBEOD3xGZsrb29/ AcqRan5Us6dzFM7DKe77fSZIUkHUIryPY18It03pf2nb9/pBKkL76w8jH/Aos31bc7i5hjFf90X JY8ev6f5b6yALg/MogVs1WNRE/DdZqchINHm1xd/971AXLDjC9uB+N//y6WwMDnmA7idEedsN2k vfp0n0vcCOv0S6bJ5bvbHXTaHQRRIkkF6r3GHhSHCFLeeLIQXBE9W/21dWVTPVumdaLiqvd58DU asIs5NyMkMyjOtOpDu1xZZK+SmsZpEQkahamUMWmE9hYANug2GdgiYLm03hJA/pgBssAzuxhgvr 0ehOEEvQaPqP8oW7EChkC5K4Xbt6OS4pVa4G/nJx2EcO6o+donH/u3OayC1YqjARZfMs2FMGOjb yxiOIVGPw1+ZhuyfjylA4YrnJqvQbdzSdvrmuJIm52WPKiozEuOugjRbMJvXtx X-Received: by 2002:a05:690e:c4d:b0:667:bb94:18d9 with SMTP id 956f58d0204a3-667bb94431bmr4012272d50.13.1783696961677; Fri, 10 Jul 2026 08:22:41 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:1b03:95c:fbd4:4d00? ([2600:8803:e7e4:500:1b03:95c:fbd4:4d00]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81e6c212f14sm47997107b3.42.2026.07.10.08.22.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 08:22:41 -0700 (PDT) Message-ID: Date: Fri, 10 Jul 2026 10:22:39 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: proximity: hx9023s: validate firmware size To: Joshua Crofts , Laxman Acharya Padhya Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Yasin Lee , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260710142212.52225-1-acharyalaxman8848@gmail.com> <20260710165400.00005108@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260710165400.00005108@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/10/26 9:54 AM, Joshua Crofts wrote: > On Fri, 10 Jul 2026 20:07:12 +0545 > Laxman Acharya Padhya wrote: >> @@ -1058,6 +1065,7 @@ static void hx9023s_cfg_update(const struct firmware *fw, void *context) >> } >> >> ret = hx9023s_send_cfg(fw, data); >> + release_firmware(fw); > > Why not move this after the if? Keep the call/retval check coupled. Because the if branch contains a goto and would therefore skip calling release_firmware() in case of error. > >> if (ret) { >> dev_warn(dev, "Firmware update failed: %d\n", ret); >> goto no_fw; >> > > Otherwise this looks good. Feel free to add my tag with the v2: > > Reviewed-by: Joshua Crofts >