From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794403287; b=BESh/YqLvl99nozXxxOsvmoIniqZnsXFQfVHqdcXSLTAW80dvbz8ZZkaWAzFPUNaB3de 3ryfdn/Kk7J8YGov2nxzeLMUPGmYae2JBdcDzqenB75+5NXQckoyS1M9cPOkIuapxmEBL P4J80m/2oGQ4XtevNGKo9eTB9kmRobPhMOhdrr+t8ui0fL6BVZ2NMPy+cBeV4E78L5QY3 K18QUaKorD9HaOa3S4e6iGNJDsylgNpTA1uSCOdvHZYyBqA1ZBkyZ7e+8G6aZuG984IsT XfhHZkAnGq3uN6qpgJRILw/zwahINvty4jkCvDoKDVgRiBA7PhYT9WKE9ZIH08vHe7Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794403287; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=dYxHBapf5Ns2Ipf/o7jAhmU09g+jMSK+3koea8MpeCE=; b=L6VGedRk0PeSfef1tuR/6CCNa5P7SNsl4SFS65jmAcAIgSDca0HB27XxbR8IY9xru9Nc Pe7RDQHiyhaJIbqbqowU+saeCq0Wc3ht311PnUd2kgnO99c9QvaqMY1YaMamhfQbtAGpQ dZe6drDcdJ4ol8u7cgEC/JmUm9V+ywDcX3a8a6uGwS4QZvZgEIM1oEM1lABOzSzagMUJy mM8LUJxbrj4YnnknxIUJ/yDtl8EKdLLNUNMOA4G9sn+Z+ikc4uEPxcOHcaBr+owmKOL4O f68S9BwNP2tVtZOnDw4brYNPE2yLwrN6Ous1rKD5RME9agXhPUJhYrx2K27WsWwUFng== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LjgH0i2f; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37B84606A33A; Wed, 11 Nov 2026 13:21:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=LjgH0i2f Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBFA11F00A07; Wed, 11 Nov 2026 13:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794403287; bh=dYxHBapf5Ns2Ipf/o7jAhmU09g+jMSK+3koea8MpeCE=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=LjgH0i2fvLmOnGi+qt7ulRx8rRs8za3e5hbWcy5XsDkeAaXBUFfqojvjpulWvMfd7 xKr2SSxHaPqJCDrKnh7aBCcdvRBMB+/4/qfgzvknAVmEf6IlkDq2pAUUsv7R3+zgxB fDU5alN9su054lOQyyD/t4hbT4aA2eEsYEar4W/ZzTG5rmpD/lDHhA39th3MbPlDu4 NqRssrqKtk6rNNa291a2fbaOnYb1gRkFnLSUmapLchnTEDzekveNgJNTbMcV1TjIEX TZycMeSc/J14HHDx6+6v7oaNHYIML4DOGIcCyt+rtYHlNd7M16l8lFynqeSASpU9il jW/Nb4KGwtSJw== Message-ID: Date: Wed, 11 Nov 2026 14:21:18 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: leds: backlight: add Kinetic KTD3137 To: Daniel Thompson Cc: Roman Vivchar , Lee Jones , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org References: <20261102-6768-ktd3137-v1-0-b5b4f903c56e@protonmail.com> <20261102-6768-ktd3137-v1-1-b5b4f903c56e@protonmail.com> <_kyk4j6fx0PX5QqVrjAIGH-5fzUhj-fKhD8YT4F734mCOnQCDXui6wQB77AOka69_gblWOJN2SxzC5OSrH1lXiQeciLfVnWuPHS0JfaMKD4=@protonmail.com> <3bbc1c1a-0435-4cde-a1a2-a408bd7a794a@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/11/2026 13:41, Daniel Thompson wrote: > On Wed, Nov 11, 2026 at 01:11:13PM +0100, Krzysztof Kozlowski wrote: >> On 03/11/2026 18:10, Daniel Thompson wrote: >>> On Tue, Nov 03, 2026 at 03:21:45PM +0000, Roman Vivchar wrote: >>>> >>>> In the driver I've used devm_regulator_get_enable(), rather than _optional(), >>>> since my understanding is that the non-optional helper is a standard kernel >>>> API for required supplies (with regulator core warning and fallback to dummy >>>> regulator in case DT omits it). >>> >>> That dummy fallback essentially makes it optional. On a board with an >>> always-on supply then there is no need to include vin-supply in the >>> DTB. The driver will work just fine without it. >> >> There is a need, because this device needs a supply. How you describe >> that supply in DTS is a different story - can be always-on, can be >> missing etc. > > If it is missing (but listed as required) then won't a DT that omits this > property fail schema validation? If is legitimate for the property to > be missing then I'd view this to be a spurious fail It is not legitimate for the property to be missing. I said - it is needed. > > We certainly didn't list basic supplies as required in other recent > backlight reviews: > https://lore.kernel.org/all/20260529-topic-sm8650-ayaneo-pocket-s2-sy7758-v5-1-03aacd49747c@linaro.org/ > > Is this something DT maintainers want to see tightened up when new > bindings are introduced? We always ask for required supplies to be provided. There might be an exception, maybe such one was pointed during multiple revisions of above patchset, not sure. Best regards, Krzysztof