From: linmiaohe <linmiaohe@huawei.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, Martin Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
Andrii Nakryiko <andriin@fb.com>,
john fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bpf: Convert to use the preferred fallthrough macro
Date: Sat, 15 Aug 2020 01:48:18 +0000 [thread overview]
Message-ID: <f6ec0c0d37f54298956a63ebe1ebf234@huawei.com> (raw)
Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
On Fri, Aug 14, 2020 at 2:58 AM Miaohe Lin <linmiaohe@huawei.com> wrote:
>>
>> Convert the uses of fallthrough comments to fallthrough macro.
>> @@ -1794,7 +1794,7 @@ static bool cg_sockopt_is_valid_access(int off, int size,
>> return prog->expected_attach_type ==
>> BPF_CGROUP_GETSOCKOPT;
>> case offsetof(struct bpf_sockopt, optname):
>> - /* fallthrough */
>> + fallthrough;
>
>this fallthrough is not event necessary, let's drop it instead?
Will do. Many thanks.
>
>> case offsetof(struct bpf_sockopt, level):
>> if (size != size_default)
>> return false;
>
> [...]
next reply other threads:[~2020-08-16 1:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 1:48 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-15 1:50 linmiaohe
2020-08-14 9:16 Miaohe Lin
2020-08-14 16:55 ` Yonghong Song
2020-08-14 17:11 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6ec0c0d37f54298956a63ebe1ebf234@huawei.com \
--to=linmiaohe@huawei.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome