From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D33A4C77B7C for ; Sat, 13 May 2023 09:09:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233853AbjEMJJR (ORCPT ); Sat, 13 May 2023 05:09:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbjEMJJM (ORCPT ); Sat, 13 May 2023 05:09:12 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE0BA1FDF for ; Sat, 13 May 2023 02:09:10 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2ac88d9edf3so105632171fa.0 for ; Sat, 13 May 2023 02:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683968949; x=1686560949; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0XVnXZFvQEsqa79rEwn5T6CH1CtUAwGaKR7PKUSsQxA=; b=aVMq4tqniH5yF4T4yGJrOBgFXvLGdMrWlb0GBvJH80rQXMatI3bZmWpSRBTq4v4xc+ c9CxLS9fN4j4om/4dP+q/JXrFqQ04A2BD4ZxpGV1JqMUIyfDEq1yOtleTo+1N4IrhVIT I36J/Yz0dF5rZPPKr8eYAJBpwrshqL11+ROQowRrKv9Dd9hQbAYsZI0pX9dNJMtymzw3 y/6PPRZOwy3vZ3cIc2kybyyBna/Hh9R24QPfsjzszWuBgVWnA/AWgymA6eohTK/JDzYC N29jCrLNs2L4PvGpgpN10k4ZkMBNxwJa7x0UxZ+20gs5y6qt0dcOMJeH8d50Pq6/IZoz 5Yzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683968949; x=1686560949; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0XVnXZFvQEsqa79rEwn5T6CH1CtUAwGaKR7PKUSsQxA=; b=OikGo7By5BLhhf6+aPLadp6MxFtM6ejxRzdBL7zWzCo8IU7BeuE15RKWFGn+ckMYf8 sS+eOgxAkChhPZNdaH2jPQTo9o0agJU/x6IMWFQ3HQt+v7LMNRuuWqzAss10MKwTvsI0 myCA6tlV1rhudjx7dcRjx8vu3LGHcwyg4w8RUwRUYpWcQPnxOk5hkvbakAzvbEim168K MAM9Ecu5moClt9bgQLAh5gvDn3GS5akbNDyf3COXwXQc6QBrYEsxJ3jYO6j8oSMJznLq GyqHthP06Er1DbjnTPOnKGMPfyKTJJUHpGjkjl+UQPhuL8u2FH5Z9dnDb/lCyYy8gebg DiCA== X-Gm-Message-State: AC+VfDzKf/P7d0oTgCDq9VlQaVwpkZqRosUF0y7qCWR4W6c8/eBLUAh+ CS85vxx0i8FwCfgfIS9Rt2Udmg== X-Google-Smtp-Source: ACHHUZ4lx1tK0JmxHrSwGsh+USwsUSWqrEyW+hhjDwc9ajC0E7CF+X+qUy5/dyk9B2CzwLh4gYGmDg== X-Received: by 2002:a2e:2c09:0:b0:2ad:bb53:8b9a with SMTP id s9-20020a2e2c09000000b002adbb538b9amr3370782ljs.20.1683968949108; Sat, 13 May 2023 02:09:09 -0700 (PDT) Received: from [192.168.1.101] (abxi58.neoplus.adsl.tpnet.pl. [83.9.2.58]) by smtp.gmail.com with ESMTPSA id v21-20020a2e87d5000000b002adb10a6620sm1369608ljj.107.2023.05.13.02.09.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 May 2023 02:09:08 -0700 (PDT) Message-ID: Date: Sat, 13 May 2023 11:09:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Flush RSC sleep & wake votes Content-Language: en-US To: Bjorn Andersson , Andy Gross , Bjorn Andersson Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230512150425.3171122-1-quic_bjorande@quicinc.com> From: Konrad Dybcio In-Reply-To: <20230512150425.3171122-1-quic_bjorande@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.05.2023 17:04, Bjorn Andersson wrote: > The rpmh driver will cache sleep and wake votes until the cluster > power-domain is about to enter idle, to avoid unnecessary writes. So > associate the apps_rsc with the cluster pd, so that it can be notified > about this event. > > Without this, only AMC votes are being commited. Ouch. Should we make this required: in bindings and add it to all platforms? > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Konrad Dybcio Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") Konrad > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 8fa9fbfe5d00..5c68f2182c2f 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -3982,6 +3982,7 @@ apps_rsc: rsc@18200000 { > qcom,tcs-config = , , > , ; > label = "apps_rsc"; > + power-domains = <&CLUSTER_PD>; > > apps_bcm_voter: bcm-voter { > compatible = "qcom,bcm-voter";