From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751733AbeA1NDu (ORCPT ); Sun, 28 Jan 2018 08:03:50 -0500 Received: from mail-bl2nam02on0070.outbound.protection.outlook.com ([104.47.38.70]:43712 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751640AbeA1NDr (ORCPT ); Sun, 28 Jan 2018 08:03:47 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] drm/radeon: adjust tested variable To: Julia Lawall , Alex Deucher Cc: kernel-janitors@vger.kernel.org, "David (ChunMing) Zhou" , David Airlie , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1517063295-16648-1-git-send-email-Julia.Lawall@lip6.fr> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Sun, 28 Jan 2018 14:03:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1517063295-16648-1-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [2a02:908:1251:8fc0:4c6d:7233:b7e1:3b88] X-ClientProxiedBy: DB6PR1001CA0025.EURPRD10.PROD.OUTLOOK.COM (10.168.69.139) To CY4PR12MB1304.namprd12.prod.outlook.com (10.168.168.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: eade21c7-3f30-4f66-c791-08d5664f8f2c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:CY4PR12MB1304; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1304;3:1KNnaTSKchExqslKYjDPqVScqtX7yK7LH7TBJththe4MVmnCi/EnQLkF4OuvWzv0IswsCPpNUHSlbkfL4u9sKDTksSwhNNsLp8ue6e2nbIL6DlB099h4VvAjNIeHLJ2Il/Dn4/GXe5c86oKRm8mlbtVb3K4H3ejSPOeXiT+rZjjSFt2ODDMPCwlvoKpoT4EM6b5Cpk7wj6L2ucB/zWR48NYYRJBh5+VjkhjsPrDygQxLDXklpC8cJR4ZhQZE0e6c;25:nLSboumblgjbMUMNQ+PBNEUSRY23UZwKNEkzVdOXJG35+WfBxM6zzpn+i8casltoVDhUhRxpiYqkwXhRK3TP5TGOXSBnXI8H584S3n3vi5M4WnNr9xvsJWPlNQ5PGF2KlBWkJzU97WzBLtei148hZp9MKGLcqJFJhXqgBMsHzg/PGVy47xKewcKQsub5Bm6a5yXmAsNbaUFo00pHD6qRG/toZNIdO3XZwIux75l1rniZCXrn7JtQkZGsbMQDrArp+rmU4KRd0YCtkSmGSE0jv15CQwq6ZSpyO6nfmQHLWqZHrsQRiC2cSrfPDN+ZKYapHoxgbw8tpNcs1voFfth4rA==;31:wgjEBPwa945H+45ALS+2imm9Qx18aGxlGMhtGtuiijDtAGvI6va1XaxCuCw0itO0wT8ms99nzAvUp1jg9wV6UUATxKHCzq4jPZ3CfYKpuZMUECrEZJ2q5Ntz04XhW2DDwMH6bxTyFd9FMtZeA599T+QWqRO8ByJzGL5JdEcD3Q+p+PNyS2SJ0WFzldFSQzus/yUMA0ZONkxtW35RVFT2s/497lpz8vt74xskX1yfjb4= X-MS-TrafficTypeDiagnostic: CY4PR12MB1304: X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1304;20:BilwrkyHsUAfnR2i8iy7/r91HpeQxS9YfXj3azvuU6CdKHhQjitGD9REhT5q8DcpjhNj5q1eIVbfrh4849lQ8BLAEWR889Zbn+SqykcOaUbLicbIpXiSzBDjmvBNfbd0MjRKNG5NVb2KbXHhAO71qbJTCveeap2erv8UlDAW7Jmmhv+owqgJ6jgCBCH6Ur+W+XSOtZYb2ErpiHmZGbanDJQMvWPUy6w4s8t4sWF7I728ZxAqLrOuI+p5rGGQSXIfOLt5IfrAVaHUCDemrrIITXzXMCUmq0tQxOs0ozyy/aEGRUakIOO/U1nGn5ZtWsH6zjKxBbclgc9doKUyH6cAlv+/xrP98Biw84s0mw/N1HdGGVnFRRM5qZRimzm60G+eZBegSU7ooUaNzhxDUCYyQLOrq7xFDEnA55apDN+fVNSjvIboUiRbPmnv5fvKVTuYfkO+xubOI2wmUX1vxkYtofcj19s0L3tB85PWDfbg9U5adhrFXWTQ0qNRZkZhQD2v;4:0SNrCxZeEt32WUaE4YxYyufmqIq96x75KPgg/U4WgFDxSK/dSvE7KugV902/gbC0R4Rzw9WPVddztVhnHeh8/6a0u5JigntCYnMqwU+poP06jTLjs0ektH8qKmW9NsK5IqZnzUw8PjDnxjaPNzfaS9DmUGUoajGvfwMVK8sCuVS+UFSPLozc+PQYqBrB3LGMgc2RKOrTPIXuVwmtP1zi9ywhaEUxXJ3ECFzbTH/V58o3UtMP09VCtXYl8SxYOGS8+9l5A+dlosMCz3I23Nn9sQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231101)(2400081)(944501161)(6055026)(6041288)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011);SRVR:CY4PR12MB1304;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1304; X-Forefront-PRVS: 05669A7924 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(979002)(396003)(366004)(376002)(346002)(39380400002)(39860400002)(189003)(199004)(229853002)(50466002)(7736002)(59450400001)(2950100002)(52146003)(16526019)(2486003)(23676004)(52396003)(186003)(230700001)(6486002)(478600001)(52116002)(76176011)(5660300001)(6666003)(25786009)(305945005)(6306002)(83506002)(386003)(6636002)(6246003)(65826007)(65956001)(67846002)(53936002)(65806001)(47776003)(97736004)(68736007)(8676002)(2906002)(31686004)(86362001)(8936002)(36756003)(1706002)(105586002)(72206003)(58126008)(106356001)(31696002)(6116002)(110136005)(316002)(64126003)(81166006)(4326008)(54906003)(81156014)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1304;H:[IPv6:2a02:908:1251:8fc0:4c6d:7233:b7e1:3b88];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxMzA0OzIzOkRIaGdVRTBLL1JDTW43UE1uOUtnSFZFT1BR?= =?utf-8?B?SEp1RS9WV0MyaEc1cEljM2JLNHVmdmdsbklHeTdJajJoOFBmQTNkREdhK0dR?= =?utf-8?B?MTBWRlkyQ1NWVlNMaWhBUGVXblE3YzlPQkd0YVB6QUNvYTh2Y3NEY1BGZ243?= =?utf-8?B?bTI4V2xnMXVXQUd3cWo0cDJsWW1jSEdkKzFRUlZ3YlBubFFmT3QvMkUzeDBO?= =?utf-8?B?U3NxaUVlTzJPL3U0M2loSlNtRlNaMDBaa2JiOVNOZUQ5eS8rZWJlSWI2NEZi?= =?utf-8?B?bXhQMWt1UHBEWG04NncyVVY5aXdrRXh0WDhaVGdLZXBSN0dMdW1VS3Z6TjdM?= =?utf-8?B?eVJkRzF0czhTVzB3VGVCNVRpcXh5cHh0b05WSE5Lbkg1VUFVWmJPSEMyQmlq?= =?utf-8?B?Uk1OOGh3VDcwcXVzODFnbWE1bXlqcEUyRUZKS0syNnh4Q0VVdTZiZzI1c1lO?= =?utf-8?B?UW5UVVdNdC9OK2hLSTVybDJwbjhCZUhCYzVJdW95Y0lvMUo1Y3Z0bWNuRnpo?= =?utf-8?B?cW9RdWZEWC9uYjhQcnZqSFA0U0EySjc4eFlhSUdSTUpCaHlJY3g0V3Y5ZlZV?= =?utf-8?B?VnErNElVZlJFa0lwNHlBL2dha2ZPSk92MURwcU13T1l0aXhLcG56ZHlRZThK?= =?utf-8?B?c3FueFVMdFY0V1VRS0hGOFJiaGhOdFpMdUo4dkg5NzEvUG1WaWI1aU85VHFv?= =?utf-8?B?MzhWUFJYVTE1OGxXMDhjSW1xcE16WlJPeEhhTkNpQVdHZHV3N1VMQnZOa20z?= =?utf-8?B?dG11cjJ3ZlRCVm5QZGNYRGRKcUo4UDFZekxORncrU0d1MHZIL3c0MGxNL29m?= =?utf-8?B?YmdYOTdsaFRRUkNTTkJMM2NWenhKeVYrZ2RjaFZMVmxvVW8wcGN6aEI5Y0lP?= =?utf-8?B?aWJ3Y083RlNzL3o0cFZoeXZNSlRKTFp4ZWFDT1YzVktQMTRtN21HemFIUXVl?= =?utf-8?B?ODFCby9lemlkcExLRXZtZVBPdmV4akM0emtzVHArK0ZtQkdjaTlHSG9XdjUr?= =?utf-8?B?VElXNzJ2TkhyL2ZuNUJyaDFFNTM5UmhCVm44MlJrODd2NVA2MnJJVUgvNkpV?= =?utf-8?B?L0ZhOHdYbnovMlloaGpCNUsydWlJcG9uNkg4L0pXS2U3bmRvTnVrRnlqWUZY?= =?utf-8?B?Q1VtVGdsR2JXZ01vcy95MFlFTDR0RFJUY0xQU21vUlNHK3NJMHFFMnVuQ0Fj?= =?utf-8?B?WW9scmQ4S1o2TW4xV29mbkw5dUs2MzVNNTVuU3Vtc1RYcXhzMjBNRS9objF0?= =?utf-8?B?Qk5hZ3lsa29xUktKWWpXdGtya2tweHhoQlFHOUpNSFRHRGt5SFAwZk52SXZj?= =?utf-8?B?TDJnQVhaZmJpbmxseklUbWxpRlk4T1FDR3duaWtvclBiOVB4MDIzWGp0UXQ4?= =?utf-8?B?cUk0dkQvK1oxdEllRmtaek45R24yR29iaFZWSWd1akZ1aVNIcGxnVmNxNUd0?= =?utf-8?B?SkxONTFKV1Z5a0o5cXRFbjJKRzZaNzl1T2xoQ2NJUnhFZjhZZFdSM0pwYmNr?= =?utf-8?B?cWQ4V1VUV3ZycXNGbGdOYWh4ak9TMFJ1NlpKRER0MHViSUdueEU2alhJM09F?= =?utf-8?B?SzdLUm4xVndJaXJJU3JJVzJyd1QvSkVIVW1tcHBFa0tyTHRrNGZvZGNRV01h?= =?utf-8?B?QW1icFFsd2xOQUJodGlWNlRUdUxGQm1JbXptMHYrZjlROXRCOS9KT2hCVzRX?= =?utf-8?B?Q3Y0Z0ZqRkVONm96a2tRbFovYXJaaWpCR1MwTDdnSzUxMGJpYVkrUUdVTUhX?= =?utf-8?B?N2lKZEF1NmJmbklubkF5TUhpLytEamxRY2JzQWxnZndLeDVVbk5uZWZCZ3VV?= =?utf-8?B?ckJPRXRyQzN1YzgvSnVUM20xTzJZeFd5TUUwK2VKTlhqMWhDajgzSUxmejRy?= =?utf-8?B?a3FZRHVicjd4b0hTNzFpczNrQmlLQy8xWnp2QlJBdWRVanlIZDdmNVhlcXhN?= =?utf-8?B?Q1JjMG1jYTk1amtNK1I1R3NmTUJFTXE5R0kwNmg0L01HZDk4SGZzOGNTMUgz?= =?utf-8?B?bEFSNkVjSlFLVFJCR3dqenlMc3lYNkd0dTRRUT09?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1304;6:t11P9+6OdO+lQ0NvcMt7qITYlo9MzfHp6pffTL/DMatb0/Pl1kYr3KDfW5WiTl0DQLz61seoKJOCO187+X/g+9/MTcG9oN6wFL1TBfTG9sHQc2lAX7Hu8ustPm3qnnz8ImJ61yr2RnOiR7QDijZ0rHRyQpGYz3dwjxPhu76qYyYGTpc9xtJRcu/tuvGET4cvNm2nM7hss1aBwVB4qczzYz9IN4A4/Syc2tApH1DyZKziG0ycHr14LWZeSkIASH4tkuEUfFMmdQFkHS4/Wr0YApLW5PaOl2yBm2Ke/lNhy/mGPdXkQ83vS6vWu/6FjKSA9kjoDNc/qFYsHU4deymU1U9H/IjW0JfXCPdf0UhOAhQ=;5:/Ep06QtzNK+VOsS3tj2nw9Vp5ZitK2DQ87OkfLVz3lCbLp6BVqawrMBDFmg2q/gq3fK14yTZgoXvM1cmHZegjxzP1WrD6psRa1IF5NZ1Da2CmKSeo+6z1K1JAv213WByu4lczkECpa8gYKVm3Gx/KfIV9g46RF8jBMor/u2WMrM=;24:tkxlpORJI8qBV3T7kkOSYO+OII/PQUOhK9pRGMMkClWPXT/TP5kKS6MWfcLoAnb1EQTV80LQIhgUJ4aIshYeB5/9mmI00FxwBkWNahtWqh8=;7:agEGYUBQx6eZ1qMbNABPIeaW7KjQqk45ZsZ7Twkvc8E22yuxYVPD4aZHWSEapx7ktoZ7jjTvorBqvYa2dj2Wf/y/tgOqHDnhNvkiZB9fci1KEz2bzUPQdw7V3jA6TfjJYSlslJYmXsTiI5brNsSGaB3yoZrMjPBn9yU5LCWlQXs3o4S3ZPhK2Vp6nsSmrtPw8IjB5KXcoVVQbtDpa2byzVUXxRdGyNx1tPh6+SppW22Zn5A34GWvA9VKxhOkPtyy SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1304;20:LcUWo11WWyGm23i+/l7929mgKo59Dt7y+SsYrAXNaYrUIaGOrBCc7LLFa09GTWl8vjC7u626vFWMf1pcmWBL8Khykl1PgNqWbjbvwB6W34wPjQ+yFFxYOui5wJx4KxJNlJYfzRzt70XVnLFIdEpP3NN6K+KauHUAmGEN51yxnzMHiafr8X8dZYWDwLvPR16sE7XMw+WFy36sASeWpoJiLojSEa2+GebB5Q1bgNDNyOQcixx60rhEhpKD6F8NAUWT X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2018 13:03:41.7225 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eade21c7-3f30-4f66-c791-08d5664f8f2c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1304 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 27.01.2018 um 15:28 schrieb Julia Lawall: > Check the variable that was most recently initialized. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression x, y, f, g, e, m; > statement S1,S2,S3,S4; > @@ > > x = f(...); > if (\(<+...x...+>\&e\)) S1 else S2 > ( > x = g(...); > | > m = g(...,&x,...); > | > y = g(...); > *if (e) > S3 else S4 > ) > // > > Signed-off-by: Julia Lawall Good catch, added my rb and pushed it into our to-be-upstreamed branch. Thanks, Christian. > > --- > drivers/gpu/drm/radeon/radeon_uvd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c > index d34d1cf..95f4db7 100644 > --- a/drivers/gpu/drm/radeon/radeon_uvd.c > +++ b/drivers/gpu/drm/radeon/radeon_uvd.c > @@ -995,7 +995,7 @@ int radeon_uvd_calc_upll_dividers(struct radeon_device *rdev, > /* calc dclk divider with current vco freq */ > dclk_div = radeon_uvd_calc_upll_post_div(vco_freq, dclk, > pd_min, pd_even); > - if (vclk_div > pd_max) > + if (dclk_div > pd_max) > break; /* vco is too big, it has to stop */ > > /* calc score with current vco freq */ >