mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sahil Siddiq <icegambit91@gmail.com>
To: Stafford Horne <shorne@gmail.com>
Cc: jonas@southpole.se, stefan.kristiansson@saunalahti.fi,
	sahilcdq@proton.me, linux-openrisc@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] openrisc: Fix build warning in cache.c
Date: Fri, 18 Apr 2025 14:42:20 +0530	[thread overview]
Message-ID: <f6f4f410-4a0a-4ce3-bf41-413af39fd50e@gmail.com> (raw)
In-Reply-To: <aAIDfcZ4XD5f6mA4@antec>

Hi Stafford,

On 4/18/25 1:17 PM, Stafford Horne wrote:
> On Fri, Apr 04, 2025 at 10:39:22AM +0530, Sahil Siddiq wrote:
> [...]
> Hi Sahil,
> 
> Sorry for delay in getting back on this.

No worries :)

> I was working on getting this patches ready for upstreaming and noticed one
> thing:
> 
>      ---------------------------------------------------------------------------------------
>      ./patches/or1k-20250418/0001-openrisc-Refactor-struct-cpuinfo_or1k-to-reduce-dupl.patch
>      ---------------------------------------------------------------------------------------
>      WARNING: From:/Signed-off-by: email address mismatch: 'From: Sahil Siddiq <icegambit91@gmail.com>' != 'Signed-off-by: Sahil Siddiq <sahilcdq@proton.me>'
> 
>      total: 0 errors, 1 warnings, 102 lines checked
> 
> As you can see above the scripts/checkpatch.pl is failing with the warning
> about your email and signed-off-by not matching.  You can see more about it
> in the FROM_SIGN_OFF_MISMATCH section of the checkpatch[0] docs.

Ok, this makes sense. I configured git-send-email to use gmail because
protonmail does not work with git-send-email without a paid account.

> How would you like to resolve this?

Is this a warning that cannot be ignored? I can:

1. submit the patch series with another email address that won't have issues
    with git-send-email, or
2. submit the patch series using protonmail's web client (which might not be
    the best option).

I would prefer not to use "icegambit91" in the signed-off-by tag.

What are your thoughts on this?

Thanks,
Sahil

  reply	other threads:[~2025-04-18  9:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 20:01 Sahil Siddiq
2025-04-03 14:06 ` Stafford Horne
2025-04-04  5:09   ` Sahil Siddiq
2025-04-18  7:47     ` Stafford Horne
2025-04-18  9:12       ` Sahil Siddiq [this message]
2025-04-18 10:00         ` Stafford Horne
2025-04-18 12:34           ` Sahil Siddiq
2025-04-19  5:12             ` Stafford Horne
2025-04-19 15:55               ` Sahil Siddiq

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6f4f410-4a0a-4ce3-bf41-413af39fd50e@gmail.com \
    --to=icegambit91@gmail.com \
    --cc=jonas@southpole.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-openrisc@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=sahilcdq@proton.me \
    --cc=shorne@gmail.com \
    --cc=stefan.kristiansson@saunalahti.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®