From: Thomas Zimmermann <tzimmermann@suse.de>
To: Bernard Zhao <bernard@vivo.com>, Rob Clark <robdclark@gmail.com>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Jordan Crouse <jcrouse@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Brian Masney <masneyb@onstation.org>,
Shawn Guo <shawn.guo@linaro.org>, Eric Anholt <eric@anholt.net>,
Sam Ravnborg <sam@ravnborg.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Emil Velikov <emil.velikov@collabora.com>,
Jonathan Marek <jonathan@marek.ca>,
Dave Airlie <airlied@redhat.com>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] add KERN_LEVEL to printk
Date: Wed, 11 Nov 2020 09:51:07 +0100 [thread overview]
Message-ID: <f704e453-944e-2da8-4f0c-3c9a5c370691@suse.de> (raw)
In-Reply-To: <20201111083131.39817-1-bernard@vivo.com>
Hi
Am 11.11.20 um 09:31 schrieb Bernard Zhao:
> Hi:
>
> When call printk, set the KERN_LEVEL is suggested by the community.
> This patch sereies add KERN_* level to printk which do not set
> this level.
I have no say on the msm driver, but IMHO a much better change would be
a conversion to drm_dbg(), drm_err(), etc.
Best regards
Thomas
>
> Bernard Zhao (5):
> adreno/a2xx_gpu.c: add KERN_LEVEL to printk
> adreno/a3xx_gpu.c: add KERN_LEVEL to printk
> adreno/a4xx_gpu.c: add KERN_LEVEL to printk
> adreno/a5xx_gpu.c: add KERN_LEVEL to printk
> adreno/adreno_gpu.c: add KERN_LEVEL to printk
>
> drivers/gpu/drm/msm/adreno/a2xx_gpu.c | 4 ++--
> drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 4 ++--
> drivers/gpu/drm/msm/adreno/a4xx_gpu.c | 6 +++---
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +-
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 12 ++++++------
> 5 files changed, 14 insertions(+), 14 deletions(-)
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
prev parent reply other threads:[~2020-11-11 8:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 8:31 Bernard Zhao
2020-11-11 8:31 ` [PATCH 1/5] adreno/a2xx_gpu.c: " Bernard Zhao
2020-11-11 8:31 ` [PATCH 2/5] adreno/a3xx_gpu.c: " Bernard Zhao
2020-11-11 8:31 ` [PATCH 3/5] adreno/a4xx_gpu.c: " Bernard Zhao
2020-11-11 8:31 ` [PATCH 4/5] adreno/a5xx_gpu.c: " Bernard Zhao
2020-11-11 8:31 ` [PATCH 5/5] adreno/adreno_gpu.c: " Bernard Zhao
2020-11-11 8:51 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f704e453-944e-2da8-4f0c-3c9a5c370691@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=bernard@vivo.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=eric@anholt.net \
--cc=freedreno@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=jcrouse@codeaurora.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=robdclark@gmail.com \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®