From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013050.outbound.protection.outlook.com [40.93.201.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D00FB356775 for ; Thu, 23 Jul 2026 16:25:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.50 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784823945; cv=fail; b=qhaL7Y5nCczzX2xD149hGD6w6iFBxAOvL5j7QMjasnRZtxAQoUvOzvxJchro+2A3K5JlIHHF3BL0V5lf0pAUVdVWhblUptq05IdaTb+cZ0FVkS+NBIXdwJ7Gct+YA83Bafc6lyBKEDxGBgGA5T1Y5mmYijORjAO1sCI797NXL2c= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784823945; c=relaxed/simple; bh=YsI+SOQ0n+fdPNqD07lxoS0WkG2oj3qU8ymwMg6PAVQ=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=YZfh3hzK98hkrlqMsoDC5NSwIv/rpuRroZ3W61XO5KbkvJXhx1C5dDhu+gNfYJ97BKaUoVNCkoxkNp5vZtniY2SKK8zwCs9OFKacxknfi4YXk7Op9GXLfCqOHHIc5sLRB35ho1jjgCAbkKr7shkvIRanOi9SeonPN/cXF1d1OUs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=UguSbl8z; arc=fail smtp.client-ip=40.93.201.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="UguSbl8z" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IMDPF9DxCfGBHi+e1XwQU8f1R6ECHUXZ4U3La5JUpLyJatUd9zNYQZ6uHDHShHhcNWToDXAyi3QT4c0fvtXJ1/eedxfOSt9bfjqR9U4PGVPup6d2PRciOg5vlhvpN78endw+Jc+hfnjP2bnUtgsovCn71il2O4dLAbuyuiQcSYHdeESUq2R9J8XXbVuHxU9Gr1KMnTtvyN0z8ECpdpHUq8qAMDgJcTHVVbJqvv3cqtqbxfBBcmxSAXELllIJ3sWjgj5ziMWI52VXbhWkacb3B8XKuRVwtrQYapUQjhPGTWOiY+23FY92NRtyeo/7keWkg6HN+dJPBqfD8pw/10Hv1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nkSPXjSu5mksi6wyxjgO69eZdO6DveaESQDDIYVK+j0=; b=Ol2/miQNF1YYxu2AdO0jR4aPVBoWrsURa6F1FW/HL5u+wPuq6DwzSjsx1NkWkbNS6HU+xbBjAQ0nsYdHaSZ/7264s62wmq7NxyJY7zfSYBNkGYLK5a82t2+sCvhpSTbFFWrgRsy5Q2+FeioqifEb7UmrOrXn5PhMwIu8yx+UMyPmn+pF4qvKUkuWlrxzZyNHK7fWfyOKUqWxBs1dx0mYLFWq6h47Omi7tucOXdXWniOJZMh+iBFaGnqXrF9DXaAfxeAs7kmidChBzmKmiCAbOoNLgPViJIfZdwOAyjSj7fwF9vn9wDtnfPMOiAPToqaVXphfhhnBIRCJfDfMOwMhPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nkSPXjSu5mksi6wyxjgO69eZdO6DveaESQDDIYVK+j0=; b=UguSbl8zyy8aTuN+LPUSGYfnJ9lPJS8jqyMzp7gEuRVv27IRnASTHas/YZrTqPAyM/UngOpG4l/gdA7rDisuE4cP3E64+ng8/NqkgVrIo4Ed7tTTKJsrmaO9xBfapIx9VaJJPfWaswCCBYs6AaVKM6RWMFV25hYExLH7czfDa84= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CY1PR12MB9697.namprd12.prod.outlook.com (2603:10b6:930:107::6) by PH7PR12MB7236.namprd12.prod.outlook.com (2603:10b6:510:207::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.11; Thu, 23 Jul 2026 16:25:27 +0000 Received: from CY1PR12MB9697.namprd12.prod.outlook.com ([fe80::3a41:55a0:8203:596d]) by CY1PR12MB9697.namprd12.prod.outlook.com ([fe80::3a41:55a0:8203:596d%6]) with mapi id 15.21.0245.009; Thu, 23 Jul 2026 16:25:27 +0000 Message-ID: Date: Thu, 23 Jul 2026 21:55:20 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] firmware: xilinx: Add support to clear TF-A PM state To: Jay Buddhabhatti , michal.simek@amd.com, git@amd.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260723124841.2567827-1-jay.buddhabhatti@amd.com> <20260723124841.2567827-2-jay.buddhabhatti@amd.com> Content-Language: en-US From: "Pandey, Radhey Shyam" In-Reply-To: <20260723124841.2567827-2-jay.buddhabhatti@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN4P287CA0062.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:267::11) To CY1PR12MB9697.namprd12.prod.outlook.com (2603:10b6:930:107::6) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY1PR12MB9697:EE_|PH7PR12MB7236:EE_ X-MS-Office365-Filtering-Correlation-Id: d651e063-8ed7-4d6a-707e-08dee8d7014a X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|366016|376014|1800799024|6133799003|56012099006|11063799006|10067099003|5023799004|4143699003|18002099003|22082099003|3023799007; X-Microsoft-Antispam-Message-Info: GBwPKktKUrqIDHVrcsCDHThtL3cVv8k5kESdi5S0Qwp/2OlqzSQWguOXPQHRLlh5gnIDvCa1/6u20zpzqCVVrRAinNCfads09zwaY/hBUrjTz811mOTzsKe+7hnxuIMWAe+MQacVe3GHFNPP2R8dDGX3xvR1e+Zh/RqFYGbApHNdzgX4Es0AWTyScorxbsPtHzB+7m+9NH5rjMoZ2oaENyuLwATr2ImD538wmQnSqpJxVLeOrg2MWBwTtew4F/kfH4a/XA8n8qgel7rf0rtpoIf0ByeaWkxBbrUfOarSLbB/wK2evQRGkOr9jsD/wI2lQozRhB+1VvWMKkOfTaoG5utZ7Kt02248rIk0VHOUd4KNFVK/GgvahGV4HlYFcdhd0ylXwABS9vX03eGfu4TtTXcpQ7UAcIhpxMi2dw0Dp/x07nIuXkphiWcg38aFeDezSIolpMUBPstOtiXdeqHvy1uRqSasqpl22dJTCjFRgYxKsJZPikyeViOIOIkdD/7b1vrgVTdp2VR7EpM/SEJGFKfJuUniU92KqzmeR5aPtlfyQpmboMeKg4/QlcCoX1wu7ywIaqD3usc3oLDWYlqTnK3qizpYleIii4XW4S3Usbk1DtcXUN3fXBnWSqzKUID3wLdud5qSfirIqBf05YZdRLBNJtfqrMHM2HFHMum7Bcc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY1PR12MB9697.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(366016)(376014)(1800799024)(6133799003)(56012099006)(11063799006)(10067099003)(5023799004)(4143699003)(18002099003)(22082099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDRIbjNmSmhNZlNNSlY5MGZzTnFING4rbnhzWjcrOXdqMzdDd2QvaUI1YWkv?= =?utf-8?B?N1BJczRzWnVkMHVUb1M4V1VnM1dPeW0yOTRWYlk3NUppeEdkQzV3czN6a08w?= =?utf-8?B?Q1FWRzJXejE4TWVEU1kwQ3BtRGo1SlFudzFueURXblQrVW5TdU83alU0V2VB?= =?utf-8?B?YXZLenNma25kMVZIWFpGdFppTkJZWW1qdUh6Y2EwOHJUZCtrZVhIcVNtM1Ru?= =?utf-8?B?T2p0cXJiNlZzK2dhSXNjeitUbUZnUXg5b0dLS3RpOFRSclBxMEJGMm8yZ0VD?= =?utf-8?B?dUNrRGNNNGFmMjN0SUZGTmhxbDBXK1pkTGJWMVRrKzhNVXE5SmlSM3BnWnZU?= =?utf-8?B?QnRtZXYzajZTaHZNZHk4OUI2UFdJYmc1WGtRK2JZTmtNOGM5Z2FGc2FVRUlL?= =?utf-8?B?VFRPTElkQkhMY1RLeHYzRWw3aXU4b3poWjBhQ2pRTGFjeHAvV3ZsMlZTbDQx?= =?utf-8?B?bnBiQWtld0xwWkRYQU84eVdYVW9GZjdtcHpuZUNHTzlUblpQekMxdm9DenU5?= =?utf-8?B?N0pDM1RIQlR4WnJJNzZYdDhST3NpN1YwQ2toMC85WklGeXhuRVFHd1IzOVRk?= =?utf-8?B?ZHhLbVBkVHpwaEw2SEgvODk3MjRVM2ovTWg4Qy80M0VXamJaQmNrWmE0R1Q4?= =?utf-8?B?R2FlejAvNkEwdFdJQmdTTnA5UU5vdHVNbHhMS09zNTZMdTBlWEpKa3dKYVYv?= =?utf-8?B?MnNSaTNDZTZ3ajZaMGl4L1NUeGhmeXhIb3c3aHNwbWlqOGZZR3ViWWw0MDhz?= =?utf-8?B?bkRCWnJZc0ZyamdsSlhmTEJmNzI3cXNvRUh3Q0tDUzlScDk3b0pWcUYzV0dp?= =?utf-8?B?NXA2OTRKekVQMklvZGdJS2ZBVEtIMUxmdThnZmhuYUpBUWZBTW9SUjAyWkNl?= =?utf-8?B?SHhHd1BHVTZhaVc1RFVjSGttK2RQeldqK3ZBdGNkeVpYRFFnSFl4SWdlT3Qy?= =?utf-8?B?YmlkMWoxSGpCNzdHNHY3c3Z3WkVSNUE3N1pHZU9PenRWNDE0NWxPZDFYNkIw?= =?utf-8?B?NHQ1WnIvejlSYU9YRDlzYTNCRHIvUm1oc1AzN0FSdHdtY05wdytrN0lkd0F3?= =?utf-8?B?MUNML0JyWTNlaVdxa2RsWXBrWHRtL1FSYi83VWpkTzJqT096N0UyUGoxSVJw?= =?utf-8?B?V1hJZnZXcTFMOWZMQXNxMmFldEVERy81Z0JwK2pqRVhlOHhEK3dXODE2RE5o?= =?utf-8?B?UEpVVWMwNkloczdCVHhRUzhYRHd0T2NGUWZEZ2VCR3I5NDBMaHpMUzZjQmRZ?= =?utf-8?B?eXQrZjRGR0EwNHJOZlZ5UUpadUhmekJtWGJVWStFZnhuV3oxaU45RWNrRVo2?= =?utf-8?B?YTFCeUROZWFjTWVsRG1YSEdLS2NBc0g0ZTUvMHBQaEYxZGpXN0o0UWlHVzVU?= =?utf-8?B?dVVNeHE4TUZCY2thc0x2V0IyL0ZtdnY4Rk45RE9aL0s4TlFabHlKZXYvdEtW?= =?utf-8?B?NzRSZlJ0WXhZT0JXaU5PR0NFeEpGY0RxNHhCYVViWk92c085ZkI5MHhYQVQv?= =?utf-8?B?bDhiT1ZLMmEyOGw0cGhOQWtuSTloeFh4eFBodkp4NTU3dVhVc0EwNGQzUEwy?= =?utf-8?B?QkpQL283TnhLNkx1RjFBZVhRQ0dXWnhFSmdPNTRYdUtiV2JuaFdwcUtJaFNv?= =?utf-8?B?Rll1NkJKVEMwSzFFYi83WG05Mytmam9PNStCUW9FMUVNdDkrY1NnNzQ5Z1hI?= =?utf-8?B?N2VPVEFQNlIwUjJoUmp1ZU5MaHMyVWtCTHN4b1ZqL3IrSmRwWHJaTkhMTStz?= =?utf-8?B?QzZvYlB5NHRoUE40Tm5NZzhjQWhaOWdBN0Rja1FEb1dvVkhhbHlsamtrSTRw?= =?utf-8?B?WGZhQllvNldBS0VKSEtidUw0eHJlaTZlOXd3N0tGY1YrK0k0ZlViR0U4cXRo?= =?utf-8?B?M01zNHdtQ2hxL3FST3F3NXhMdlNVSmxmV3lrZjBPQjlDWklRc25uMmovSkJl?= =?utf-8?B?cHJvdDd6VkJla2ZodTA4R1JZYWxvb0RFYUgxczlvSkZmbWNyRTBhdFVndHJw?= =?utf-8?B?WXd5Z0VHa0J6Y3ZuZjhqZVdFWUNmWS9XcDVoR1N5TGlxc0hvMjJiNm1LSFpv?= =?utf-8?B?dFZvVDRJN2t6QjJXbnd3MFJzT0UzUzZHVDZCa2libXJ4ZUhxZUYxeE1aZWZ6?= =?utf-8?B?M2RUSTBZbzBwaXFaQm15d3c5K1JSd2ZUeVRsK2cwajBadDVQYU95RmllOWQ3?= =?utf-8?B?S1JRRmxzTi9HVDVIUHpFMlVOZDU3NWtjT1J3REZRalpVRDBFN0tlYlljSXNI?= =?utf-8?B?SUxCTElwalZjOTJzVHNMdWdINUJZRzB4NXRxTWNBQTNtdjh2emREYkhzWE9X?= =?utf-8?B?REtxNmJVRUorQ0t1SUExeXVWSDdkaDZiS0F0Mms5MnZCZjdScGtYZz09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d651e063-8ed7-4d6a-707e-08dee8d7014a X-MS-Exchange-CrossTenant-AuthSource: CY1PR12MB9697.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2026 16:25:27.2854 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1fpYR8LSacu8TSkc96GHPlhYvdByZTkx2vzadFiHVY+QBaw4Aru3+J4qLp1o4EU0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7236 On 7/23/2026 6:18 PM, Jay Buddhabhatti wrote: > Currently, during a kexec restart, only the kernel is reloaded, while the > TF-A specific data remain unchanged. This leads to a mismatch between the > kernel state and the TF-A firmware state like SGI number and shutdown > scope variable. > > For example, the kernel registers an SGI number with TF-A so that TF-A can > notify the kernel of events via that SGI. TF-A stores this SGI number in > its internal state. After a kexec, the newly loaded kernel re-registers > and may request a different SGI number, but the stale value programmed in > TF-A remains, so event notifications are delivered on the old SGI and are > missed by the new kernel. The shutdown scope variable has a similar stale > state problem. > > To resolve this, the TF_A_CLEAR_PM_STATE PM API is introduced to clear > TF-A-specific state during kexec. On a graceful reboot, this API is > triggered by zynqmp_firmware_shutdown(), while in a crash kernel scenario, > it is invoked by zynqmp_firmware_probe() in the reloaded kernel. > > Signed-off-by: Jay Buddhabhatti Reviewed-by: Radhey Shyam Pandey Thanks! > --- > drivers/firmware/xilinx/zynqmp.c | 48 +++++++++++++++++++++++++++- > include/linux/firmware/xlnx-zynqmp.h | 3 +- > 2 files changed, 49 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c > index af838b2dc327..95ffd8f33ce9 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -3,7 +3,7 @@ > * Xilinx Zynq MPSoC Firmware layer > * > * Copyright (C) 2014-2022 Xilinx, Inc. > - * Copyright (C) 2022 - 2025 Advanced Micro Devices, Inc. > + * Copyright (C) 2022 - 2026 Advanced Micro Devices, Inc. > * > * Michal Simek > * Davorin Mista > @@ -13,6 +13,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -2065,6 +2066,42 @@ static struct attribute *zynqmp_firmware_attrs[] = { > > ATTRIBUTE_GROUPS(zynqmp_firmware); > > +/** > + * zynqmp_clear_pm_state() - Clear subsystem state > + * @dev: Device pointer used for logging > + * > + * Clears PM specific data in TF-A. > + * > + * Return: Returns status, either success or error > + */ > +static int zynqmp_clear_pm_state(struct device *dev) > +{ > + u32 pm_family_code; > + int ret; > + > + /* Get the Family code of platform */ > + ret = zynqmp_pm_get_family_info(&pm_family_code); > + if (ret < 0) > + return ret; > + > + if (pm_family_code != PM_ZYNQMP_FAMILY_CODE) { > + /* Check if the TF-A supports the TF_A_CLEAR_PM_STATE */ > + ret = do_feature_check_call(TF_A_CLEAR_PM_STATE); > + if (ret >= 0 && ((ret & FIRMWARE_VERSION_MASK) >= PM_API_VERSION_1)) { > + /* Clear PM specific data in TF-A */ > + ret = zynqmp_pm_invoke_fn(TF_A_CLEAR_PM_STATE, NULL, 0); > + if (ret) > + dev_err(dev, > + "Failed to clear TF-A specific subsystem state: %d\n", ret); > + } else { > + dev_warn(dev, "TF_A_CLEAR_PM_STATE is not supported in TF-A: %d\n", ret); > + ret = 0; > + } > + } > + > + return ret; > +} > + > static int zynqmp_firmware_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -2118,6 +2155,9 @@ static int zynqmp_firmware_probe(struct platform_device *pdev) > if (ret < 0) > return ret; > > + if (is_kdump_kernel()) > + zynqmp_clear_pm_state(dev); > + > /* Check trustzone version number */ > ret = zynqmp_pm_get_trustzone_version(&pm_tz_version); > if (ret) > @@ -2151,6 +2191,11 @@ static int zynqmp_firmware_probe(struct platform_device *pdev) > return of_platform_populate(dev->of_node, NULL, NULL, dev); > } > > +static void zynqmp_firmware_shutdown(struct platform_device *pdev) > +{ > + zynqmp_clear_pm_state(&pdev->dev); > +} > + > static void zynqmp_firmware_remove(struct platform_device *pdev) > { > struct pm_api_feature_data *feature_data; > @@ -2210,5 +2255,6 @@ static struct platform_driver zynqmp_firmware_driver = { > }, > .probe = zynqmp_firmware_probe, > .remove = zynqmp_firmware_remove, > + .shutdown = zynqmp_firmware_shutdown, > }; > module_platform_driver(zynqmp_firmware_driver); > diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h > index 7e27b0f7bf7e..baaa88b0b197 100644 > --- a/include/linux/firmware/xlnx-zynqmp.h > +++ b/include/linux/firmware/xlnx-zynqmp.h > @@ -3,7 +3,7 @@ > * Xilinx Zynq MPSoC Firmware layer > * > * Copyright (C) 2014-2021 Xilinx > - * Copyright (C) 2022 - 2025 Advanced Micro Devices, Inc. > + * Copyright (C) 2022 - 2026 Advanced Micro Devices, Inc. > * > * Michal Simek > * Davorin Mista > @@ -66,6 +66,7 @@ > #define FIRMWARE_VERSION_MASK 0xFFFFU > > /* ATF only commands */ > +#define TF_A_CLEAR_PM_STATE 0xa05 > #define TF_A_PM_REGISTER_SGI 0xa04 > #define PM_GET_TRUSTZONE_VERSION 0xa03 > #define PM_SET_SUSPEND_MODE 0xa02