From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Armin Wolf <W_Armin@gmx.de>
Cc: jlee@suse.com, farhan.anwar8@gmail.com, rayanmargham4@gmail.com,
Hans de Goede <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 2/5] platform/x86: acer-wmi: Rename ACER_CAP_FAN_SPEED_READ
Date: Wed, 27 Nov 2024 12:06:28 +0200 (EET) [thread overview]
Message-ID: <f711c1b0-7208-3d22-1ff9-399c7478125c@linux.intel.com> (raw)
In-Reply-To: <20241124171426.29203-3-W_Armin@gmx.de>
On Sun, 24 Nov 2024, Armin Wolf wrote:
> Rename ACER_CAP_FAN_SPEED_READ to ACER_CAP_HWMON to prepare for
> upcomming changes in the hwmon handling code.
upcoming
--
i.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
> drivers/platform/x86/acer-wmi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 5cff538ee67f..dd57787466b9 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -246,7 +246,7 @@ struct hotkey_function_type_aa {
> #define ACER_CAP_TURBO_LED BIT(8)
> #define ACER_CAP_TURBO_FAN BIT(9)
> #define ACER_CAP_PLATFORM_PROFILE BIT(10)
> -#define ACER_CAP_FAN_SPEED_READ BIT(11)
> +#define ACER_CAP_HWMON BIT(11)
>
> /*
> * Interface type flags
> @@ -358,7 +358,7 @@ static void __init set_quirks(void)
>
> if (quirks->predator_v4)
> interface->capability |= ACER_CAP_PLATFORM_PROFILE |
> - ACER_CAP_FAN_SPEED_READ;
> + ACER_CAP_HWMON;
> }
>
> static int __init dmi_matched(const struct dmi_system_id *dmi)
> @@ -2551,7 +2551,7 @@ static int acer_platform_probe(struct platform_device *device)
> goto error_platform_profile;
> }
>
> - if (has_cap(ACER_CAP_FAN_SPEED_READ)) {
> + if (has_cap(ACER_CAP_HWMON)) {
> err = acer_wmi_hwmon_init();
> if (err)
> goto error_hwmon;
> --
> 2.39.5
>
next prev parent reply other threads:[~2024-11-27 10:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-24 17:14 [RFC PATCH 0/5] platform/x86: acer-wmi: Various improvements Armin Wolf
2024-11-24 17:14 ` [RFC PATCH 1/5] platform/x86: acer-wmi: Add support for Acer PH14-51 Armin Wolf
2024-11-24 17:14 ` [RFC PATCH 2/5] platform/x86: acer-wmi: Rename ACER_CAP_FAN_SPEED_READ Armin Wolf
2024-11-27 10:06 ` Ilpo Järvinen [this message]
2024-11-24 17:14 ` [RFC PATCH 3/5] platform/x86: acer-wmi: Add support for temperature sensors Armin Wolf
2024-11-27 10:35 ` Ilpo Järvinen
2024-11-24 17:14 ` [RFC PATCH 4/5] platform/x86: acer-wmi: Improve error handling when reading AC status Armin Wolf
2024-11-27 10:42 ` Ilpo Järvinen
2024-11-24 17:14 ` [RFC PATCH 5/5] platform/x86: acer-wmi: Ignore AC events Armin Wolf
2024-11-27 10:44 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f711c1b0-7208-3d22-1ff9-399c7478125c@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=W_Armin@gmx.de \
--cc=farhan.anwar8@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jlee@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rayanmargham4@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®