From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C55783F5BC7 for ; Mon, 25 May 2026 16:49:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779727781; cv=none; b=cZbFR2HTGkD3BXZ4A/D5LQoewBll7BSbFOx0+ZZU33CJSCgl9FgNs+g1Lik4ta5TUgMSsiNNcEAsT6ekkcpbdFciyoNG7hyTV/2P4TUmNtdGPrZ58q3H0pF3QIkMZwUJVAgJ046onjyFIx1XFzzByh94WllNYLq8V07ibzMaGtc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779727781; c=relaxed/simple; bh=qCJUy0Nryrsei7k31mILaqHdyM91oiOY5aOatjWtaHU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dV0gwZjmskrqczvKLCdgaGwq1qb7q+m6IGuV6R9+1YPcYdxK8AKiOWGSbK6ZJv6LdPwDsPsRiZLWNvBZ1/M9dhjeZAxD2/9rn9l/DUrh7arrMF45QjX1epTRurx0OrxlftlvYnA274Nz1bF3uaceOFIx2n7cjjBSAdygauDEcU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bA7XPDnk; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bA7XPDnk" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-83ec36a13e9so4738190b3a.0 for ; Mon, 25 May 2026 09:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779727779; x=1780332579; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UkcDIh6lSzwJOlp8E1YoKOARe+/1ST0S3JizOOYpoio=; b=bA7XPDnkdgda7xxirX5uK5LpaOpyQu4QnWI/IASwDRd/wc52DKBj1GjPfr/K3q4hPj 25d7vmYMwRN+wrsjtjwtPBi0h8wckcL3ut0txVjLfTeXGtrve3EcqnuKN32azE6Avn7k +wPktnw5t35idAV91i0pFZHciM5BThD1gIOWQDBVPfX5+YT8POrgbTqQRr0sfvcDkGCx fIUbeXKp1BdRaQRzk1t/N8IOXkMGmp5CtfwtpEKntR1aIHJ893QAuHGC2s/EqqBz4lef u1k8fbtXl/DYEwN5Wg1y8sB2PLa67R2dXuAUk43q5C+lBPoIeZtAiuBo7tjAwJcg5y/c nEFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779727779; x=1780332579; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UkcDIh6lSzwJOlp8E1YoKOARe+/1ST0S3JizOOYpoio=; b=F0l25+wL/3/Jw6Mrtsq/GuzAYYg+S50eEFDc4msPJVSfYDixOjkSGuxSBid8ZDiAh8 cMvlR3VN9UW/cXJHgK6oD86c6GAlYGaYVWO4A98ph6FghD+5wXL/BhnoBg7tOwcFeeIC LfMXTUY75VWI3bFg9fiC3vnLHN5RiAbpCIyvZ5jbJWUIhMpJyc+yOYwe+DXRmPbt39Mg AjCif2bDwnX3XDonRxNNpl3pYKFiMR/pHHk3sbZhBVDa6MMTrzv1+/zgP3n+06Xq85PM IJFKIifH3jdMvxsSpVte4y0qsOKvXSWNQx9Jl7uUpXNBJY3g+/BbhTkZlw/fzyZdyk78 yAhg== X-Forwarded-Encrypted: i=1; AFNElJ/xkSNvouhjtpZqJLO7qZ9htYGN+fMmG3a2G1lstdRu/DmUVsrdVYmoDmqJV7Dy02slT9jRU/yXR38BV0U=@vger.kernel.org X-Gm-Message-State: AOJu0YznnJI04r69PxSX3FLB4E1Q0OJaFWauaoKlZuoE6l08h+VqUf/T QA+vUlnSuOyA1RbqPEz2kX7k6LqfKsqKOAPM8q/fw4OTQeHXbFNy6x00 X-Gm-Gg: Acq92OECseFLMD7CQ3fKhS8U5Q6rsIGKgGLk1BTKGzjJjUZ5OWtX61MiwVs8sEAaXJu EXETnaG4jbzN3rIEJDP3rtusx+iA8LhjuBp/6Y4gH3R/pXpDhA0MzMXvBw2hp8rpuVEVSltUkpp 8nKK5saK5XCyLWUmz9r8UZqf9qemg0+4YRhjSjntZN/x9ZpkuuZtvE4OAr4Z+7TrPs+vzerpInK ivBgaVZ8p104Rt5zy/kHPeRJ9mmq00BgRO2bFneKpnZCdTFNDanbZON3HHeEKZvsD1mpWK7lDWz cn0hITfWZPdDNO74WLV8eA7FMABLkQO/gwfStYmon0/5F91+Upj4AZWbF76hYW9FQ9PoLyzKdz4 xlQXqEdvjLlJcB534ytnj6bTyDdy2kjFBVoBUT5tMm8ZfTWEINg/Gos9ylf4sPRy9jkD7OR1CLo 7t8gKT3ze7ZnvNhpdVjjBVNqCebADS+kzmihDG3sqtryG8pUHXXvhL/AijsasOKlBLJqEjO+PaZ aXvjtU= X-Received: by 2002:a05:6a00:8c10:b0:81f:9b4c:81c0 with SMTP id d2e1a72fcca58-8415f58d727mr13761843b3a.41.1779727778848; Mon, 25 May 2026 09:49:38 -0700 (PDT) Received: from ?IPV6:240b:10:2720:5500:34c9:7e9c:7c33:58d6? ([240b:10:2720:5500:34c9:7e9c:7c33:58d6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-841648a2bf2sm9129616b3a.0.2026.05.25.09.49.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 09:49:38 -0700 (PDT) Message-ID: Date: Tue, 26 May 2026 01:49:36 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] nvme: reject passthrough of driver-managed Set Features To: Keith Busch Cc: Chao Shi , linux-nvme@lists.infradead.org, Christoph Hellwig , Sagi Grimberg , Jens Axboe , Tatsuya Sasaki , Maurizio Lombardi , linux-kernel@vger.kernel.org, Sungwoo Kim , Dave Tian , Weidong Zhu References: <20260523225629.3964037-1-coshi036@gmail.com> Content-Language: en-US From: Tokunori Ikegami In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2026/05/26 0:49, Keith Busch wrote: > On Tue, May 26, 2026 at 12:34:03AM +0900, Tokunori Ikegami wrote: >>> +static bool nvme_cmd_allowed(struct nvme_ctrl *ctrl, struct nvme_ns *ns, >>> + struct nvme_command *c, unsigned int flags, >>> + bool open_for_write) >> The struct nvme_ns does already have the struct nvme_ctrl *ctrl as a member >> variable as below so seems not necessary to add the function argument struct >> nvme_ctrl *ctrl. > This filter is for admin commands, so the 'ns' parameter is NULL for > this case. Okay so how about that to use the function argument unsigned int flags instead with adding the NVME_IOCTL_FABRICS enum definition? enum {     NVME_IOCTL_VEC        = (1 << 0),     NVME_IOCTL_PARTITION    = (1 << 1), }; Note: I mean as possible as we can it seems better to avoid the many function arguments for the maintainability. Thank you.