From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754114AbeEaIyO (ORCPT ); Thu, 31 May 2018 04:54:14 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:54258 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754057AbeEaIyK (ORCPT ); Thu, 31 May 2018 04:54:10 -0400 Subject: Re: [PATCH v4 5/5] ARM: dts: imx6qdl: add missing compatible and clock properties for EPIT To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= References: <20180530120327.27681-1-peron.clem@gmail.com> <20180530120327.27681-6-peron.clem@gmail.com> CC: Colin Didier , , , , Daniel Lezcano , Thomas Gleixner , Fabio Estevam , Sascha Hauer , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , =?UTF-8?Q?Cl=c3=a9ment_Peron?= From: Vladimir Zapolskiy Message-ID: Date: Thu, 31 May 2018 11:54:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Icedove/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [137.202.0.87] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Clément, On 05/31/2018 11:41 AM, Clément Péron wrote: > Hi Vladimir, > > On Thu, 31 May 2018 at 10:33, Vladimir Zapolskiy > wrote: >> >> On 05/30/2018 03:03 PM, Clément Péron wrote: >>> From: Colin Didier >>> >>> Add missing compatible and clock properties for EPIT node. >>> >>> Signed-off-by: Colin Didier >>> Signed-off-by: Clément Peron >>> Reviewed-by: Fabio Estevam >>> --- >>> arch/arm/boot/dts/imx6qdl.dtsi | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi >>> index c003e62bf290..0feec516847a 100644 >>> --- a/arch/arm/boot/dts/imx6qdl.dtsi >>> +++ b/arch/arm/boot/dts/imx6qdl.dtsi >>> @@ -844,13 +844,23 @@ >>> }; >>> >>> epit1: epit@20d0000 { /* EPIT1 */ >> >> epit1: timer@20d0000 { ... >> >> And /* EPIT1 */ comment can be removed, it is quite clear from the same >> line context. >> >> Formally it is a subject to another patch, but I think this can be >> accepted as a part of this one. > > Should I also update other boards ? > I only did it for imx6qdl.dtsi, but the EPIT is present in other boards > but i can't test it myself. > Sure, please do it, why not, it is quite a safe modification. One change per one dtsi file will suffice, and I see that imx25.dtsi already contains the requested change, however probably you may want to update its compatible = "fsl,imx25-epit" line. Regarding compatibles for other imx6* SoCs, I think all of them should be documented in fsl,imxepit.txt and then added to the correspondent dtsi files one per SoC. And I forgot the outcome of one former discussion with Uwe Kleine-König, but if my bad memory serves me, we agreed that i.MX25 was released later than i.MX31, so the most generic (the last value in the list) compatible should be a compatible with i.MX31 like in imx25.dtsi:367: compatible = "fsl,imx25-gpt", "fsl,imx31-gpt"; -- With best wishes, Vladimir