From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03DDC44BCA9 for ; Fri, 27 Feb 2026 16:08:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772208527; cv=none; b=clsFJ8d4v0Oi3THueQAoEqryjeEoy97jTPMK3fnb1h3EyYmxfNz2l4KNWKxK9b7XOV2reBGe1hmkGm9IPTj+7vnLgq4cMKBhC6lyCartmId9CjIekCyBXnEmfGBla8JsEUZLAZhLWy84s7TzhWcv5gDXg8QhRZ1wTzb4N/YZ0Is= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772208527; c=relaxed/simple; bh=STkeXZBzuh+YN7vlYJuUPRBvITseQafQdv1omnUABmQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VGOPwHh68Un2G8U5CG/gUY3F8TajVtHtTIY6fxRD9hIT1oTh9e8Yy99oGpDMrNcel97RqI+J1tKSz4kwwZRRiFyWW70z+d96LPlE4CrIVZtXLqAQHNlPot0vGWJZ05cFGZukHxPTTxmC5V3Yg1VQGPtxEtfmJqO/in+mmDVBCdk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=pxne8VK+; arc=none smtp.client-ip=209.85.210.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="pxne8VK+" Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-7d598f4c618so284708a34.0 for ; Fri, 27 Feb 2026 08:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1772208524; x=1772813324; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KtWJbD82CzzIAa0NPT1U1WDK0yBcottZE/DqnKgdU80=; b=pxne8VK+ozSmF4CUPYRcPrt1PVWITHaYch+mrdMVK1qRZtUJnOWQNef3thOh7Qdros 8Ssa8wB88SdbuW0n77Bnjwgft7ECf0KsDZEZ9+9G4omks967tMEuFB1gp1Ia57JB/q8i jl1q1dsXsk5E+YBR+G90YV8cf0i4yQ+xtp9KLan1igUxIcd3PwStzzQSSPJO1Pai7vlw AQALr5nIzply3dg5gKCfwLskBlKATEkZnzPpCHkaEJkpPLJGE5tK6kNH80gtgQGVlyRT CKf6qCMDgvL6PaXsLSt/WnZ3fw1LyUwraIg9Outo3WuDnWXijFoklFXuV7u5Riww5ZtH H4EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772208524; x=1772813324; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KtWJbD82CzzIAa0NPT1U1WDK0yBcottZE/DqnKgdU80=; b=vHTsnOW2UJj4p3HscWqmdYohmE9SgQEYHfAw6AZAxbay893se77rFvGZP7lH3nDBqo 9nG7oZtGlzS0nk886RXcEDwzYlhOKup3/jZz+YxeF1wQ51k7vddshqpQnVPthzkbZb5T EVjIUYCZ0D8SLC+D0tN+Wl7VBi9AxBX7N4v3YuFcC35zhlihuygX9iLEJayqLGuc3ZWG xm3myVl8HCYhbKhjkRFFXhNJKfz/ehCEKY9Mho98LyXFJbyzwlfaOJgHjVlt9xxTPbcy 5ozxoymrC+UNbr9Zjt9ndu2Ax2gQb6WOYS3DaPYUNG9J3aa3KSUw/NkbFoaTBh2kBq+3 qA3g== X-Forwarded-Encrypted: i=1; AJvYcCWzeGBp/v9uNiHG/LnAlYmVRC/aaC9bUEOzJJoiQnp04UUpNe4FKGavOy+/Ae+Dn8dbtXmY20KLK1IVEDs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5VmtgQ/4vg+QZvHiUF9oLzd4vKpqVE7iexDQae8OAtIMybCT+ CZ+9nkNH7XUZhdICpdoxtKJjsd9KzgddykozrCENj9ZMFrFbX7IAmaCwWq0d82+LeCg= X-Gm-Gg: ATEYQzwiK3Dznq79GD9tpy94li4CTmKIehE4Z2O0N+A4PVtZ/hvVCUhGP4tn4F+V+// SBye2xNUH+yVjguphhCHObTzFJMEA9EB5UDseFMMqKmkI4wjCUCfyaz15vat2drHdnDsiC/Jqao 53+I8YUMvVY8llz1c286FKZ3Sq8Ce+BeXFvKIjYPtWsQcAqu81M4s/gEAmsIe0a5bl0qlE/Guiy N6DqBU4G7tXWSK+zsH5ZVHOBqomFrkZUFDYn4c1N+kYWWYtHfWZktGgcQQjS1foaBqrKS/VuaXM YIj0Za9LNHAm4wTHp3qD0G6coANyTBuBHIoKVlP6ISvYLqxzD6hVrgIzy1tBvS+SUYdggJoVc7y 7kNKREFhAbHMcL9p5nXwEBkr6eykQxVwjSUGBC+kvy4dCMpnzG+BDTT3CiHHDfb62aPzYvCG8HB ZW70bVCTxx0zvYaoGNs6E5GyzzLyBhqCe6pCFyJxlQ9AL2O4Fkit7Kqi8ye1iF2FDfz+2gUpWuo g== X-Received: by 2002:a05:6871:69a6:b0:409:62c9:5cb8 with SMTP id 586e51a60fabf-41626d87140mr2153992fac.10.1772208523782; Fri, 27 Feb 2026 08:08:43 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:876a:e36c:76c7:e6d4? ([2600:8803:e7e4:500:876a:e36c:76c7:e6d4]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4160d21196csm4799103fac.12.2026.02.27.08.08.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Feb 2026 08:08:43 -0800 (PST) Message-ID: Date: Fri, 27 Feb 2026 10:08:42 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] iio: filter: admv8818: Simplify locking with guard() To: Ethan Tidmore , Antoniu Miclaus , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260227061424.1135505-1-ethantidmore06@gmail.com> <20260227061424.1135505-3-ethantidmore06@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260227061424.1135505-3-ethantidmore06@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/27/26 12:14 AM, Ethan Tidmore wrote: > Use guard() instead of manual locking to simplify code. > > Signed-off-by: Ethan Tidmore > --- > @@ -352,13 +344,8 @@ static int __admv8818_read_hpf_freq(struct admv8818_state *st, u64 *hpf_freq) > > static int admv8818_read_hpf_freq(struct admv8818_state *st, u64 *hpf_freq) > { > - int ret; > - > - mutex_lock(&st->lock); > - ret = __admv8818_read_hpf_freq(st, hpf_freq); > - mutex_unlock(&st->lock); > - > - return ret; > + guard(mutex)(&st->lock); > + return __admv8818_read_hpf_freq(st, hpf_freq); > } admv8818_read_hpf_freq() is the only caller of __admv8818_read_hpf_freq() so we can drop the wrapper, move the guard to __admv8818_read_hpf_freq() and rename it to admv8818_read_hpf_freq(). I didn't check all functions, but might be others places where we can do this as well.