From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D8491D958E for ; Tue, 7 Jan 2025 20:38:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736282328; cv=none; b=t6CnYSLHoCoA5c2vUf8reRhJnPnB4AG6FKsnQ0Muu1KyPg066pc1os0IsSM+DHVkuJNiHtua56Lc59sWWqiRtSc/9+Ez/fE8D/zeAXCm/9bZwn6lmHgko2B604v+peqzv7juriup1jy7K8ZtV4jIDOmTpXYHk0d34OKyZvnt39Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736282328; c=relaxed/simple; bh=e8WQ39Su6ky7skUv3PyuvKeIr5tlC26nKHLRUgnNraA=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=arw6nU2rBwavwHMflq0SYzUtX6q58dDMVyNQ1pm4K/AaYEFXszZ4VieEAlTWJ7z4bFzEheJVcIC//V0CXDWOgn3fixNN0wlXAlZfj37jILjQ+tbbYo/LDCQWOQ8oFWQNbTgLbEAhoo0KjFrtBboBiIWiyrGRGwoOe4v1Xb2iYUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JDO6CzxH; arc=none smtp.client-ip=209.85.166.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JDO6CzxH" Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-3a9cee9d741so111638715ab.3 for ; Tue, 07 Jan 2025 12:38:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1736282324; x=1736887124; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Uzbso2+ca1pLZqt/93l4QqoXiGatRJPC5SsTzTNGAHI=; b=JDO6CzxHd7Uu40+EFRtDfynvvtoiGClZr4WFDnmq5kRF8ThTTpxttSq23n4PgdrCWf wYBp+S3Wsl0ozYoPt5SoUyfVzGidCnMqrLJaaUQaxK4IBLSPi3hGj1pYQ832pvTPhQ7Q LYqFJq8o+1fapLbyD/K5Oc11N3tusOB3S3lOI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736282324; x=1736887124; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Uzbso2+ca1pLZqt/93l4QqoXiGatRJPC5SsTzTNGAHI=; b=a/X3coA6xVX4ZAMBwyX2rbRe9UiEUnkQdUN781vcgNmQCdFxm6p6krQ9UsWO14iC2k L7CZerSDUJJzcvE3o5vhyzz+4DpVsD1cDWBYdLWbH/HXKDqz1g6i6QXYB1YYXQ5YMrXL KgwJvbrP+cSxAPgANhsi3WSyEwuucMWzk4505ylOL/D+wQxeCfgpUcFRzA/MVt3Eo9yT fbjBVqbZpobK8lpPuZTJFssKfAFmFQHUIuhWCWYWC4uts2dE+2KGN57BZINF9YgE40Bx 6tu0QOOBIPmQdcKyqCWTF0aFvmVpBVu8DQHE4WCtPXb/SrYijGQElsXXkNiDIoUSL6D3 Xm8Q== X-Forwarded-Encrypted: i=1; AJvYcCV0kynbyfdURDTaof7+lFiS5qwLVeW2d2iZRDqFDLb2Bjq6DW58wDdCq+YsJCUf4yS+lLF5o3O7MBtfKVs=@vger.kernel.org X-Gm-Message-State: AOJu0YysONIVmRA9dERnlae2cttsS9hi7pZ921O+dRwipqj4xXeAKJQJ lpbHDnpvzX4tx5GaAk2L8A4TgDTuAlbC09c4xZEp54UBoJkScGORJ9nfckNdSzw= X-Gm-Gg: ASbGncvnLx6jr4X8vACzAxFUf1sy+ZGVYu9NBZ8K7jYG4Z3iq40amoVIANAgiXmu3xD S9ywaNgN8rPj28PYtzE+yrdi0dMclZ8roXtuKYzFCtd1Xohb9Xq8LM5CCee5C3V3iEID5XUvGV1 RaPgB74dCu7jnLr3bFKm4NqtR2YkY6VGKdrL2cOCPALiD82SZ/WfMwaqjL2+5u3dUUqmqD9p58o nefsm87QWfpgmwhZoBAvFRhtxsjPSw5nH7Ps1elYWNXzIZLvMA0YyBI16mW3ehRDIuQ X-Google-Smtp-Source: AGHT+IHjFkhumWPxo4w0OFqZx0FKT5AXj10ENPl5LhQhojTdBUyruRJpYRD7p7bnN0WrZq9CT3z5fw== X-Received: by 2002:a05:6e02:1488:b0:3a7:a2c6:e6d1 with SMTP id e9e14a558f8ab-3ce3a93a83emr4414725ab.16.1736282324344; Tue, 07 Jan 2025 12:38:44 -0800 (PST) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3c0deccf34fsm103978225ab.30.2025.01.07.12.38.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 12:38:43 -0800 (PST) Message-ID: Date: Tue, 7 Jan 2025 13:38:42 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] pm: cpupower: Makefile: Fix cross compilation To: Florian Fainelli , "Peng Fan (OSS)" , Thomas Renninger , Shuah Khan , "John B. Wyatt IV" , John Kacur , Peng Fan , "open list:CPU POWER MONITORING SUBSYSTEM" , open list , Shuah Khan References: <20241129012006.3068626-1-peng.fan@oss.nxp.com> <16615e97-268e-4daf-a991-6cad7803ac16@linuxfoundation.org> <3b55d23b-aa37-4187-9649-aef663ee1de8@broadcom.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <3b55d23b-aa37-4187-9649-aef663ee1de8@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/7/25 11:56, Florian Fainelli wrote: > On 12/9/24 16:58, Shuah Khan wrote: >> On 12/2/24 10:12, Florian Fainelli wrote: >>> On 11/28/24 17:20, Peng Fan (OSS) wrote: >>>> From: Peng Fan >>>> >>>> After commit f79473ed9220 ("pm: cpupower: Makefile: Allow overriding >>>> cross-compiling env params") we would fail to cross compile cpupower in >>>> buildroot which uses the recipe at [1] where only the CROSS variable is >>>> being set. >>>> >>>> The issue here is the use of the lazy evaluation for all variables: CC, >>>> LD, AR, STRIP, RANLIB, rather than just CROSS. >>>> >>>> [1]: >>>> https://git.buildroot.net/buildroot/tree/package/linux-tools/linux- tool-cpupower.mk.in >>>> >>>> Fixes: f79473ed9220 ("pm: cpupower: Makefile: Allow overriding cross- compiling env params") >>>> Reported-by: Florian Fainelli >>>> Closes: https://lore.kernel.org/all/2bbabd2c-24ef-493c- a199-594e5dada3da@broadcom.com/ >>>> Signed-off-by: Peng Fan >>> >>> Tested-by: Florian Fainelli >>> >>> Thanks! >> >> Thank you. Applied to linux-cpupower for my next full request to >> Rafael. > > Since this is a bug fix, any chance you can fast track that change so we can keep on building that tool in various environments? > I am planning to send pull request to Rafael later on today. It will be available in linux-next once Rafael pulls it in. I don't think if it can be fast tracked with the vacations and holidays for the past 3 weeks or so. The best I can do is getting this into linux-next thanks, -- Shuah