mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yen-Chi Huang <jesse.huang@portwell.com.tw>
To: ilpo.jarvinen@linux.intel.com
Cc: hdegoede@redhat.com, jdelvare@suse.com, linux@roeck-us.net,
	wim@linux-watchdog.org, linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-watchdog@vger.kernel.org, jay.chen@canonical.com
Subject: Re: [PATCH v3 1/2] platform/x86: portwell-ec: Add suspend/resume support for watchdog
Date: Tue, 26 Aug 2025 17:43:29 +0800	[thread overview]
Message-ID: <f72da7c2-cd2f-4b09-8cc5-7b08ad54dde8@portwell.com.tw> (raw)
In-Reply-To: <6584da3e-fc86-7a47-f783-da77049b2215@linux.intel.com>

On 8/19/2025 5:51 PM, Ilpo Jarvinen wrote:
> On Mon, 28 Jul 2025, Yen-Chi Huang wrote:
>>  static struct platform_driver pwec_driver = {
>>  	.driver = {
>>  		.name = "portwell-ec",
>>  	},
>>  	.probe = pwec_probe,
>> +	.suspend = pm_ptr(pwec_suspend),
>> +	.resume = pm_ptr(pwec_resume),
> 
> These are legacy handlers, please use .pm under .driver and the macros to 
> create the struct dev_pm_ops.
> 

Hi Ilpo,

Thanks for pointing this out. For v4, I have switched to .pm with
DEFINE_SIMPLE_DEV_PM_OPS as suggested.

Best regards,
Yen-Chi

  reply	other threads:[~2025-08-26  9:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-28 11:56 [PATCH v3 0/2] platform/x86: portwell-ec: Add watchdog suspend/resume and hwmon Yen-Chi Huang
2025-07-28 11:58 ` [PATCH v3 1/2] platform/x86: portwell-ec: Add suspend/resume support for watchdog Yen-Chi Huang
2025-08-19  9:51   ` Ilpo Järvinen
2025-08-26  9:43     ` Yen-Chi Huang [this message]
2025-07-28 12:01 ` [PATCH v3 2/2] platform/x86: portwell-ec: Add hwmon support for voltage and temperature Yen-Chi Huang
2025-08-07  9:45 ` [PATCH v3 0/2] platform/x86: portwell-ec: Add watchdog suspend/resume and hwmon Yen-Chi Huang
2025-08-26  9:58   ` Yen-Chi Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f72da7c2-cd2f-4b09-8cc5-7b08ad54dde8@portwell.com.tw \
    --to=jesse.huang@portwell.com.tw \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jay.chen@canonical.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®