From: Jeff Layton <jlayton@kernel.org>
To: Qiujun Huang <hqjagain@gmail.com>
Cc: sage@redhat.com, idryomov@gmail.com, ceph-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/ceph: return errcode in __get_parent().
Date: Fri, 06 Mar 2020 07:13:41 -0500 [thread overview]
Message-ID: <f7318d47df2074a7a00ea3a8580bc973a8c0b206.camel@kernel.org> (raw)
In-Reply-To: <1583458460-31917-1-git-send-email-hqjagain@gmail.com>
On Fri, 2020-03-06 at 09:34 +0800, Qiujun Huang wrote:
> return real errcode when it's different from ENOENT.
>
> Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
> ---
> fs/ceph/export.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/fs/ceph/export.c b/fs/ceph/export.c
> index b6bfa94..79dc068 100644
> --- a/fs/ceph/export.c
> +++ b/fs/ceph/export.c
> @@ -315,6 +315,11 @@ static struct dentry *__get_parent(struct super_block *sb,
>
> req->r_num_caps = 1;
> err = ceph_mdsc_do_request(mdsc, NULL, req);
> + if (err) {
> + ceph_mdsc_put_request(req);
> + return ERR_PTR(err);
> + }
> +
> inode = req->r_target_inode;
> if (inode)
> ihold(inode);
Looks good! Merged into the ceph-client/testing branch and should make
5.7. Thanks for the patch!
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2020-03-06 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 1:34 Qiujun Huang
2020-03-06 12:13 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7318d47df2074a7a00ea3a8580bc973a8c0b206.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=hqjagain@gmail.com \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®