From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C8954457BD for ; Mon, 17 Aug 2026 15:25:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786980352; cv=none; b=eGZP5kY6mElmqoFFs8SloIHbLBzsb9URmJpDcyd+d2d0E2xv9ZHjoa21CGp31gCl9bdkxswVYq7WWatlVW8RsaBBuH7ydAF8S3d6B/i8ZNNDvkCB3WTN0BKyX+MbMHGWRhAWb6zgGUQR3hyQgDCLcV/4ZW/Rq80zicY1rKthATI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786980352; c=relaxed/simple; bh=XBzFWhcCyZU2yJ+/3TDI4fZANSR2pFhRn+TRORSTUgE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ivSqwxoyMh3nEVVHecfka5GFrNyjtZHpVpKB3vRjFN5WYyus+pKwkp4bhTHvwAuxikeZ2bvvcjsniks8XyHVYPaNRFMuuPMRXG7q88TNhI/Rx7FHxDTUlNY8RviLnxJZbyrHsAnzhgiJG4avhFIXX+WkE9FPC/I9DNiT72VTrAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Q9gFdM06; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HivnAMAf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Q9gFdM06"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HivnAMAf" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67HD6DfX1193726 for ; Mon, 17 Aug 2026 15:25:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gS0QNQ0WhZ8xM/8ZNpfDM+xJH1jiqfGWfnkppPoW6TY=; b=Q9gFdM06eRE5sR+F MBzVMIv2b0Wkf89NeQBw3SmTfXt9vyrpPReD75/C3+pKgN8bRPMczR2fTngt6sdb dIt7jIhgQEYYsst+WcRWRdPeyJNiLOujTGpb6fP+K2JXP3iCe6tQLJwojKSHp0D8 /M9dXkG09McJM521PbGuy9wuaowRyYUDT8IUT6Qt/yfK5aBtC+CS4PTPv01VrVyJ g9ZTRmiM8VVThU8U8qrGxS9jRR1kBohqdOqIlaohDjKAU8Wky3Brp5j5pDHi7Chr EoXqcnYUK8XRa6DJb0PUrKCnPf/Al38p+h1Uou2ynOUFwJmjwNNW7c8nyawo+PjP XLCxRQ== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g3wke20sv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Aug 2026 15:25:47 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-7530aaa7212so97460137.3 for ; Mon, 17 Aug 2026 08:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786980347; x=1787585147; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gS0QNQ0WhZ8xM/8ZNpfDM+xJH1jiqfGWfnkppPoW6TY=; b=HivnAMAf02dMsxbfhbmhhVVFRbuw8CE4WPk6tfeTwsVdRQvalVCMQS9lpU9XvRUKZ7 4pae/UJW+JC/zPoqJ1aFN04yXTv1HcRRb8rBLvQOwjq3kLpXQCBoeD7cfpboV5WgoREr S808WDzb0lWTz1uCUwDDbN8gO0RchmkPRfR98ahKXgEDPMLr/pFwuhJJngsl7dYKvemC 1fGRkREiKE9wRLQXcR/mcQxR0jbBYn3fqqvehZ3DPI0Ul99wZOIGeYt5YphbU6COMKTt Dn2x2i3zTa2AeLWj/qz3PoPyQPZAgpV96NHYfXJwMJzKytcnbhJOF9dLTnk4FWBOL3K9 wnPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786980347; x=1787585147; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gS0QNQ0WhZ8xM/8ZNpfDM+xJH1jiqfGWfnkppPoW6TY=; b=HEfxxjONVniqDqh950xIeaHmWTEwA3NMw6dnYZciHQfuebvvH3aV3Sxnu+NDX8b1if n8OpwpBVBAqxRreKNBrfdkHn5e9jnDYbKg50vgOLvokhu9+ziT6C3r5aWsktnPqW0Smo hAnpLpHL1jBdGSGALx9cXNs72+2V0DCuD0xvhSlG9yZPJKixj6jIW/0yBdu/hFX2gOC/ Y9Dk6WOp9SGBXGoASm6uccexuSSn943A2DD6WlccjpgW1QgdV9oHoB/2PHmBj8ZNJvKY PjZG3+S9kfMADuPkKDcnv0SO6zPeeiS6zqWHSBpm7xp8iY4/Yj5OVe53retQaFl+CP1j 86cA== X-Forwarded-Encrypted: i=1; AHgh+Rr8/Uj4+n6eudH/SLw9/N9Dq4Pl3ZHMnvdtLSeeeUZUDPmostZB4JjPvenoyb7dTKwNyCZ4iFUKRCRBjFU=@vger.kernel.org X-Gm-Message-State: AOJu0YzFgHwcDaexiqp+JC14k8ypkgYbMampxXmpJZGlyiVwd6l6stG9 gBlCJyIY5Kp5mI7HoEKu2EqM6Z5I0kWZe0/YgId5/iP3ZHVsfez4f4RoFmQNaEVEeHMfjpi6Eyd AT8n+DkffE14CYburAr4NcVhJ9TYt6DFQlsGJWLWIoDsRaIEdeVoUG5HjnW/qyl3q2qc= X-Gm-Gg: AR+sD10jWio2yblGRqf8tYNGJIQETsiIQmf5PHEU4SpcUmPNQGm/UphGqNWm8IWiD3D GpOkmPmcFhX7rNS95b7pygmc/uqNln6yaf3mIJbU7UAhjpgfnlveZoUTJTzZZJFcqyGkWUIyoaU h0AYaGtugReNG74xsSDox9hdMsA03fxgvAISV8TIxV4tKUI1CaBTqsumvVwyUi19MVzaEFrUO0t l+xPRVUA9mqG3VHnU5satf4Uy0igraet7QxRbC7jWS1Rh7WVu1HdcaNPDnE6ZgPGpWgr3zqz/4V j4GTNc6M6aEpERGDQTipAP36BXBtGkd+bP/gm47krgr/bBiZUy4sbahfjUAyETn2NT9ao6TIyhT rKjLniTU/HPP0Xh8X/P4d0cba X-Received: by 2002:a05:6102:5091:b0:72f:6669:286a with SMTP id ada2fe7eead31-76f2c540eb2mr1631470137.2.1786980347225; Mon, 17 Aug 2026 08:25:47 -0700 (PDT) X-Received: by 2002:a05:6102:5091:b0:72f:6669:286a with SMTP id ada2fe7eead31-76f2c540eb2mr1631463137.2.1786980346780; Mon, 17 Aug 2026 08:25:46 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c217ff7e1a2sm75279766b.14.2026.08.17.08.25.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2026 08:25:45 -0700 (PDT) Message-ID: Date: Mon, 17 Aug 2026 17:25:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/15] pinctrl: qcom: Add Kuno pinctrl driver To: Hardeep Sharma , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Michael Turquette , Stephen Boyd , Brian Masney , Taniya Das , Georgi Djakov , Bartosz Golaszewski , Linus Walleij , Thomas Gleixner , Radu Rendec , Robert Marko , Guru Das Srinagesh Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org References: <20260814-kuno-soc-support-v2-0-3079794f0f73@oss.qualcomm.com> <20260814-kuno-soc-support-v2-9-3079794f0f73@oss.qualcomm.com> <4e7a398b-e75c-4dca-8380-440ca7cb22c6@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <4e7a398b-e75c-4dca-8380-440ca7cb22c6@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE3MDExOCBTYWx0ZWRfX/5s3pOlj+PK6 txFcmrSD43mKfstZNwqIQg/JCHztQIEFif/95BEINZSMIk8mm67l0TT0wpXPB9ubtlwWnCEhv1s iNy2D819jcZqHUWF2ItJs2/xaSJSacPCT4QlzvmHruKj6ezSl/r1ULPSx6CDqgjxYPgyfXFYbeD OQzc+j+MCNHrvTwqjzRQSCfvqmK34gEdBbaY0+dDVO5h7nEUSYmNTmO49ubtnHzxFQIZQw8ZOfX 7vensMw1JkLLBdCnMZGYRGzyeCijpdFUnmcpE6S0HV0ca5AQ33ifryRoUbZgQZwyKSeE83ZZhcH h7OuvU/R6UZrBULVrSa7+nO4tX8q+cWh4/hckjbveNoA+GFW76px3IuJrWX2Z9NL0Z4g0GPFMSW glAQUcWunkrzdbM3sNi3ofMLj+YJ3/EvEGuqAXVFEd5SomSycLUiYTLYuYRf4yMYXyXjOaoFZ0c AWspGzxA97ccmuJ9eyw== X-Authority-Analysis: v=2.4 cv=QetWeMbv c=1 sm=1 tr=0 ts=6a8327fb cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=2hgIxXGGQldiWaMEjnoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-ORIG-GUID: _032w6PZUpRM7BEXaxYyzHVieEiOr6mr X-Proofpoint-GUID: _032w6PZUpRM7BEXaxYyzHVieEiOr6mr X-Proofpoint-Spam-Info: AW1haW4tMjYwODE3MDExOCBTYWx0ZWRfX4Xm99EJCm/sa 9JGzR2UWhuZdCplCRtYSIx75Od8VMbinqIe1KkiA58L8Bfca91imDQOr25L0q158yPExp+t86qC P7Zrn/sdEe7w9NVuktJ/J7Ldy4Cugvc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-17_01,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 adultscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608170118 On 8/17/26 3:42 PM, Hardeep Sharma wrote: > > On 8/17/2026 6:54 PM, Konrad Dybcio wrote: >> On 8/14/26 9:31 AM, Hardeep Sharma wrote: >>> Add the TLMM pinctrl driver for the Qualcomm Kuno platform, supporting >>> 110 GPIOs and their pin multiplexing, pin configuration and gpiolib >>> interface through the common pinctrl-msm driver. >>> >>> Signed-off-by: Hardeep Sharma >>> --- >> [...] >> >>> +    [65] = PINGROUP(65, qup0_se1, qdss_cti_trig1, qdss_cti_trig1, NA, NA, NA, NA, NA, NA), >>> +    [66] = PINGROUP(66, qup0_se1, qdss_cti_trig1, qdss_cti_trig1, NA, NA, NA, NA, NA, NA), >> Function3 can't be selected because of repeating names >> >> In qdss_cti_trig1_groups, you have qdss_cti_trig1 specified twice. >> Perhaps there was a longer name that got truncated? >> >> Konrad > > Thanks Konrad for review. > > It's a real qdss_cti_trig1 line - the in/out > mirror partner of funcsel 2: > >    GPIO65: fsel2 = qdss_cti_trig1_in_mirb, fsel3 = qdss_cti_trig1_out_mire >    GPIO66: fsel2 = qdss_cti_trig1_out_mirb, fsel3 = qdss_cti_trig1_in_mire > > Both map to the same name because the driver uses one coarse > "qdss_cti_trig1" for the in/out mirror variants. But these are physically separate functions, even if the mirror feature makes them seemingly one and the same > Listing the function on both funcsels is the normal sdx convention for > these mirror pairs - the in-tree drivers do it, including the same pins > on sdx65: > >    - sdx55 [16][17][22][23][54][55][94][95] → in pinctrl-sdx55.c, pins > 16, 17, 22, 23, 54, 55, 94, 95 each repeat qdss_cti at two funcsels. >    - sdx65 [65]/[66] → in pinctrl-sdx65.c, pins 65 and 66 do it — >    - sdx75 [16][52][53][56][57][78][79] → in pinctrl-sdx75.c, those pins > do it. > > Only funcsel 2 > is selectable from DT (first-match), which is expected and matches those > drivers. As you described it, you found a bug (FSEL3 is not selectable), please fix it in all the instances you've mentioned. Konrad