From: "Noralf Trønnes" <noralf@tronnes.org>
To: Gerd Hoffmann <kraxel@redhat.com>, dri-devel@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE"
<virtualization@lists.linux-foundation.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Dave Airlie <airlied@redhat.com>, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v2 1/3] drm: switch drm_fb_memcpy_dstclip to accept __iomem dst
Date: Wed, 10 Apr 2019 11:42:33 +0200 [thread overview]
Message-ID: <f73b4d2e-1767-3512-0a8a-d447a2f22639@tronnes.org> (raw)
In-Reply-To: <20190410063815.17062-2-kraxel@redhat.com>
Den 10.04.2019 08.38, skrev Gerd Hoffmann:
> Not all archs have the __io_virt() macro, so cirrus can't simply convert
> pointers that way. The drm format helpers have to use memcpy_toio()
> instead.
>
> This patch makes drm_fb_memcpy_dstclip() accept a __iomem dst pointer
> and use memcpy_toio() instead of memcpy(). With that separating out the
> memcpy loop into the drm_fb_memcpy_lines() helper isn't useful any more,
> so move the code back into the calling functins.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
next prev parent reply other threads:[~2019-04-10 9:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190410063815.17062-1-kraxel@redhat.com>
2019-04-10 6:38 ` Gerd Hoffmann
2019-04-10 9:42 ` Noralf Trønnes [this message]
2019-04-10 6:38 ` [PATCH v2 2/3] drm: switch drm_fb_xrgb8888_to_rgb565_dstclip " Gerd Hoffmann
2019-04-10 9:44 ` Noralf Trønnes
2019-04-10 6:38 ` [PATCH v2 3/3] drm: switch drm_fb_xrgb8888_to_rgb888_dstclip " Gerd Hoffmann
2019-04-10 9:45 ` Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f73b4d2e-1767-3512-0a8a-d447a2f22639@tronnes.org \
--to=noralf@tronnes.org \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®