From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 256B8273F9 for ; Fri, 13 Feb 2026 18:09:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771006194; cv=none; b=h5DpDKy8BgsmqIqavJELoOipyBzTmS/FaHW4aVgy0dBKg/2+5Tq0WZfLCF0Co05JXPHxD+BLj/5IjiRCiv5GJEs8Jfe4p6RHLFvX4YJtv1uepBI9I2MH48IXcl8QD6rn6LkRxuOsmnARtn4T2zI/D2C6BV2J8snmB8I8xrnFoG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771006194; c=relaxed/simple; bh=rA+ZGUwf97oKWuIzYbm3bITITE+6t/DJLp8nSkOBXIE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=LdGKExYdhB5vSwJfacH35xFDNt5siAdhWsOk7yzH35sW888Ry3RssxrBLU+4BFpMrR848WsKRdMoJeAsbyVvNszPPpL7eFqzP8jqoS6HtPitZ40VpWsYB6Y4eZjK4S5ahrgEwse2q7yCfqv8jOsjcgFwGU9tkJmu3Pi3GZ6tRAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SxS0Rrs6; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SxS0Rrs6" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-12721cd256bso1678206c88.1 for ; Fri, 13 Feb 2026 10:09:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771006192; x=1771610992; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=rA+ZGUwf97oKWuIzYbm3bITITE+6t/DJLp8nSkOBXIE=; b=SxS0Rrs6eN5mF+JGIwwQidYghilkvUqHXDzWFxLuy4YroEmQF66PyMwiXfdBlyQKYs 01RSGrcXeVFiiy2iRg4bUOOMNtgZ/HqDeEVRZNj7krWjlDsbdp8e8W+RMmpNJvPxFawr B42fzSGjUAoXUoPoAdqyDLpcTd6uoM8p2W4xvGlHiooLF3/gxHKTZzBsul8i9TbbZI2S XuY0VWC5odJy1mAF9TA+kPPXlq06/z8MMkLYdgQnYBkrXFauzc4vv7inYUux79gBmaKb 0Cj1GF2sHMm8qzxr0ZyTOfvlHA5eVQe45x3j9NQVxJ2XM9ALnKJe7YcI1HztOHmI7POK YJIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771006192; x=1771610992; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rA+ZGUwf97oKWuIzYbm3bITITE+6t/DJLp8nSkOBXIE=; b=dAwrZ2dYSoz/B+ky+/hHY6P8vog8VsawzQsYh49Vb4i4AKDcof3pwvQqsUjvVQ8yXN uJHCqm1tEXg84esRfBVM559GAvl8HOyo0ARMnxgq1fDZSQ2XLO8DyFHDJALul/P+zIW9 KORviQRy3NAG8Np6iovYjObGo6GS5ltElwg1RUkRW3sYe7LND2KNM+QGnChlcY0KRkp5 aALhIUoroG42C2TeRqrLaTav5+0WNR0Ivrt+PDbfufm+mzVbSsPA2t+yQRkm3kN4MGxr IUJAEEmSSXf6exjre6V8TyzUZtRmhxG3C55WzFT38CHQsVTv97F45XqBmAFmrUjrrREU 3KKg== X-Forwarded-Encrypted: i=1; AJvYcCVJfIJrUiZY339QD1sH3m05yu3RpLqb/FgfpG/TIM7LkclFPGQKn5HIatppLSB2leczHiRQJ5OZisZX7bY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywv7W9MxY8MjTBmdo8UwGzq3K2YeS9KRXUjdwhRezWAoRG4h7oX ltqMXJYVFc0MlCObj6sE5eIOkIKUUJ8ZbAloqGyYTgXYQmI7IO88Ri3q X-Gm-Gg: AZuq6aKBz/sSjIt2I8DvtFT9uLe9LuuxZBRPTn5cg4LGGALfrafu2z6/nTjSCTnRyhW JP/8NdBsTdjb/OH3so2u3SCDC13vc9TLfutjNW8KwL+0f9l6zVUX31Bs9kdZtFBdkTNZ/qvq1Dj DiTFRTS9jF2QSIDMM1oltPOwFmft2bVXn2wuLc//EelBBqGIgPBReZ1/Wjd2X3dXhhMHViOh/4D XVNxhTat+5WTcZVqdFpeBYsL/H7LxcEtQmBpKQs94SSRCo9WfJVUDJz7TvfrUBgSiOsbWTnFtil D1KK60ksucWYTo8SzdQcqnNWQJK6quz4kXE/b03aB2ywf0U2w6m28Tra5n9otrJ1FIUuRvb4BlN i2EKeG8bdR4A+I+YDpyLTcWDiVjeyyLeAWSqQYeYPOhuWQf1sWVPXP+bnjSd41z7NLCc/PQ575E 8kv56qtbfZlvs7cO2K9Yn7B7nE+xkIESvo48iGZ5HZwVcC1U8JzL2ONtRr+zqJvEShJvrumATzh ppi0OkE X-Received: by 2002:a05:7022:45a8:b0:119:e569:f626 with SMTP id a92af1059eb24-12741bc8629mr153992c88.31.1771006192199; Fri, 13 Feb 2026 10:09:52 -0800 (PST) Received: from ?IPv6:2a03:83e0:115c:1:8da8:cd8b:c759:e11f? ([2620:10d:c090:500::2:357a]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1272a6e943fsm6787843c88.11.2026.02.13.10.09.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 10:09:51 -0800 (PST) Message-ID: Subject: Re: [PATCH bpf-next v1 00/14] selftests/bpf: Fixes for userspace ASAN From: Eduard Zingerman To: Ihor Solodrai , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann Cc: Amery Hung , Mykyta Yatsenko , Alexis =?ISO-8859-1?Q?Lothor=E9?= , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Date: Fri, 13 Feb 2026 10:09:50 -0800 In-Reply-To: References: <20260212011356.3266753-1-ihor.solodrai@linux.dev> <4150f31f020710932def63e2857ebab1e311b597.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-02-13 at 09:56 -0800, Ihor Solodrai wrote: > On 2/12/26 3:26 PM, Eduard Zingerman wrote: > > On Wed, 2026-02-11 at 17:13 -0800, Ihor Solodrai wrote: > > > This series includes various fixes aiming to enable test_progs run > > > with userspace address sanitizer on BPF CI. > > >=20 > > > The first patch fixes the selftests/bpf/test_progs build with: > > >=20 > > > =C2=A0=C2=A0=C2=A0 SAN_CFLAGS=3D"-fsanitize=3Daddress -fno-omit-frame= -pointer" > > >=20 > > > The subsequent patches fix bugs reported by the address sanitizer on > > > attempt to run the tests. > > >=20 > > > The series is a pre-requisite for enabling "test_progs with ASAN" > > > workflow on BPF CI. > >=20 > > Also, do we want to have ASAN enabled by default? >=20 > I don't think so. At least not right away. >=20 > > If it would be enabled for CI, people will need to deal with local > > configuration anyway. It might make sense to put the default flags in > > to save everyone the trouble of figuring out which flags CI uses. > > Wdyt? >=20 > WIP CI changes add an *additional* test job, that builds only > test_progs default flavor with ASAN and runs it. Previous test jobs, > built with -static, are still there as usual. >=20 > There are tests that don't play well with ASAN such as BPF arena > tests, and some tests may be much slower when ASAN is enabled. > We still want to run them on CI. Fair enough. > I don't see why we should pick between asan everywhere or > nowhere. At the very least, CI should make sure selftests can build > successfully without the asan flags. >=20 > Additional job will catch most of bugs of the sort covered in this > series, and that is good enough I think. My main concern is that when this fails on CI I will have to dig through CI config to recover exact SAN_CFLAGS used. If not enabled by default I'd still like to have a single knob like 'ASAN=3Dt'.