From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752108AbdIKQd1 (ORCPT ); Mon, 11 Sep 2017 12:33:27 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:52461 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751422AbdIKQd0 (ORCPT ); Mon, 11 Sep 2017 12:33:26 -0400 Subject: Re: [PATCH] ARC: reset: remove the misleading v1 suffix all over To: Philipp Zabel , Vineet Gupta , "linux-kernel@vger.kernel.org" CC: "linux-snps-arc@lists.infradead.org" , "Alexey.Brodkin@synopsys.com" , Eugeniy Paltsev References: <1504202767-17361-1-git-send-email-vgupta@synopsys.com> <1505125697.26622.22.camel@pengutronix.de> From: Vineet Gupta Message-ID: Date: Mon, 11 Sep 2017 09:33:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1505125697.26622.22.camel@pengutronix.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.10.161.108] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2017 03:28 AM, Philipp Zabel wrote: > Hi Vineet, > > [added Eugeniy to Cc] > > On Thu, 2017-08-31 at 11:06 -0700, Vineet Gupta wrote: >> There is no plan yet to do a v2 board. And even if we were to do it >> only some IPs would actually change, so it be best to add suffixes at >> that point, not now ! >> >> Cc: Philipp Zabel >> Signed-off-by: Vineet Gupta >> --- >> P.S. Philip, if you and Eugeniy are OK, can this be please squashed >> with his original patch since it has not yet been merged etc. > This had been merged into arm-soc already, and by now is merged into > mainline. We could try to queue this as a fix for 4.14. OK - do you want a respin ? > > [...] >> --- a/drivers/reset/Kconfig >> +++ b/drivers/reset/Kconfig >> @@ -34,11 +34,11 @@ config RESET_BERLIN >> help >> This enables the reset controller driver for Marvell Berlin >> SoCs. >> >> -config RESET_HSDK_V1 >> - bool "HSDK v1 Reset Driver" >> +config RESET_SNPS_HSDK > I suggest to drop the _SNPS part, we don't do it for the other drivers > either, and so far I'm not afraid of conflicts with other reset > controllers that may be called HSDK. It was not so much about namespace conflict but calling out that this is SNPS part ! But I'm fine with what you suggest, since the updated menu string does have it. Thx, -Vineet