From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761274AbdDSIx6 (ORCPT ); Wed, 19 Apr 2017 04:53:58 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:40583 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760970AbdDSIxy (ORCPT ); Wed, 19 Apr 2017 04:53:54 -0400 X-AuditID: b6c32a38-f791a6d0000031eb-8b-58f725a07a1a Subject: Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric To: Stefan Agner , balbi@kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Opasiak Message-id: Date: Wed, 19 Apr 2017 10:53:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-version: 1.0 In-reply-to: <20170415013509.20844-1-stefan@agner.ch> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42LZdlhTT3eB6vcIg62LNSyOtT1ht2hevJ7N 4vKuOWwWi5a1MltsXtfO7sDqsfj7PWaPTas62Tz2z13D7vF5k1wASxSXTUpqTmZZapG+XQJX xo2X19gKPvJX/H50kbWB8RNPFyMHh4SAicT37+ldjJxAppjEhXvr2boYuTiEBHYwSiyatYYJ wmlnkthz+Aw7RJWJxPWdnawQiTmMEtOfL4Squs8o8f7ubmaQKmEBd4mNjxqZQGwRoI7dE86x gqxjFoiUuPtKAMRkE9CXmLdLFKSCV8BOYs3STrBOFgFViRlzXjODlIgKREj0n1GHKBGU+DH5 HguIzSlgKnFy9VEwm1nAUeLBop2sELa8xOY1b5lBrpEQ6GaX2PtzPiPEk7ISmw4wQ5zvIrH4 w0JGCFtY4tXxLVBvSUus+neLCaK3mVGiY88zFghnAqPEtnWHoKqsJf6smsgGsY1P4t3XHlaI BbwSHW1CECUeEmeeXWSFsB0l1l+8CA3RDkaJKT/WMk5glJ+F5KFZSJ6YheSJBYzMqxjFUguK c9NTiw0LTPSKE3OLS/PS9ZLzczcxglOGlsUOxj3nfA4xCnAwKvHwGoh/ixBiTSwrrsw9xCjB wawkwnta6XuEEG9KYmVValF+fFFpTmrxIUZpDhYlcV7R9dcihATSE0tSs1NTC1KLYLJMHJxS DYxT1Tf5Hk9ZxOPGbdLwx/jbmrvZF4w54ms59yx648m1RrG32U8o7rGLtj+b546rVVlJbk8+ rGg2D0rsY2efzL9TrVs3ZP0D40Wlk2dl7zvwau9ntdNdu46u/WVuFbnPvnDF238TpQ7vPv8/ 8OCp5b3fGP66X9nAujfuevpS8Xk/zcv9HXedfftdiaU4I9FQi7moOBEAInuRRRUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRmVeSWpSXmKPExsVy+t9jQd0Fqt8jDL40Slgca3vCbtG8eD2b xeVdc9gsFi1rZbbYvK6d3YHVY/H3e8wem1Z1snnsn7uG3ePzJrkAlig3m4zUxJTUIoXUvOT8 lMy8dFul0BA3XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04OAe4Byvp2yW4Zdx4eY2t4CN/ xe9HF1kbGD/xdDFyckgImEhc39nJCmGLSVy4t56ti5GLQ0hgFqPEorMnmSCch4wSl2dtYQGp EhZwl9j4qJEJxBYB6t494RwrRFEXo8SdZc+Aijg4mAUiJbY0iIKYbAL6EvN2iYKU8wrYSaxZ 2skMYrMIqErMmPMazBYViJC49bCDBaJGUOLH5HtgNqeAqcTJ1UfBbGYBW4kF79dB2fISm9e8 ZZ7ACHQlQsssJGWzkJQtYGRexSiRWpBcUJyUnmuYl1quV5yYW1yal66XnJ+7iREcRc+kdjAe 3OV+iFGAg1GJh/eGyLcIIdbEsuLK3EOMEhzMSiK8p5W+RwjxpiRWVqUW5ccXleakFh9iNAV6 ZCKzlGhyPjDC80riDU3MTcyNDSzMLS1NjJTEeRtnPwsXEkhPLEnNTk0tSC2C6WPi4JRqYBQ5 KqMyr5Qn5VqLkQZnaNgZP/b+RYtOzfJprTcJF20pMPn9/WRgfpCnSUKbeM7JhUdmMktlecZu v+9yld960hote9XgFewvunvNHzsWBp92jD8UoPf5fE/6Rf6cjXunXOlpadu0rvli5U2bHVc2 Hao/usa7saf+tGP521pH5zs8rtce9Kv8VGIpzkg01GIuKk4EAE30Qea4AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170419085352epcas1p40f546c143f71cd3ba5bd6844bb0c953b X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?S3J6eXN6dG9mIE9wYXNpYWsbU1JQT0wtU3lzdGVtIChUUCkb?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?S3J6eXN6dG9mIE9wYXNpYWsbU1JQT0wtU3lzdGVtIChUUCkb?= =?UTF-8?B?U2Ftc3VuZ8KgRWxlY3Ryb25pY3MbU29mdHdhcmUgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTY=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170415013337epcas3p4871e4a671b352fed711acaf38803095f X-RootMTR: 20170415013337epcas3p4871e4a671b352fed711acaf38803095f References: <20170415013509.20844-1-stefan@agner.ch> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/15/2017 03:35 AM, Stefan Agner wrote: > Currently qw_sign requires UTF-8 character to set, but returns UTF-16 > when read. This isn't obvious when simply using cat since the null > characters are not visible, but hexdump unveils the true string: > > # echo MSFT100 > os_desc/qw_sign > # hexdump -C os_desc/qw_sign > 00000000 4d 00 53 00 46 00 54 00 31 00 30 00 30 00 |M.S.F.T.1.0.0.| > > Make qw_sign symmetric by returning an UTF-8 string too. Also follow > common convention and add a new line at the end. > > Signed-off-by: Stefan Agner > --- > Resend as discussed here: > https://patchwork.kernel.org/patch/9548869/ > > Sorry, a bit later than we discussed... Hope still not too late? > > -- > Stefan > > drivers/usb/gadget/configfs.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c > index cbff3b02840d..863ca4ded1be 100644 > --- a/drivers/usb/gadget/configfs.c > +++ b/drivers/usb/gadget/configfs.c > @@ -787,9 +787,13 @@ static ssize_t os_desc_b_vendor_code_store(struct config_item *item, > static ssize_t os_desc_qw_sign_show(struct config_item *item, char *page) > { > struct gadget_info *gi = os_desc_item_to_gadget_info(item); > + int res; > > - memcpy(page, gi->qw_sign, OS_STRING_QW_SIGN_LEN); > - return OS_STRING_QW_SIGN_LEN; > + res = utf16s_to_utf8s((wchar_t *) gi->qw_sign, OS_STRING_QW_SIGN_LEN, > + UTF16_LITTLE_ENDIAN, page, PAGE_SIZE - 1); > + page[res++] = '\n'; > + > + return res; > } > > static ssize_t os_desc_qw_sign_store(struct config_item *item, const char *page, > Code itself looks good to me and from libusbgx perspective it's also fine to add this new line as we can just drop it like we do with other newlines in case of gadget/config strings. Reviewed-by: Krzysztof Opasiak Best regards, -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics