From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D75494A3D43 for ; Tue, 13 Oct 2026 19:04:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791918271; cv=none; b=HdiAcoHJhUwCEunFfI8+NEvfmbvWxUk4f5a1S9FrwDKaPEheiOFNGE9dWAx3tOa5W2V685wYEWlznFU7OAedsJNtJYXjl7qKttNBJbNRT6MKgV/n8OK+lPJtmB1ZareBig/EOH3wEqNCiBqLsqurJtEyW5hcYzKtmiNmt3HC12o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791918271; c=relaxed/simple; bh=PVG+fL6tWhRaYjr50UkRjI82YcG7H2Vhz2OQdtPhIvI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B4xPbqdIgHDSedm6WnXfSlz4tRe0IvhCki7ywELC8x17L5oafEwLF2AG1iRWDN5bOFtCdGXBQQgUZ9g+KVhRczvJ5SnCYNTMZ9FANnHkdH1qJK0TguO1gRC7WapyXbpzNefer1Vwf7KcymACilVKucrIS6SPd5xOSecf7AwGd5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K5XOyA3X; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K5XOyA3X" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-c2dc8cb0decso25821866b.2 for ; Tue, 13 Oct 2026 12:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791918268; x=1792523068; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dw+YFgILYLXDibJ1USxmY+eqnIWA3ZQcZYKp70r8oiE=; b=K5XOyA3XRCnyAP6Rk6namb9KAnorIwrJEG6OwJ1BX2eEr73GjYkZr8v9RhB8uOS9rM l8jjpSvIlvPuEpUw7qJ7DFKKE5dOh5sfeHPFX4tly04X/fge2zMop7c5fNQ52HWNM8Re KkFGTJd5HK7n7X5NF60m8cmI0Xc/6AKPi8Wi9RVnsP/NpCgFz1gK4HeLDPEk0a8mOBhN lo0qZHLSN1WRXROkazCY1YLbytPqOmrQCubN6E7wWfUcbu8NdHrD+4aH3o5lMKhR5CF9 /9UNvC929mpdngqsiNXAEifRZWvqCRU2RQDhP6gSIQGqVKwIzp/sDWbY4cVl7NkSohOj IVXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791918268; x=1792523068; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dw+YFgILYLXDibJ1USxmY+eqnIWA3ZQcZYKp70r8oiE=; b=kE2ZaSh3DQ8IVsM7pzSXQJkbj2LT9eRfnmnmxQ/Vua4gYS4pXZnjqaWiozxZf1ksez 9igsLmW4X4LE7X8n3Muib+xxgtzbMKzor9OV/Kk9BPyaOewbZJdImDW+tUcEQGYw6gYe zKPmvTzXhIui1CHjqKLo21yQGPHqK+I1ManrDNcwFso1ATPStNhHEvQUg5BNsczdZ/qh F2WqebJRYR7EibCv7wKHrloB9Xqda5i+keSHJHhaNfuKv5CiWHxONoX0UuSW4tp14lmC weXs2LaFj4XrMt8VKrdtpIoPmJwlgAUPi8gyUEOCHZJOyZxAOLFL/5iVtuIYlHrlCsHf D5XQ== X-Forwarded-Encrypted: i=1; AKwUvBwE/F4SpyCPN+fQyen+vsXF986PtCKKQcZ2E68/qnXVpuGBYQag3aZ1JFli7E/1ClCKK66G2k0Wk+b4CYA=@vger.kernel.org X-Gm-Message-State: AFq9FYK4eDNdLGJFYWWN8o3IQSErFO0x5WwjGoFRRz1ugvh30ThbltR/ QcA8Va1c+Kybrn6s+6A+Eep+gZgRC3X17zPAdcNMqVQo1e3YuOXcoPs0XJpiaA== X-Gm-Gg: AYBFou0fFmnBrGB9Os4kPu9lBgLe/zyT5yzebBKcvwf+O2J+qmNgRoXNKLjK9yewBM1 vPB5efzv8PDEVBz1nMgrVQ3j8flHMM7mt8UelPq3TbQd8Dqg7Fxll2P8Sv9kowV9EucH2vQpsiu gR1Rb/aZ9B03mKzI+gMYXorml4Y3+dPTro/7vvcFu8zvlxNQpDp9TGD4K1o6XzzSpdo2cqnAJM/ PnioyIfHtJamw/4c3hJt9fbbubpDhMWz+/BcssaINA+IMxUrN00rN4yE4ZfJSc+gydBnVJ0Kipj g2jl2Y+ca6aNtfTmKf/R93klVyz/T/wFG+ITpIt6Q5KOFCG3lsB/hmM8Y67DSZA6oGRf6ut7CLQ N33XOMBENVm8hQtnUwoIZKXG0S87TyVk8JihrM072iVXs7ejvLBtSvx4qqtP7PXo7QSnleW2eEw J5mdgkREGlFWfllYLTxoSqtyxV9ULBs8XErLYuSEk+OjF3ha68pMRAeT+AuqNpTM77TT0TLeutt WY2wbh3C+w= X-Received: by 2002:a17:907:9615:b0:c24:adf4:5c73 with SMTP id a640c23a62f3a-c31a9a28825mr1274888966b.1.1791918267915; Tue, 13 Oct 2026 12:04:27 -0700 (PDT) Received: from [192.168.0.193] ([194.183.54.57]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c3596566d8bsm224558166b.16.2026.10.13.12.04.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Oct 2026 12:04:27 -0700 (PDT) Message-ID: Date: Tue, 13 Oct 2026 21:04:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/3] dt-bindings: leds: skyworks,aat1290: Document FLINH pin To: Svyatoslav Ryhel Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261007085457.98762-1-clamor95@gmail.com> <20261007085457.98762-3-clamor95@gmail.com> <6a69d4aa-d04c-4bb2-912f-1584abd31e0e@gmail.com> <4abc72fd-c645-4410-9387-3f03c751fd3c@gmail.com> Content-Language: en-US From: Jacek Anaszewski In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/12/26 9:25 AM, Svyatoslav Ryhel wrote: > нд, 11 жовт. 2026 р. о 20:35 Jacek Anaszewski пише: >> >> On 10/11/26 3:55 PM, Svyatoslav Ryhel wrote: >>> нд, 11 жовт. 2026 р. о 16:28 Jacek Anaszewski пише: >>>> >>>> Hi Svyatoslav, >>>> >>>> On 10/7/26 10:54 AM, Svyatoslav Ryhel wrote: >>>>> Both the AAT1270 and AAT1290 feature a FLINH pin used for mandatory Flash >>>>> inhibition. >>>>> >>>>> Signed-off-by: Svyatoslav Ryhel >>>>> --- >>>>> Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml | 4 ++++ >>>>> 1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml b/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml >>>>> index a65d92522c9cf..596b5e284f44a 100644 >>>>> --- a/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml >>>>> +++ b/Documentation/devicetree/bindings/leds/skyworks,aat1290.yaml >>>>> @@ -31,6 +31,10 @@ properties: >>>>> maxItems: 1 >>>>> description: FL_EN pin >>>>> >>>>> + flinh-gpios: >>>>> + maxItems: 1 >>>>> + description: FLINH pin >>>>> + >>>> >>>> You don't seem to make use of it in your patch. >>>> >>> >>> I don't have to use it in my patch. This change completes and improves >>> hardware description of the AAT1290/1270. >> >> Still, If we don't have the use case I'd avoid adding it to not confuse >> people looking for its use in the driver. >> > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/writing-bindings.rst?h=next-20261009#n17 > > - DO attempt to make bindings complete even if a driver doesn't > support some features. For example, if a device has an interrupt, then > include the 'interrupts' property even if the driver is only polled > mode. > > - DON'T refer to Linux or "device driver" in bindings. Bindings should > be based on what the hardware has, not what an OS and driver currently > support. I'll leave it to the maintainer. -- Best regards, Jacek Anaszewski