From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758403AbdAKUiT (ORCPT ); Wed, 11 Jan 2017 15:38:19 -0500 Received: from mout.web.de ([212.227.15.4]:59265 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbdAKUhA (ORCPT ); Wed, 11 Jan 2017 15:37:00 -0500 Subject: [PATCH 01/18] mtd-cfi_cmdset_0001: Use kmalloc_array() in cfi_intelext_partition_fixup() To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Denys Vlasenko , Marek Vasut , Richard Weinberger References: <71189baa-8780-b80a-0b4d-9dae74763ba3@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Wed, 11 Jan 2017 21:35:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <71189baa-8780-b80a-0b4d-9dae74763ba3@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:MAH3kVpX6CxVUYAgaaXIkvW9NyzgjyaGhwGycv+iGI5uwqX+brk PE4FlckimBqh9zLUhq91u/MsDMRl1r1ZAFd5xEeEPKM4hS6NaNeowApMyZ5uvFbFK1q6Oyq nb4XDvAPkLsyXWkpVt37uMpNHeasQlEHWgNHt3Oi16bB0bAjXDcbg9ytI/wA4Ex1q5yfU/O C2wHLz2cCqjR5awXkbThw== X-UI-Out-Filterresults: notjunk:1;V01:K0:DDqWCMI+ybg=:KFwPy+VqEAE4MeauQqi0cZ 5AnZedzWw9m3A8KsVlCVCKDiqr23OR2EdOQO86lzC2uQVsB3b0oXrtMJ1cN8Pjirf1aW1R2OJ rftb9A6ycdqaYM64oFbE1jea9yXVO6ogIPhrjINwDbtXRH4sdCB/hUmLOChpVJXu5nWGKHstr E+5dycIleYYL3WhX2MJiHGjWE72S/Xi7owzIoJdtTucR4adMUttucye7U+Opkju1Xz+wX7k/5 GHbrf+5Uui86vHuT/qubHZsU7u+ezwXX/sNLDwvcqCR+cYdEGdgiUGbCfy2fqgsWg6mzZTqvu 2iVfBnTXjKc4V+DBVK2CCjn/u+W1fd1wrNoCZf+F5rfbCfzjJQ8A2DQ+pS/buIjhzr6kdfOz/ AfVhoGESYZg4TeTqDXY872lKWM0EQIx5gah/nmImGXFyMIu8VDIvyb8zvu9+0Y4DRQUM31Qkg QeW0vsyCYalRZzIDV4cNmxkLwfvAC0IgtQfBUx0FiUhdJNUtDKdpSQ25LMcZX99AndD0nJbRn zVe0XLPf48AxP9AC53xJFHxW1iLtJQ8RhNj2x1K/MomATGGuc6j2MvzeOaoexwHwE1sC5ybyy mUCKTQc5wdA+VnqV65rzCi0pt3GQon9OxlpZmlk+VZh1yHi3khT3IUm7udSjg+JCzXWgUqkzq /pvz2ZcnNW7b8jylJ+JgyvurZ7TlF3ECt6cHqVUhWSsQhtdrM72bj9FYg4x5UMnDu90DxsFcX M/MtM5Fy133kOMjQpmS19sg5jqdzmT+XP10/H4fz+5C1hTsm1/8C22E3ZbIG020sdeOCCvax/ j1qLess Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 10 Jan 2017 18:48:34 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/mtd/chips/cfi_cmdset_0001.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c index 5e1b68cbcd0a..68227aa74d22 100644 --- a/drivers/mtd/chips/cfi_cmdset_0001.c +++ b/drivers/mtd/chips/cfi_cmdset_0001.c @@ -746,7 +746,9 @@ static int cfi_intelext_partition_fixup(struct mtd_info *mtd, newcfi = kmalloc(sizeof(struct cfi_private) + numvirtchips * sizeof(struct flchip), GFP_KERNEL); if (!newcfi) return -ENOMEM; - shared = kmalloc(sizeof(struct flchip_shared) * cfi->numchips, GFP_KERNEL); + shared = kmalloc_array(cfi->numchips, + sizeof(*shared), + GFP_KERNEL); if (!shared) { kfree(newcfi); return -ENOMEM; -- 2.11.0