From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B767DC04AB6 for ; Wed, 29 May 2019 02:39:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87D4321019 for ; Wed, 29 May 2019 02:39:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726645AbfE2CjT (ORCPT ); Tue, 28 May 2019 22:39:19 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:42598 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725816AbfE2CjT (ORCPT ); Tue, 28 May 2019 22:39:19 -0400 Received: by mail-wr1-f67.google.com with SMTP id l2so494376wrb.9 for ; Tue, 28 May 2019 19:39:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=J4A3gO+D/kJ9f9+OkLDAhUkGDHlG2SK2HVzo3LKjuY8=; b=H746xZUbIWxOHa4dl9jAkNhy8/466KCfgBe7EfFkmHLQa3WGXzVJgwTB/DZuRL/bxu K8NHf5XNSNllQhUtbG/NOFNCX1sIJ2qgtFztzCKqAUDIZAiC9fYqlxCAXezTk772+IY7 vr8dl1ddgvnLONao9H4d/wswXiQX/iK9dvlaHIIvGP8/2muSoVeLgzXwAkZ0VBdVVqY1 Al4dCywKfvJXChYKBRZ6FylOQSThVdYFV2EblvO1SoyoLbCMe6husTUtnDW6S6D1V6IZ HZB6ldLP3c48zrlRsL3Rl5KcTmYjl7ERndVIQ/eW68DchFb3craghPlN/T321tSfdnAy 1Jwg== X-Gm-Message-State: APjAAAVUVftdcEfOdmQNUNPRPwqZnVxCFr5F03a/qsbuO01oVsYQbKmv jvmSh6MXxgaL+/F0BE1y9P29PA== X-Google-Smtp-Source: APXvYqzcaWw1y2lzWAprl6ksFktYxqsCbC7tmClfC61V9z0F8n3ONRJt9HwggzpIk7fsVSYydplyhQ== X-Received: by 2002:a5d:474c:: with SMTP id o12mr1623117wrs.23.1559097557977; Tue, 28 May 2019 19:39:17 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c43e:46a8:e962:cee8? ([2001:b07:6468:f312:c43e:46a8:e962:cee8]) by smtp.gmail.com with ESMTPSA id l190sm6075879wml.25.2019.05.28.19.39.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 May 2019 19:39:17 -0700 (PDT) Subject: Re: [PATCH v2 3/3] KVM: vmx: handle vm-exit for UMWAIT and TPAUSE To: Tao Xu Cc: rkrcmar@redhat.com, corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, sean.j.christopherson@intel.com, x86@kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, jingqi.liu@intel.com References: <20190524075637.29496-1-tao3.xu@intel.com> <20190524075637.29496-4-tao3.xu@intel.com> From: Paolo Bonzini Message-ID: Date: Wed, 29 May 2019 04:39:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/05/19 04:25, Tao Xu wrote: >> > OK, but should we just drop this patch? > Or add the VMX_EXIT_REASONS bits of UMWAIT and TPAUSE and handle like > XSAVES/XRSTORS: > "kvm_skip_emulated_instruction(vcpu);" > "WARN(1, "this should never happen\n");" Yes, this sounds good to me. Paolo